From nobody Thu Feb 03 11:16:38 2022 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8CEDF19BD2D7; Thu, 3 Feb 2022 11:16:40 +0000 (UTC) (envelope-from jsm@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JqGMX1sX4z4nDt; Thu, 3 Feb 2022 11:16:40 +0000 (UTC) (envelope-from jsm@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643887000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fLHhk3UuyXgerRlQwp1wBDR3QYvf4jqYaPqsSKpq9Qk=; b=TFU1szCT0xLTHvXncCu51HCTd4O07znBE+f4/oRclZQKyYudZDIwmbKPlGaIjWBq7LvSq3 /v5umwATUFKvZ1+A7MYtoFa5vCOCM42GJLS0u+IcNZPyVWlYkxo2IjoCITjj3hRe3j0TJL VRJhUelmkOsMi/PXKo+p0HIXE88/s8v05mJ3MQR/aNIScBD4iwHzaZByvu0079iFNF5Dxd agEbnAAfTph+D8DDiTgpJsVQL3OA4aaOY+nSxMAhPzE3tNw1pYtWoGwE+xV10MC9hDKzuh 3dTBHyg4mSFhljcyfr2d7UhqYarq8VZ9jqzKXD1C8OAJAfwJuxrzn3ARuUcrjw== Received: from [IPV6:2a06:4000:c189:1:1::2] (unknown [IPv6:2a06:4000:c189:1:1::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jsm) by smtp.freebsd.org (Postfix) with ESMTPSA id 92AA0239C4; Thu, 3 Feb 2022 11:16:39 +0000 (UTC) (envelope-from jsm@FreeBSD.org) Message-ID: <42609179-f079-02c9-c57b-263467f70814@FreeBSD.org> Date: Thu, 3 Feb 2022 12:16:38 +0100 List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: d950c5898a2d8733cd6e75e7ef82b08acac79b34 breaks sys/arm64/iommu/iommu_pmap.c Content-Language: en-US To: Konstantin Belousov Cc: freebsd-current , freebsd-arm References: <54083e67-8052-575c-aab1-ad1cce2a7a3d@FreeBSD.org> From: Jesper Schmitz Mouridsen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643887000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fLHhk3UuyXgerRlQwp1wBDR3QYvf4jqYaPqsSKpq9Qk=; b=Mj7DzrR8gUnp/968UzIpxub8yJ/66JDlaBIpnhK3AKMkKIY1v7+wUGEr2k3PoSRIKXPFOR SfaPc1iYUrNJDQgjNsy9Lb9wUF1MbkxpP16XG93VQPmCMpX+CNb3DAl1WP2HPpK7C5Utf/ nFRLUn7OEKL9eh694eDSN50HYnBYbNbhBBQXXSX46v8VEmpsvK+FPY9s6aVBT+4n0oecK4 5wU452s1SBl+2/8jHWzp0MzEBTOIxEbvniL7NG628fTjwoubLw6JwYRKL68anuuVrx7ehH JUTgAwFviZAVkFr8h1gFn6PDLs4jXrUGDeP/6JODqt+JC++zcgfsI9b2jwH0Pw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643887000; a=rsa-sha256; cv=none; b=bu3v+l1hAuY+Ou5vaDhw9tF90JEhYw3W07iWGdALwtHONTZZn7wDbd/JUB/CWsiKcxgAF7 0Mk/Ya3DabXClQSLYD+pZpwbEMsZwTJtgCvyj89EDnQdtBpyDGEr6qel8yjWbmHUsBGvTw tBblA7Jkrq8XSsDVyPbtUOqQ1tp5uQRI8gGbAXwE1gCw0c7qkEhmyqax7C5XmqpHIDUdLk pPU7hDUF1VMAivv1SxI4TWwnfk3Y65YwaYSz6yQuaQnRltxgaPQLP6eZSg853nZy3WWobc 2BJ5h9wieVFCDwNd7JOhIdij8Uo93FWECjtPFiK+Dx1uRbMLefk7ZURw1MxVqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 03.02.2022 11.59, Konstantin Belousov wrote: > On Thu, Feb 03, 2022 at 11:52:48AM +0100, Jesper Schmitz Mouridsen wrote: >> Hi >> d950c5898a2d8733cd6e75e7ef82b08acac79b34 breaks arm64 with options IOMMU. > Which kernel config is it? Or is it your custom config? > If the later, please provide it to me. > >> grep -nir vm_page.h sys/arm64/iommu/iommu_pmap.c >> sys/arm64/iommu/iommu_pmap.c:50:#include >> >> >> /usr/src/sys/arm64/iommu/iommu_pmap.c:539:52: error: implicit declaration of >> function 'UINT64_C' is invalid in C99 >> [-Werror,-Wimplicit-function-declaration] >> ./machine/pte.h:53:21: note: expanded from macro 'ATTR_MASK' >> #define ATTR_MASK (ATTR_MASK_H | ATTR_MASK_L) >> ^ >> ./machine/pte.h:51:22: note: expanded from macro 'ATTR_MASK_H' >> #define ATTR_MASK_H UINT64_C(0xfffc000000000000) >> >> >> How best to fix this? #include in iommu_pmap.c? > If the issue is with UINT64_C() only, perhaps something like sys/stdint.h > inclusion is enough. That was enough. https://reviews.freebsd.org/D34155 Thanks /jsm