From nobody Wed May 19 14:40:38 2021 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3A4C0622ACA for ; Wed, 19 May 2021 14:40:51 +0000 (UTC) (envelope-from kamalpr@gmail.com) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FlbC70yX1z3jdG; Wed, 19 May 2021 14:40:50 +0000 (UTC) (envelope-from kamalpr@gmail.com) Received: by mail-wm1-x331.google.com with SMTP id y184-20020a1ce1c10000b02901769b409001so3486346wmg.3; Wed, 19 May 2021 07:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=SKXeLOqNAqldujgdoaq0WFDfzFmETOzyPHoagLrTaYA=; b=cqEXnfYH+GeT2I8W+aLtEXbGP6VYlXnFLRK153sAHi/9Xi6kHLnF5FEuIAtzZt/xAX OdidStp2x7iVvjluKXtktGuaJD+0//J9pSFBQENQEqibniWrysrCut8JqJbKx6FVIhMT jSu4VswzTe5w5vaFof5Mx+aWGzXCWuA4SyDGPjDRZbh+Ry2OCbJyqJeBm7U4n+Vscxnn 9+o3vUuKgDpppDJ69C50M2nb4wDXJUZDXj8uh1NdAscywdbjVN0lKDSLX+8HOM+zwYx6 oHJ4Hz7RU4Akxj0oDTSoKeEgEwVo0lYEIfO1/KEchwplQTFdHrz6WlyMjgIAAA9LG8I+ BDng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=SKXeLOqNAqldujgdoaq0WFDfzFmETOzyPHoagLrTaYA=; b=FN2AJRLn/OdlaxLMfnC39Fp4xPiqeDwmxis7bQedzEWb3N5O5xa3OsuI+5j0G6QbBj Sus0a/Zg4ytmlBC+x7ehPQRCHXx0ber0aTipUKuJS0O6fP/tIVAU7L1m5lAtvXKu5KEd +akoIxM/JCbfPqnGdOThIa1IS9krJXS4omaBhp88aNf7UPGsWlPH0io+NBH+fdaEFigp 71FyhOLUccIomUn2w09OC/F9SnF44Z6ZlMBN+nvYabBFYUMsHEeQ2iUWlRj6bZHjKcVB Fvij41RD4AbZYiZOa7oSUYcfQCJVXL4Ud2nmh8bkCM0hZzLRv3fwJGMi/rc235HPtPUC 24mw== X-Gm-Message-State: AOAM533/rlU21OT2TLJUJOg0wYxKzfXoWKyF4wI4YwmPsEX8ltoUBH+C DA3oEiwVAxVDBc2ljyo2yptFhHMpmhSCx5kWOLDHpcr14l1I X-Google-Smtp-Source: ABdhPJyE+BrpIQ9flh05KE7aiJuZ/H/9vaIOKjljXerRO8TqqPDT4DgIAxQwza85GtBWbHmOEShuhVGvNJMQXOAsIG8= X-Received: by 2002:a1c:e907:: with SMTP id q7mr11537154wmc.1.1621435249433; Wed, 19 May 2021 07:40:49 -0700 (PDT) List-Id: Porting FreeBSD to ARM processors List-Archive: http://lists.freebsd.org/arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org MIME-Version: 1.0 References: In-Reply-To: Reply-To: kamalpr@gmail.com From: "Kamal R. Prasad" Date: Wed, 19 May 2021 20:10:38 +0530 Message-ID: Subject: Re: bcm2835 To: Kyle Evans Cc: freebsd-arm Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4FlbC70yX1z3jdG X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] the comment indicates that timeout value is too low. surely, there must be some place where the timing constraint is indicated because of which this quirk was put in. or is it that the datasheet doesn't require this -but in practice, the timeout needs to be increased? if someone else has added it -maybe they can tell me. thanks -kamal On Wed, May 19, 2021 at 6:50 PM Kyle Evans wrote: > > On Wed, May 19, 2021 at 8:12 AM Kamal R. Prasad wrote: > > On Wed, May 19, 2021 at 6:08 PM Kyle Evans wrote: > > > > > > On Wed, May 19, 2021 at 12:27 AM Kamal R. Prasad wrote: > > > > > > > > hello, > > > > > > > > in file > > > > sys/arm/broadcom/bcm2835/bcm2835_sdhci.c > > > > > > > > there is a constant > > > > SDHCI_QUIRK_BROKEN_TIMEOUT_VAL > > > > can someone tell me why this was introduced and does it correspond to > > > > anything in the datasheet? > > > > > > > > > > Hi, > > > > > > This was added by gonzo@ back in r242321. It doesn't really correspond > > > to anything in the datasheet, but before I committed r354560 that > > > moved it around I did try to remove it and observed that it was still > > > a problem with either the RPi3 or RPi4. > > > > > > Thanks, > > > > > > Kyle Evans > > > > Hi! > > > > can you tell me more on why removing it was a problem for rpi3 or > > rpi4? i am trying to understand the significance of this #define. > > > > thanks > > -kamal > > > > You'll find better insight from the comment at its definition and > implementation: > http://bxr.su/FreeBSD/sys/dev/sdhci/sdhci.h#60 > http://bxr.su/FreeBSD/sys/dev/sdhci/sdhci.c#1814 > > My very vague recollection is that the advertised timeout is too low, > but it's probably an implementation issue. > > Thanks, > > Kyle Evans