Re: Quartz64 (RK3566) clock driver and patches.

From: Mark Millard via freebsd-arm <freebsd-arm_at_freebsd.org>
Date: Mon, 26 Jul 2021 14:57:18 -0700
On 2021-Jul-26, at 14:47, Ian Lepore <ian_at_freebsd.org> wrote:

> On Mon, 2021-07-26 at 23:43 +0200, Søren Schmidt wrote:
>> What do you mean  by more context exactly?
> 
> Generate the diffs using 'diff -u -C 999999' so that the entire file is
> available for context, and phabricator's webui can be used to control
> how much context is visible.  Sometimes when reviewing code it's handy
> to be able to see more than the default few lines of context.
> 
> -- Ian

To expand on Ian's note by quoting from: https://wiki.freebsd.org/Phabricator

QUOTE
Create a Revision via Web Interface

Revisions can be created without having Arcanist (arc) installed by uploading a patch via the web interface. Patches can be created by diff, svn, git or other tools. 

To make reviewing changes easier, always include as much context as possible with your diff. Phabricator will automatically reduce the context in the default display and when sending emails, but it allows the full context to be displayed on demand in the web interface. 

To create a full diff, use one of the following commands. 

    git diff -U999999 other-branch > change.diff

    git show -U999999 <commit-hash> > change.diff

    svn diff --diff-cmd=diff -x -U999999 > change.diff
. . .
END QUOTE


===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)
Received on Mon Jul 26 2021 - 21:57:18 UTC

Original text of this message