From nobody Mon Jul 26 21:47:01 2021 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E92FD12DF2BA for ; Mon, 26 Jul 2021 21:47:12 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2k.ore.mailhop.org (outbound2k.ore.mailhop.org [54.148.219.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4GYYRh3zY2z4qfj for ; Mon, 26 Jul 2021 21:47:12 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1627336025; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=OSlfNpFVqwXjioB/36kRDvsljL6ApmaTY3lxz4OaYOeZn2VdM9lY0eh45srQexos1gnc3fpsXjB3k z0utxSijarmdIl77X0vpuvOuCP6yj5+po1yUG+nzgjppg2d90U8hZ8tD1dWKiBkPrMZyX9j5RHD8KK 6Licg21R5aw9L6/bbfYCUH3h6IwE2jdp+IxOpnjN90JbkAkG8BXyMFQok+0B2tqdI4iuQ/GgLC7N3z Rz5TukKBbYs8feN9pjRg0xuIsVvm0TtisMrVEfO3AZjK7optQyqxZbypS0SxflqolzaJdcDic0Fpd8 pbZEUWN9wKDxdnkAyxjGOJ4VH7lg2WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=lwTlPhmV+Za8i9OPq91D6t9la8SCF9J8WmrAUej1+E8=; b=RGxAQr1wH2DiHhunaZFdn6G+M/lXk39Pp4PQlAlPdClOY4lOqY6vp9vs4hOzcoxO/f+gaDjucC+eo G6F5y06cjSoh3LlXWMwHPg5xbWiUlPfYabVSt6tHeuCj+3frwh6ga4IZnaPyY911BuMsSZFlspm8YC /eUHikuTA/YQDWxGMT2A+DmRz85n5n2/5I1FJaIeG8VYYJ4+I2LhEZ8hUxJqJgXZs+FlJn/Ep092GC WcaKrILDdZRPXsgwRTmL6Nm98g3o9GpopMB+BwRpSntXfqEtBzY5f/Pikd0KDbT2eHSCmd1IUPr30J l5PsXcza6Y87KVy7PrAzRgzW3DUtSKQ== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=lwTlPhmV+Za8i9OPq91D6t9la8SCF9J8WmrAUej1+E8=; b=U3yJK0OUv1ZN8huEUn7fQECup54IjkY4b5EUwsI/Ue9jFVT6U3f1HwPpN12Wgw3IGFIRsfvLySgtQ DHA3opEmFuv1jdIC8J9IvcXNl3Qax6Wj69kge3PNulptlYgUGVAaAXjt27fZa5omXGsAmRur2qo5hs rVLb86STGjlfs3wCaRGij0u0iHuS4QoWTxmj020+UF+e/We81vJAiE3mSVcgudLUwGBh+SQEeCi9Kd qk7yLST7H9EPaZzeE4RrWRFRgtuHN5JW/dQzZpy9s2Zvs3yfR3xOP+P5FnBjbcgf+bo5vb75iESH55 C7m6dwRHsS/EEgbGV4OY62MGaKVqcSQ== X-Originating-IP: 67.177.211.60 X-MHO-RoutePath: aGlwcGll X-MHO-User: 027a946e-ee5b-11eb-a657-89389772cfc7 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 027a946e-ee5b-11eb-a657-89389772cfc7; Mon, 26 Jul 2021 21:47:04 +0000 (UTC) Received: from [172.22.42.84] (rev2.hippie.lan [172.22.42.84]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 16QLl1sd043054; Mon, 26 Jul 2021 15:47:01 -0600 (MDT) (envelope-from ian@freebsd.org) X-Authentication-Warning: paranoia.hippie.lan: Host rev2.hippie.lan [172.22.42.84] claimed to be [172.22.42.84] Message-ID: <6476eeb75b1d3c1e8016fbf80f9f433ecbc82e98.camel@freebsd.org> Subject: Re: Quartz64 (RK3566) clock driver and patches. From: Ian Lepore To: =?ISO-8859-1?Q?S=F8ren?= Schmidt , Emmanuel Vadot Cc: Free BSD Date: Mon, 26 Jul 2021 15:47:01 -0600 In-Reply-To: <1C01DBB7-778C-431C-A980-AAF56F0DEA4A@gmail.com> References: <20210726195037.59165880a49ef24d1cb89833@bidouilliste.com> <1C01DBB7-778C-431C-A980-AAF56F0DEA4A@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.3 FreeBSD GNOME Team List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4GYYRh3zY2z4qfj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_RCPT(0.00)[]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mon, 2021-07-26 at 23:43 +0200, Søren Schmidt wrote: > What do you mean  by more context exactly? Generate the diffs using 'diff -u -C 999999' so that the entire file is available for context, and phabricator's webui can be used to control how much context is visible. Sometimes when reviewing code it's handy to be able to see more than the default few lines of context. -- Ian