[Bug 209441] SSHd in FreeBSD 10.3 complains about PrintLastLog

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 18 May 2022 17:34:17 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209441

--- Comment #17 from Ed Maste <emaste@freebsd.org> ---
It looks like this originated in

commit a2438bbd28eb35a8968d193ac89b30a90e96f719
Author: Damien Miller <djm@mindrot.org>
Date:   Fri Mar 15 10:23:07 2013 +1100

     - (djm) [configure.ac] Disable utmp, wtmp and/or lastlog if the platform
        is unable to successfully compile them. Based on patch from des AT
        des.no

which added

+AC_CHECK_MEMBER([struct lastlog.ll_line], [], [
+       AC_DEFINE([DISABLE_LASTLOG])       <-------
+       ], [
+#ifdef HAVE_SYS_TYPES_H
+#include <sys/types.h>
+#endif
+#ifdef HAVE_UTMP_H
+#include <utmp.h>
+#endif
+#ifdef HAVE_UTMPX_H
+#include <utmpx.h>
+#endif
+#ifdef HAVE_LASTLOG_H
+#include <lastlog.h>
+#endif
+       ])


this defines DISABLE_LASTLOG if we don't have lastlog.ll_line, but this is used
only in (the two implementations of) lastlog_get_entry; utmpx_get_entry is
still functional.

Can you try building with this change?

diff --git a/crypto/openssh/config.h b/crypto/openssh/config.h
index 943f8c6e4b6e..4e0261b6a60a 100644
--- a/crypto/openssh/config.h
+++ b/crypto/openssh/config.h
@@ -113,7 +113,7 @@
 /* #undef DISABLE_FD_PASSING */

 /* Define if you don't want to use lastlog */
-#define DISABLE_LASTLOG 1
+/* #undef DISABLE_LASTLOG */

 /* Define if you don't want to use your system's login() call */
 /* #undef DISABLE_LOGIN */

-- 
You are receiving this mail because:
You are on the CC list for the bug.