From nobody Wed Sep 30 16:55:49 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hw1QG5WFNz6tq1b for ; Wed, 30 Sep 2026 16:55:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hw1QG2F3Kz4k6w for ; Wed, 30 Sep 2026 16:55:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790787350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YiQ3UhgrxrcbtxhClP4VmqWgOd3FMPe07c98RxD8L10=; b=XzoZ4YkCwEi413XmFNMOT9RA0XcO/2UgsNVI4I//qGOWHz+gv+r0bYEB3PBBzoByaW0Ky5 pGOoWB1ldwKH7XZwoshkiON5co/Nvsoz/zTeaXwHOSXy6BEjgrME41N1V2poJ2jW1h97KL dWxMlrodaWDBkRolg2ei2ygVAZjIgWLoxzWTOBIO13gUHE4fq61jqcyYyI+YnPu20Tt2aY 1TQVDE9zD6gDifsumaLlN2z+Lh0JlOJGNhanh3GxkAHF4OwwkyWhN/s2EbxK1aKnVy8z7d sWZ1A5yREGGBxueV1DR+NRBpLNiCZUuAkqZfU6Te6JjA6pBz/QOZsb0tdRuQ5A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790787350; b=THBWIu2Cb/d455C3NnUo0KY1e8btFjVmg8c7JucBVGLupF88+qu5pnToloZ/zka89aWhGy yGMiWTCyF40oSSlM/I19AygLR4ZwfX6m1DXDbkOu1z7GcSSIkKFJvUOVw8N/5HddvbUzD6 lniFV9jBIqk3YRkbJs1TGVWHS8HBjVgoKqbv9g9qVokX094asW+tE9LC/5Hzf2GuwlNBCP TNOi1nO9lbnELLoOKVjxNWuewgrsnqD8gkInADyToBY5mU8SutOPcMWywc92gPc4vzTaHd ku3cc4dCihMAFjs6NLBo2Kih5wwJSdV3wzd7izLPPxMQG+mvMf5cBdwZ4T0bng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790787350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YiQ3UhgrxrcbtxhClP4VmqWgOd3FMPe07c98RxD8L10=; b=y3LCZasqi3C44sOmTu7yhigkrdXxj+8ikLxxHKp2fAhKUhgYfV3NLoOTXQCHQdaRygyvj/ hhvYnHcDHVH4ISReT5pD9JJmvSodwGC0PXZc/aDGwEKkSx14+AnxB44f48bngRgF7tj5T6 AU2k+72oV4RbRAe3e5HRR4i2r2PjqXxyNURnSkM6jorxYViq56QtZ/4H3CCMbv/i91ZTo5 WlEjzVnoNV2IF2oXoo0M2Shs735IZF76qbzuPtAqsHTp65g3HsMT+eosp7khKXnqIHt8yA XAV+1rLIWVduWc6Heyz7kuPHhV5Na7fDFXgqCfSg2SCZb2e5YCkF37EMSnuYfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hw1QF6pFrzsqm for ; Wed, 30 Sep 2026 16:55:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39f89 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 30 Sep 2026 16:55:49 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: b212f565fb1a - main - libfetch: Plug leak in 304 Not Modified case List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b212f565fb1a34fdcd2f5c9530164ff4718a1a9f Auto-Submitted: auto-generated Date: Wed, 30 Sep 2026 16:55:49 +0000 Message-Id: <6abd3f15.39f89.11952813@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=b212f565fb1a34fdcd2f5c9530164ff4718a1a9f commit b212f565fb1a34fdcd2f5c9530164ff4718a1a9f Author: Dag-Erling Smørgrav AuthorDate: 2026-09-30 16:55:18 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-09-30 16:55:18 +0000 libfetch: Plug leak in 304 Not Modified case When we get a 304 Not Modified response, we need to go through the error path to properly free any resources we've allocated instead of just returning NULL directly. MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D60016 --- lib/libfetch/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libfetch/http.c b/lib/libfetch/http.c index c5415b875155..8fe98c57446d 100644 --- a/lib/libfetch/http.c +++ b/lib/libfetch/http.c @@ -1986,7 +1986,7 @@ http_request_body(struct url *URL, const char *op, struct url_stat *us, if (conn->err == HTTP_NOT_MODIFIED) { http_seterr(HTTP_NOT_MODIFIED); - return (NULL); + goto ouch; } /* check for inconsistencies */