From nobody Tue Sep 29 19:19:39 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hvSfg6Lp5z6v05N for ; Tue, 29 Sep 2026 19:19:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hvSfg5qslz4Pgc for ; Tue, 29 Sep 2026 19:19:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790709579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gdukyNkFwErV/qNjWn3O2G9SZVHgFKRqXpF/icZdtM4=; b=VEJp1QjF5J+0AM22IMSjTH9OIa/0jANySK3RyGJWFv7Vidz8cSFvjQ7bY+prNylCxxOkTn zf6BOqIrTMvNZbM3YqQvJVX26NI3tVinELVQqg6tuvRHDo0RKcZROjclY5D24NUj4resj6 BgCnfFbBFXq0DKhsAblYEaPh727iM0N4eVnSgEE2NLB63DXxFqR84c9XTWZ3N46gEn934t r5U4yzZWiNJdObzXmk30O3yjobbXzpRKRVXXORr1hXM4rfNa3NnAZluDt+UPk1Yxn9YHGJ f1R4fMgqbgufPbI+RzfF6Hh7VgiZL4ivJ/363JCky6xjcjl6+tolT8bh5mkwhw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790709579; b=DkciwO6dO6qfAPWlq4y+ILBxT5BZVI1HCnMqBQCkKH8i4cFPbBZ6vwwWXba3tpHqXvnZVG bl+9NegB1D6KUD/SZKwrnzEhdNONKjMjIkAYDTK4RwktDhJNWNvwLdCOgJsJMhojE+dsnk 6W6xu7MGvAn0VPxo+ykQjZ3VOsDB+0Xiq6hyERHZ998BzK/UeOEsWL1pNq6hKCbxHC/+Oe xDGHU8A1JE5y+dNIoyGJ7SFeohVK/WancUvenPQrdJ7cYLSafEoKI7b+c1JCNNoIkuFOQ1 NDIcXtzAnSJbaOnNZ+HD9FBiwHKwF5CHBMRVWK5QDpz8bZqV/ZNqU0/4VcrweQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790709579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gdukyNkFwErV/qNjWn3O2G9SZVHgFKRqXpF/icZdtM4=; b=iNRV3m+nkYB6AV4fuUk09v6Q9cKxv/xlx9vS0McNO1VrQsUT8ZYh9hxFgzxR8Lhl7baSZs iMVxa9JrKnupG3MMfZ/mrWzJqhBD1nPzwwhuANeAEG5+FVe7TgL7Du9ZovK7M44IRF6PwI SxKG8L1TN0rcATFpeYYYyYxJng9lhCkH7J687Olq8I/ZHD53YMdTHufcYiX9GMMyuvXN05 BGKggMWqXEPcj9crJX1zwvdjmrD6ILF+g0wwrsRpaqWzoXjZaodDr2F8OyZdrE0jQuk+8W wgzBm/a0WaClXdaRcjyMJC1nR9FORPyRkLRP3m2dO0nZCIeKKAJ3JjkakmNHNg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hvSfg4sTZz1PcQ for ; Tue, 29 Sep 2026 19:19:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 443df by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 29 Sep 2026 19:19:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: R. Christian McDonald Subject: git: 57f9bad9188d - main - pf: deregister the ifnet_rename_event handler on unload List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rcm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 57f9bad9188d70272c131a6cc8502d00be58fd56 Auto-Submitted: auto-generated Date: Tue, 29 Sep 2026 19:19:39 +0000 Message-Id: <6abc0f4b.443df.20dfb2be@gitrepo.freebsd.org> The branch main has been updated by rcm: URL: https://cgit.FreeBSD.org/src/commit/?id=57f9bad9188d70272c131a6cc8502d00be58fd56 commit 57f9bad9188d70272c131a6cc8502d00be58fd56 Author: R. Christian McDonald AuthorDate: 2026-09-29 18:27:36 +0000 Commit: R. Christian McDonald CommitDate: 2026-09-29 19:19:19 +0000 pf: deregister the ifnet_rename_event handler on unload pfi_initialize() registers pfi_rename_ifnet_event() on ifnet_rename_event, but pfi_cleanup() never deregisters it. After "kldunload pf", the next interface rename calls through a stale pointer into the unloaded module: kldload pf kldunload pf ifconfig epair create ifconfig epair0a name foo Reviewed by: kp Approved by: kp (mentor) Fixes: 349fcf079ca3 ("net: add ifnet_rename_event EVENTHANDLER(9) for interface renaming") Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/pf_if.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/netpfil/pf/pf_if.c b/sys/netpfil/pf/pf_if.c index 3993a3ee4c13..aed1af15fb30 100644 --- a/sys/netpfil/pf/pf_if.c +++ b/sys/netpfil/pf/pf_if.c @@ -221,6 +221,7 @@ pfi_cleanup(void) EVENTHANDLER_DEREGISTER(ifnet_arrival_event, pfi_attach_cookie); EVENTHANDLER_DEREGISTER(ifnet_departure_event, pfi_detach_cookie); + EVENTHANDLER_DEREGISTER(ifnet_rename_event, pfi_rename_cookie); EVENTHANDLER_DEREGISTER(group_attach_event, pfi_attach_group_cookie); EVENTHANDLER_DEREGISTER(group_change_event, pfi_change_group_cookie); EVENTHANDLER_DEREGISTER(group_detach_event, pfi_detach_group_cookie);