From nobody Sat Sep 26 06:44:51 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hsJ373qSMz6tPWS for ; Sat, 26 Sep 2026 06:44:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hsJ372y2Dz3Mxt for ; Sat, 26 Sep 2026 06:44:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790405091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a/yu9ZW2ceCUFlhLi1BQwbCmzlPpZF2snLgbZVrgQ9s=; b=alym9HimFyUswbkJ7e/SIpyjph9ljgvpSpv+Qil62hvtfTwEddS3d3MFxmiMJtHbnv4NHg pWK4dgtTuhNEgyQUWZaEGzZ0VZpiN5UBWYk3AuVFFqhqqH6lfBVAkFZnAbIUqj9j/0TlwE 9Gm9TbYLnXIrhUvqsYvJYDLf+fbZYV45EArUkjSgE1hGnnmw/1eDimqzHDB5eLsKp0ZIc+ n670pIJUJzVcifxzyBInyBcYt4M1o6CODx2uWAwoWae65EViRzCHTZAkkc5rSU8S7CJ2gJ LUNXLOyJd/Iawo/b2v4AcvgpppuEp0S1muL+rHjXIWlHwz7hBmN2HUwkQEQ4Bg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790405091; b=m1h2yDceU5jGJqzkbwAkCT6ZChDwkq7YOP52IatDFPvrl6lInsQVQLCnjVGbHkbZUeDbaG 9N6TUYgWfTV1nBpt+3q4KJ/VM2/fdaP5RpT4eFqLTxSmFZQQTR6/ODt8JjQ9fqSc/MZdb2 z8JGg0rKrYmJ1s4NgAyBqSBZ+dqCq0nUHbh8p7s0Lhu14/bIoGEZ26dYf3HmXzaOKEJSij CdAoCRnp5/sTtez4McjCKdTgVD+vgfdmaODfvhBuFKRAcNz/nJDXnHCGCze7aBo2BFgXft rBxIDwTc+GMGHXeFiD8qDMG0rdcphU2hlHd2P1SSQe7IounrWJoCDkZG2xU5tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790405091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a/yu9ZW2ceCUFlhLi1BQwbCmzlPpZF2snLgbZVrgQ9s=; b=Vo9Mf7rTYnM2csackE9lmuNmKujmjN6ZLeoeGr1X94bliI/r+yXQ5fRry+WAjjg0NFdxzQ PvopndfbzB5BS4bejFUj8fpnUHRspsXpoFGERk5Wgi4PV2Y3h6a2r7e0a+TjG/d7DByDzP XSrykRSklbbHNxOzSgvY0wurwku72YgxmQrcLZO1Ps1xLZTnp23C0lXc42oF1/6cFaRmas 90pnSJHXDg9k95XrPayj/Pky0Hs1Ku/yqAhqj+s+1QNgwAh7ABkmgIrIjnAoZLLkKakDtP 5TresPRcdIjo6Fmd9udmb4wG2L/9Efb9xYH24Ui8m4f/gmFJlziEJWzIFCXK+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hsJ3720RZzmRH for ; Sat, 26 Sep 2026 06:44:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3679c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 26 Sep 2026 06:44:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 58741fa51dc2 - main - boot-test.sh: Add virtio-rng-pci to the EFI RAM-disk netboot qemu invocation List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 58741fa51dc207123c18b3a4125af99cab798898 Auto-Submitted: auto-generated Date: Sat, 26 Sep 2026 06:44:51 +0000 Message-Id: <6ab769e3.3679c.3cd5c46@gitrepo.freebsd.org> The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=58741fa51dc207123c18b3a4125af99cab798898 commit 58741fa51dc207123c18b3a4125af99cab798898 Author: Warner Losh AuthorDate: 2026-09-24 14:35:45 +0000 Commit: Warner Losh CommitDate: 2026-09-26 06:43:53 +0000 boot-test.sh: Add virtio-rng-pci to the EFI RAM-disk netboot qemu invocation Since the PixieFail security fixes (CVE-2023-45237), EDK II's DxeNetLib -- underneath essentially all of NetworkPkg (Mnp/Arp/Ip4/Dhcp4/Tcp/Http) -- carries a DEPEX on EFI_RNG_PROTOCOL. With no RNG protocol producer available, that DEPEX is never satisfied and the entire NetworkPkg driver stack silently fails to load: no error, no assert, it just isn't there. netboot-efi and netboot-ramdisk never noticed because they only ever touch the raw EFI_SIMPLE_NETWORK_PROTOCOL via our own net.c, which has no such dependency. A test that needs EDK II's own NetworkPkg (e.g. one exercising EFI_HTTP_PROTOCOL) is the first to be affected. RngDxe can satisfy the DEPEX from the RDRAND instruction alone on a sufficiently recent edk2 build, but not every installed OVMF is that recent. -device virtio-rng-pci provides an RNG unconditionally via VirtioRngDxe, regardless of edk2 vintage or host CPU features. Unfortunately, the edk2 shipped with qemu lacks the network this needs. Sponsored by: Netflix --- tools/boot/boot-test.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/boot/boot-test.sh b/tools/boot/boot-test.sh index 5ead7260d781..023d2589824c 100755 --- a/tools/boot/boot-test.sh +++ b/tools/boot/boot-test.sh @@ -277,6 +277,9 @@ qemu_netboot() { # we don't use the ipxe USB path we use here. We use that because Tianocore # expects http/https booting when the obvious '-boot n' sort of things # are used. +# +# -device virtio-rng-pci: EDK II's network stack has required an RNG +# device since CVE-2023-45237. qemu_netboot_ramdisk() { netif=$1 echo "$(param qemu_bin) -M q35 -cpu max -m 2g \ @@ -285,6 +288,7 @@ qemu_netboot_ramdisk() { -hda ${OUTDIR}/netboot-ipxe.img \ -device virtio-net,netdev=net0 \ -netdev tap,id=net0,ifname=${netif},script=no,downscript=no \ + -device virtio-rng-pci \ -fw_cfg name=opt/org.tianocore/IPv4PXESupport,string=no \ -fw_cfg name=opt/org.tianocore/IPv6PXESupport,string=no \ -nographic -monitor none -serial stdio"