From nobody Fri Sep 25 17:17:36 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hry7y53XJz6tgLV for ; Fri, 25 Sep 2026 17:17:50 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-qk2-x11.google.com (mail-qk2-x11.google.com [IPv6:2607:f8b0:4864:34::11]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hry7x2sBTz4bqB for ; Fri, 25 Sep 2026 17:17:49 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Authentication-Results: mx1.freebsd.org; dkim=none ("invalid DKIM record") header.d=kev009.com header.s=google header.b=FuAm0d+d; arc=pass ("google.com:s=arc-20260327:i=1"); spf=pass (mx1.freebsd.org: domain of kevin.bowling@kev009.com designates 2607:f8b0:4864:34::11 as permitted sender) smtp.mailfrom=kevin.bowling@kev009.com; dmarc=none Received: by mail-qk2-x11.google.com with SMTP id d75a77b69052e-52fb769ca17so10130961cf.2 for ; Fri, 25 Sep 2026 10:17:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1790356668; cv=none; d=google.com; s=arc-20260327; b=G80EzRRWzxtueZrNCHGkoLEOic1XFBmd0jUK8g+S4M9ObNJ64IVej+OFkV7lLxHxoX eGpLtyehR83uCf+lm03yp2tu+J5gjMuByirSrOQqXYEt52O5Y2w7eStRGRdjfk9fFWrs hGpfKpRn4MdDOtQ6Y2j3DQ0SMWlqcvKclO9OBR3sC3GKLiflBTFvwvYSgf7l5ng3PhcB /Hg8IYOwzHSctrwhL89udmDIGsa3QqUyCfDKFp5wgcrRZyL7NTWJsVWQafVf7g9NA1vQ MRFa9VqDDOyLFtp7Ogu0y8qE4orq8NhwTXkq7iDRQHfZRKlaBFpPtZ/BVpFWfNdKgYal 4LNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=bJDap4sF+N3tPNXhRJw/ne2jbllPmQWnyt71iAxQPpY=; fh=WzFlLMfQmzMZZad5cTRfi2qljdpc2e2gdGVfNEIIUf8=; b=OArBuNZEIwTznnnDsQrqHtFg/sV8oruZbGqtwPRtXEEpF7MOSMoKAwiq7L9pUKzba8 X59r2TUv6KIAwV83VhXKEK/Epj2NixOvDjw2ZatOVit+Nk3/q8LIX65QbimyEHNgD8I6 utdm3T15ZT/H0CwH+RJJS4Q4zRjQRKNygJolIcOYF3Ana06xXP4UUx6gomG3q/2kif+9 hYXz91unJR4UQe+eHwo33ISWfRvdUpF2bWAY45V78R0tRj9/smrlQt5ItGAcwIZsg8yA XQVndywKifuPp+idDXNWvImopfaTWJPDttMFW2Oy23THKiu02ZrzVfCF5YmXu3o4N4Sv gDwA==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; t=1790356668; x=1790961468; darn=freebsd.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=bJDap4sF+N3tPNXhRJw/ne2jbllPmQWnyt71iAxQPpY=; b=FuAm0d+dKdq1ZCo+ccbIE/76CWuIc3mw4SufqIES4aMkTqakrgQpdTJ3pcQD1FZnF/ vwkQpxmXRbcHkGa+G2aKZLsKMdQLRsjPwA7JW6TFPxVvTYFKbKXozRVx59s+XXFZ+QTR HSR2uZF41NfudwmCY5dKPz26vm3OsFHIi4fMQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790356668; x=1790961468; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bJDap4sF+N3tPNXhRJw/ne2jbllPmQWnyt71iAxQPpY=; b=MZl55D9YFjliwqILHm9YscP5ZCPxPup3eYnEcn/MbPNiwmH7DPLCM+iYDZu2JJLiyp 87Ex0tnV6IcXDxDslWYv9aBP/IUG3yjWmhRl3Hq3gulDSFc4RhqJZkQdH5NjrkDcmSFh 6YnInYQ98xYV+QqQPmag40DmU9tGe5DOX/nuHaDYN6UtTAgl+du1mz8l00sFq91geyK5 tLQhyFwU2JhbGe2BbjOC+750ffNkTp4ZH2QzUxp5d3X2eM3+sUqz23x8gbmpBmhrF3zW cQiJgGhShTKY0oKsAI90pB0Oo637hULIcQtUTqQ38qu9L6P8fvsHoDtUsMBDUNqsCbf9 rJvw== X-Forwarded-Encrypted: i=1; AKwUvBycpANxe9RS9Ayg76Mg8Cula+4LlWME9rkqbetonhTxlH/3cam91oILugUY9unGsW98G2BYz3jYgGAJGy8NCjaCyS7bJQ==@freebsd.org X-Gm-Message-State: AFuF++kwlHBroY+pLZT2Qa3/leBaArqk3VPMpZf1DND/w0F+LxbWWQ9t UvQlb3iBWCMJpBnehzKm5qOq/v2JZfNeU3DOS8Pyk/NxB6Jr3YFulpw5wvWE0nZWTErwbVz5sOO TguFe55b43ECe50JC7dBsWRzBMMQP7aK4KjyqnBbc X-Gm-Gg: AYBFou0oiZ8Y8oChRTSag4BxXm6OjNvLZFYYjPBh1BcD4UdcsIWVWruWG6/Ywon1QYV vEm4vHcouJpSnI+S9T0/P8WgoRfPfjIs5a2ARbCFELSep/DKWPPh3717wHF2SXoUzXYvVoyFVlF NNTFvpt1jLGcgJd3HQkgeQRpCo1dAanrzMzIAnDByD1Gr07zwzDXdpn9PptwDTLwyFopqhHC2p6 d9JJOXl5BtH40o5YoAcsnVJEAQ0iuErOFmmqIF+Oj5EN1T/CHuv8iGsv0lvNwk2eEiqt2LEthWj tuv9rs23pf05VSRSoLUEuyk1Qem4xtKw+sxBjItwbcgq5Ny7kwl0VZDfHHLBcIoS8pDW7ymyQnS JcdgCovQXpBgVJAMZKCruiGnthenH6lBN5TrE3X4ndYqjxVc2cC+x+T0YvRLPRagldqHFJOawYS 61w7KRNRTrxCfu3icbfEmm X-Received: by 2002:a05:622a:5a0c:b0:530:9c77:8dfd with SMTP id d75a77b69052e-5330b5d2518mr58287781cf.14.1790356668078; Fri, 25 Sep 2026 10:17:48 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6ab2bc22.412bd.10bb456f@gitrepo.freebsd.org> <2df20868-4983-4169-a94e-da6adf2fb3ea@FreeBSD.org> In-Reply-To: From: Kevin Bowling Date: Fri, 25 Sep 2026 10:17:36 -0700 X-Gm-Features: AclHuK9QxoDWHlJO7sk0sZcriL-h9F6d3z-z5Wtkgv6KxMjh_ghYwIyHkKYkbYk Message-ID: Subject: Re: git: 32137c41065c - main - sound: Retire the version constants To: Christos Margiolis Cc: Jason Harmening , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, John Baldwin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: - X-Spamd-Result: default: False [-1.30 / 15.00]; ARC_ALLOW(-1.00)[google.com:s=arc-20260327:i=1]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; R_DKIM_PERMFAIL(0.00)[kev009.com:s=google]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; ALIAS_RESOLVED(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; DMARC_NA(0.00)[kev009.com]; DKIM_TRACE(0.00)[kev009.com:~] X-Rspamd-Queue-Id: 4hry7x2sBTz4bqB On Fri, Sep 25, 2026 at 9:59=E2=80=AFAM Christos Margiolis wrote: > > On Fri Sep 25, 2026 at 6:27 PM CEST, Jason Harmening wrote: > > On Fri, Sep 25, 2026 at 5:34=E2=80=AFAM Christos Margiolis > > wrote: > > > >> On Wed Sep 23, 2026 at 10:19 PM CEST, Jason Harmening wrote: > >> > On Wed, Sep 23, 2026 at 2:19=E2=80=AFPM John Baldwin wrote: > >> > > >> >> On 9/22/26 14:54, Jason Harmening wrote: > >> >> > Do you plan to also bump __FreeBSD_version__ for these changes? > >> >> > This will break any out-of-tree sound driver that uses these macr= os, > >> >> > particularly if you MFC it. > >> >> > Such drivers will then need some way to determine whether to hard= code > >> '1' > >> >> > or use the previous macro/hardcode '5' to avoid a failed dependen= cy > >> >> check. > >> >> > I still maintain such a thing, however few users there may be, an= d it > >> >> seems > >> >> > unsafe to assume there aren't others. > >> >> > > >> >> > This seems like a completely unnecessary change TBH. > >> >> > >> >> Can you use #ifdef to test if they are defined in an out-of-tree dr= iver? > >> >> In > >> >> your case, perhaps as something like: > >> >> > >> >> #ifndef SOUND_MINVER > >> >> #define SOUND_MINVER 1 > >> >> #endif > >> >> > >> >> > >> > > >> > Sure, I mentioned that very possibility in my post on > >> > https://reviews.freebsd.org/D59873. > >> > That's still a hack, and I'm still not sure why it was necessary to = kill > >> > these defines in the first place. > >> > >> Does your driver actually depend on sound(4)'s versioning, and if yes, > >> how? > >> > > > > Uh, yes...just like all the in-tree drivers before you made this change= , it > > depended on those version constants to allow the module to load correct= ly. > > > > Of course I get what you're really asking here, and no...just like the > > in-tree drivers, it does not make any functional distinction between > > different sound(4) versions. > > So the versioning was functionally useless in your driver too. > >> > >> The reason for deleting those, although technically unnecessary, was > >> because these values have been forgotten for years and do not actually > >> mean anything useful, so I think it's better to just clean this up and > >> fix the few (if any) use-cases, than keep this rotting further. > > > > > > I completely understand that these no longer meant anything useful in t= erms > > of KPI/KBI compatibility, but I don't really see why getting rid of the= m > > was worth the churn, even just the in-tree churn (disregarding risks fo= r > > out-of-tree drivers). What ongoing maintenance burden were these defin= es > > likely to cause? > > There wasn't any significant maintenance burden, but that church wasn't > anything complicated to implement either, and I don't see a point of > keeping something that is functionally dead. > > > As a separate question, would it instead make sense to make these versi= ons > > start meaning something again? > > For example, you recently made a change to require mixer_init() to be > > called in a certain order relative to other initialization. That chang= e > > seems perfectly reasonable from a technical standpoint, but would it al= so > > make sense to bump the version constants to avoid a panic from loading = a > > stale audio driver kmod that didn't use the correct init sequence? > > This would be a good use case yes. I will think a bit more about it. The odd choice to me is arbitrarily resetting the "epoch"; I see justification for removing the macros that force everything to the same value. I can't think of precedent for resetting it back to 1 off hand unless something were simultaneously renamed or moved, ensuring there is never possible overlap. > Christos >