From nobody Fri Sep 25 17:00:48 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hrxmJ5ss1z6tfTl for ; Fri, 25 Sep 2026 17:00:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hrxmJ4N4Vz4VVx for ; Fri, 25 Sep 2026 17:00:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790355648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wZBhBHgxSUruW2WKTiXer1RX/ooInAhRTV6KMtNPFhY=; b=FooBb3qshJqEAlRJB2TIh8Hz6+hnHyDodHUwnuGP2cxsotf5X92PQ890eQTD4FJOGSJ+uH CPtMqD+wrAaakDDJcWS35F18mF5h35q8XogrllDAcCIWwqxOdz+95tb/lTq9W29ji6YUhd v7nbpTIPNfUOaeHsVwjjBNlixXzu7lg327ONsFt0Rr7ssh49jg/A9OWvBthcnovrOdCpkK 2LF7Qhou5eV0btSDupquaEGZS/88Lz+YSSH70roViv/ilEOp4Fm+RrvZlVGZ8wZiqM820s 2ttEhC+DvBAiRULL2WK20XLV7yC0Ig77onhtvQGRTYAQlIWBGVsLDdO0UU+5+g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790355648; b=NPWvlqYyme4zsk9CH503Pb93hipA0KC+DMpe1jp1rEwWWF19kdFLRY14BZZP7h8hIbBqu/ Ya+a6xC/+Viy5n3jqALWhLhGH04TI5p3qKrmf+Im+ndAgInKwp3kFDRRPmco+PRAWoa5vn Kxcj3wgrjBHsDSIGtJcl1QJj4c3VZ1MLjvbAw06c1hkRqDajhIhP++uJqKPAvWrvcA9baZ XdqS6cPYKyU/tmpRDQjsoLShAQLGdjHDRUe8sOQ+A48uMXpjNcY6dp26e41cqyFMn3+vGE 4yGtP4tgw9S85bOu3NP0+ZjstipVyFPIf3k9A5jp8eU7649bl3mCvHpAZvCntA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790355648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wZBhBHgxSUruW2WKTiXer1RX/ooInAhRTV6KMtNPFhY=; b=epfpya5s840anlxynlQAeJw3qJx/GBvZFBmpCCJguwLKbPy0XyfKaA4NNfgyb5LU453tBM mh4tMercoFIf50W4WwyhnuyIMIdp8X9udrwKIQOfQDWl2QxdV8KXar2GPWdrmIKDtaMSiB +W1kab00BWURNj36XLZ/yGRe6tOqiiQRfqiUAGIEubN4+GregZVLRk2wM0SyP2vYRNiJhg 0iJeiQR8UaWICSLZlxTBWJprByTwm10DjfHwGbhZ9CBHpv1U/mFX3C/MthsDgAUS7vRWlV RYXELcME8R4roH6K+5JNVHTOReQn7LD5nkStgNcIKzoB7RpS0lmrr/X/tT109g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hrxmJ3MqbzHZX for ; Fri, 25 Sep 2026 17:00:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e497 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 25 Sep 2026 17:00:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Andrew Griffiths From: Mark Johnston Subject: git: cb035c19c3e7 - main - ipfilter: fix inverted range check on the lookup iterator unit List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cb035c19c3e76d547eb7d4bca1f1106b117c27a0 Auto-Submitted: auto-generated Date: Fri, 25 Sep 2026 17:00:48 +0000 Message-Id: <6ab6a8c0.1e497.2e652710@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=cb035c19c3e76d547eb7d4bca1f1106b117c27a0 commit cb035c19c3e76d547eb7d4bca1f1106b117c27a0 Author: Andrew Griffiths AuthorDate: 2026-09-06 20:44:35 +0000 Commit: Mark Johnston CommitDate: 2026-09-25 16:50:42 +0000 ipfilter: fix inverted range check on the lookup iterator unit ipf_lookup_iterate() validates iter.ili_unit with if (iter.ili_unit < IPL_LOGALL && iter.ili_unit > IPL_LOGMAX) or alternatively, if (iter.ili_unit < -1 && iter.ili_unit > 7) ipf_lookup_add(), ipf_lookup_delete(), ipf_lookup_stats() ipf_lookup_flush() validate with a || Submitted by calif.io for the OpenAI Patch The Planet program Signed-off-by: Andrew Griffiths Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D59726 --- sys/netpfil/ipfilter/netinet/ip_lookup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netpfil/ipfilter/netinet/ip_lookup.c b/sys/netpfil/ipfilter/netinet/ip_lookup.c index a52dbef00166..b0fb2b09c325 100644 --- a/sys/netpfil/ipfilter/netinet/ip_lookup.c +++ b/sys/netpfil/ipfilter/netinet/ip_lookup.c @@ -663,7 +663,7 @@ ipf_lookup_iterate(ipf_main_softc_t *softc, void *data, int uid, void *ctx) if (err != 0) return (err); - if (iter.ili_unit < IPL_LOGALL && iter.ili_unit > IPL_LOGMAX) { + if (iter.ili_unit < IPL_LOGALL || iter.ili_unit > IPL_LOGMAX) { IPFERROR(50038); return (EINVAL); }