From nobody Fri Sep 25 15:39:53 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hrvyx1wLdz6tYcY for ; Fri, 25 Sep 2026 15:39:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hrvyx1FBQz4FVJ for ; Fri, 25 Sep 2026 15:39:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790350793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fOPyxB0AsJ19WG9uXnBznzAjWYtFJ0bH51ebRWEf6U4=; b=dGBuYA0Wpi7BXkQK+oBWNVxj32TTasuwTS8XCFj07qsN1V+MAtDk7o9lsMBQRfWC1Y+B3J UwHvHdT8GJ1kktDYJEuuuAOGNmJ6uD87yyebXkdCtJN7XNFMEOKNNL0guDZYz9xb4ihhaM 9W9xzxNB95Owo9CzoHsxZKGeXvswJyEFGOKKWLxB80VSj1rgdaZXmDYUR8kq7SdkGJpRdw vsbHnIwxlqEo3Y++/CUC6lQbyqTNfrJSV7PtIG9WKHfPZ/a87Dd8eKZqesHphbxsCdz9DM sZ8GOCOT9eEVJygOfqF27CKaa0GjMttZiU2CLjctv0/TEzA5bHVRQWK0YQwSFA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790350793; b=jcEoXOfMaI6dNkkk4F9EM+IFQbUG/W94N7FC6raGBReCgFfs5rbbBNmaPcxkoBuVeG05wN DnV+P6M5YCmx9XtcLld+fGXOcNfNqgboB1MnsVtxo7aE+z8oOCRXqATyphuXhaJtsqpDsU cAN+lLloiue2wtbc9HBypCjt2mxu+4HjguOHinXhfg3qRduIcKTu4F4gqUsibRGzhP1fFP +z/NqJs3jq+Km50uqA90BBbRG4Yaa0mtClAXSELuMAjoetv799mKAYlvOOf0vLAxp5D6CZ 6oyOMi7SkHfQj7ECVYHzzEV2tIsKhJ4uBLIMS5HFRNjTzqP51HIpoHb9cCTaMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790350793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fOPyxB0AsJ19WG9uXnBznzAjWYtFJ0bH51ebRWEf6U4=; b=gz1dGxuuF07yyNcxrk5igepzhTBiAvk5nkBp3N0ytTi6Y5PLXjRggCDboIgD0T+a6KtyxG 0HYbejgtJ3OADCaesa1G7PCoBl8fUFVO3EkcQfaS8e8pvQ7S4kQeQpdxx0EJ7IB+XacMEh 9mvsJdb39ezrYvu9EJU1gY/5kOOFCmOAEmMFnNZqXMU59LzYXi6rxjBNJmDPAFWQrgDRc+ AB4O7WPpg0L8fxlxQEemoOfUyPxXQD+4Cup4L5UjhNxKdpLYwEoe5EujpCC1cOgcY/89lB HlgnGCujmxW0zUHYVnL5WD9GNWDROwILQ5ExgTla6VDuDo+ThRwwzrSrW9C2Cw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hrvyx0HRgzGMj for ; Fri, 25 Sep 2026 15:39:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 423e1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 25 Sep 2026 15:39:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 4672ad1f1609 - main - SYSCTL(9): Retire SYSCTL_NODE_CHILDREN() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4672ad1f16092c146261b4de485ec5eb5e8d127b Auto-Submitted: auto-generated Date: Fri, 25 Sep 2026 15:39:53 +0000 Message-Id: <6ab695c9.423e1.5b4beb6d@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=4672ad1f16092c146261b4de485ec5eb5e8d127b commit 4672ad1f16092c146261b4de485ec5eb5e8d127b Author: Olivier Certner AuthorDate: 2026-09-25 08:29:19 +0000 Commit: Olivier Certner CommitDate: 2026-09-25 15:21:44 +0000 SYSCTL(9): Retire SYSCTL_NODE_CHILDREN() It does not provide value over the pre-existing SYSCTL_STATIC_CHILDREN() macro, which is widely used in the tree, whereas SYSCTL_NODE_CHILDREN() is not. Reviewed by: markj MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D60009 --- sys/dev/usb/net/usb_ethernet.c | 2 +- sys/net80211/ieee80211_freebsd.c | 2 +- sys/sys/sysctl.h | 3 --- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/sys/dev/usb/net/usb_ethernet.c b/sys/dev/usb/net/usb_ethernet.c index 692ea64128b9..16235aa4e278 100644 --- a/sys/dev/usb/net/usb_ethernet.c +++ b/sys/dev/usb/net/usb_ethernet.c @@ -262,7 +262,7 @@ ue_attach_post_task(struct usb_proc_msg *_task) snprintf(num, sizeof(num), "%u", ue->ue_unit); ue->ue_sysctl_oid = SYSCTL_ADD_NODE(&ue->ue_sysctl_ctx, - &SYSCTL_NODE_CHILDREN(_net, ue), + SYSCTL_STATIC_CHILDREN(_net_ue), OID_AUTO, num, CTLFLAG_RD | CTLFLAG_MPSAFE, NULL, ""); SYSCTL_ADD_PROC(&ue->ue_sysctl_ctx, SYSCTL_CHILDREN(ue->ue_sysctl_oid), OID_AUTO, "%parent", diff --git a/sys/net80211/ieee80211_freebsd.c b/sys/net80211/ieee80211_freebsd.c index 095be79e7bfe..741ec4886d38 100644 --- a/sys/net80211/ieee80211_freebsd.c +++ b/sys/net80211/ieee80211_freebsd.c @@ -283,7 +283,7 @@ ieee80211_sysctl_vattach(struct ieee80211vap *vap) } sysctl_ctx_init(ctx); snprintf(num, sizeof(num), "%u", ifp->if_dunit); - oid = SYSCTL_ADD_NODE(ctx, &SYSCTL_NODE_CHILDREN(_net, wlan), + oid = SYSCTL_ADD_NODE(ctx, SYSCTL_STATIC_CHILDREN(_net_wlan), OID_AUTO, num, CTLFLAG_RD | CTLFLAG_MPSAFE, NULL, ""); SYSCTL_ADD_PROC(ctx, SYSCTL_CHILDREN(oid), OID_AUTO, "%parent", CTLTYPE_STRING | CTLFLAG_RD | CTLFLAG_NEEDGIANT, diff --git a/sys/sys/sysctl.h b/sys/sys/sysctl.h index 273dd2a71d30..3ff813aa8337 100644 --- a/sys/sys/sysctl.h +++ b/sys/sys/sysctl.h @@ -273,9 +273,6 @@ struct sysctl_ctx_entry { TAILQ_HEAD(sysctl_ctx_list, sysctl_ctx_entry); -#define SYSCTL_NODE_CHILDREN(parent, name) \ - sysctl__##parent##_##name.oid_children - #ifndef NO_SYSCTL_DESCR #define __DESCR(d) d #else