From nobody Thu Sep 24 16:04:36 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hrJZ15RXwz6ss7M for ; Thu, 24 Sep 2026 16:04:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hrJZ14q6Fz4Y9V for ; Thu, 24 Sep 2026 16:04:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790265881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oFFaVliJYpry6tskvQRunWQ9SRVXmUJdr9MLWUbnV8c=; b=tXxJCrYKl0pSuGjgRdk8ySsUjVGL4uZP9E2Y30V8o5c0VyFCXUdErCsw4WyQ2Qda+5iVQM eG06LxcPLosHsopU3oYOnGEbuMvtz2rJxbYaGvpKIl2cy0tIrCRtDXOlGjZk/leF2PV48m ncTFEitqR/V7tuc0bk503YH7fVfbIgeoQYOThE6nbL8aLsO3yJf5DEBvVozH/Mmcomrqbp 4DEPL/zyCaGuJvZgZg6LMkLUAjIcjWvAk5tdWj47IOo9AwNGm9LM3arq/9kKa+dlCMdBWu Mxv+GKk7IKgHGxXEQUf3niIpnw+7oNYm2Ic2kN5JriWh8TfzAdco/b2rUjc11g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790265881; b=myA04Xex/TrFPFIseAhSJz82ZwfuCkDCN5iJb+EgNZDKXzlcYk34+jvGxjZcvlotJceMX7 siVDNNimfujfh+QgoSCqY3mspZrq4pkwipiNSm73qas8WjXSDCuF8Evo3hmDrPAu5B1r90 vl9xqchpTzrUmOGlh+bV/sOp4vmr/CZeqUghsIjCI9P/bOlJjRjMvW8fRQSfHeIjzqbChD SVu2O9EVNvtFX4wWPtgB0r4+oObEP5iII4Dc9A3V6Mphic5UUNzubEYZ3cLtf+CeaRzUnb PPhIpAO7zowvMER3IqASr/kTrZzM/q1LFJrZ9ye+ePOFdzTD9wGDvqIq/y2tXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790265881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oFFaVliJYpry6tskvQRunWQ9SRVXmUJdr9MLWUbnV8c=; b=rq0auWNP+6lTkA5zZXAdcJ0VxwpehhPWlQHRituhB9mi349N7eElclHloa34EyTLUss6ps D94C8eOG4QhmqRfFpJC1ipevPE4qEU0+8NyZQ0Viukj/XSY8cXnguUa6VDNYH9VeZdXxSv nigeA+3UwCJL2s5RFY44lUIwvJdHwma+vPKtCQYLoL1quiQCPnbqNTzzoX1lyqY9NTHLVv CHROB8lG7wumEtU4IAlPDsz1DIumLBaxOIrlpVG4YERNSK2RiyfgunUkYM2wses/dKN88k VvKuHVm5DdawQ+Civhbl3ESnaenNRckFCDQjglKeY+OK8NNPWE9ivFuWHRnBMQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hrJZ13sfGzVrC for ; Thu, 24 Sep 2026 16:04:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 430d5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 24 Sep 2026 16:04:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Nick Banks From: Olivier Cochard Subject: git: c14281f6bb46 - main - tests/sys/kern: skip unix_connectat fdescfs cases when fdescfs is missing List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olivier X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c14281f6bb462ca03383d92a0d88228e9426268e Auto-Submitted: auto-generated Date: Thu, 24 Sep 2026 16:04:36 +0000 Message-Id: <6ab54a14.430d5.61a0fb45@gitrepo.freebsd.org> The branch main has been updated by olivier: URL: https://cgit.FreeBSD.org/src/commit/?id=c14281f6bb462ca03383d92a0d88228e9426268e commit c14281f6bb462ca03383d92a0d88228e9426268e Author: Nick Banks AuthorDate: 2026-09-24 15:49:09 +0000 Commit: Olivier Cochard CommitDate: 2026-09-24 16:00:44 +0000 tests/sys/kern: skip unix_connectat fdescfs cases when fdescfs is missing unix_connectat's fdescfs cases call mount_fdescfs(), which skipped on ENODEV. nmount(2) never returns ENODEV: vfs_donmount() remaps the ENODEV from a failed fdescfs module load to EINVAL with errmsg "Invalid fstype", so the skip never fired and the cases failed on kernels without fdescfs. Approved by: ngie, asomers Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D59227 --- tests/sys/kern/unix_connectat.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/sys/kern/unix_connectat.c b/tests/sys/kern/unix_connectat.c index 04885ee464ee..12832b30c76b 100644 --- a/tests/sys/kern/unix_connectat.c +++ b/tests/sys/kern/unix_connectat.c @@ -128,7 +128,6 @@ pathconnect(int fd, int s, const char *path) * rather than relying on the host's /dev/fd keeps the fdescfs cases * self-contained: they exercise real fdescfs lookups regardless of how the * host is set up, and the mode-specific behaviour below is then well defined. - * Skips if the kernel has no fdescfs. */ static void mount_fdescfs(const char * const *opts) @@ -154,8 +153,6 @@ mount_fdescfs(const char * const *opts) errmsg[0] = '\0'; error = nmount(iov, iovlen, 0); - if (error != 0 && errno == ENODEV) - atf_tc_skip("no fdescfs support in the kernel"); ATF_REQUIRE_MSG(error == 0, "mount fdescfs on %s: %s", FDDIR, errmsg[0] != '\0' ? errmsg : strerror(errno)); @@ -183,6 +180,7 @@ fdpath(char *buf, size_t len, int fd) ATF_TC_HEAD(name, tc) \ { \ atf_tc_set_md_var(tc, "require.user", "root"); \ + atf_tc_set_md_var(tc, "require.kmods", "fdescfs"); \ } \ ATF_TC_CLEANUP(name, tc) \ { \