From nobody Tue Sep 22 06:30:41 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hpqwk5fdWz6tBVv for ; Tue, 22 Sep 2026 06:30:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hpqwk3Nxcz4Gkd for ; Tue, 22 Sep 2026 06:30:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790058646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3MiLWejb2boTIA1JUaCn7Fv3YyPwoX6EfuTEVwBPFvc=; b=BhupdzC9SFz7znceP3EUPImscWSzNd8yhPA7Ph1Epl3xrIUDmIy/eDxQQ6OVCurREhxIys VI0OZ+cmefu4NgGG06VREk+sCQNYRrzWTAlcyAXzdTeAgoP24sIb2lI2WppxLQVYeJyODd wmQkKGuCufX2LbVyzUaYeTEcyGB3b566KuBVVqpwcx3oyX4A0eQIglEbL5tXRz0bEgVMLX 2LX6Dx3h1o0gh9vbNeYMOB7pPt+aXT7+Hgp6WBBKNNL3Gl5iga7p6p382XWxSoqsHPawbo eLldjkUcbEQoaPwsoduYlkexudxzZlNhGKSMXFQBhvVlqrzTYZIlfpxTFJaxdA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790058646; b=QefmXzAIglmOG0h1f6TzZBnOSg4+spWsGAZ2OK/q2TlQ9Qihtyk57VH2LqbUPPdP5XmFoQ TIMIKwwRw+000TvqoIe2rM1oL4UwYcebd7NmR6yrIbiWe/TOZT6qqRDcfbYRmKU5f050r7 lyIqixgx4pYQg1adTpmpER8Mp8Q1IZDFzyThBAJE0EGYHTO7V1bAREehO9uIF81opZNdQs dEFtLMP0HaBvzAedx0PsGV8t9mznURzWcIfs8QBMhILLRtiS8Q3ojZi8V6SLr5rtILLgTw ZPn26GSd2/EfKTXZwaSToEhVlOrgoQt9RgaB9tq1aWTqsjI6vmIq78SqnalX5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790058646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3MiLWejb2boTIA1JUaCn7Fv3YyPwoX6EfuTEVwBPFvc=; b=dADQWlPAG9ytPW+/ri7M4zg+fGM/LKu3xvIvKwuu/4kYb+KBBjvREnfghzxTi0xh5sQ9SA VaTBd12OkHz6weL4j+iSDuh03wxnFaN15F4AkgZRWXumJwi/84fICnS3n/0DHVV0ImwC81 KZyTcGcaYUcoXUbJp+9txM8i+EPIEbHVivEUni9YULWYEPybrQO2LMq7tMlVG4sgyTIZJU bNfKHxwWkfVwMcoNXI+r6gU/LActwMnEgKXYpLmKoslw8IRLANEINuKpN85thLWv2kXhiS NZnf4y2sda9uCuJMDRNfQvGAd8xuhRXJMmVUQ0Lj+cLk6WbIY86PAcD64T7eLQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hpqwk1y0nzvQP for ; Tue, 22 Sep 2026 06:30:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3fd77 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 22 Sep 2026 06:30:41 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Enji Cooper Subject: git: 6f3445006aa0 - main - [tests] lib/libc/gen:assert_test: skip tests when NDEBUG set List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6f3445006aa05550f14af65b04276c3d25169941 Auto-Submitted: auto-generated Date: Tue, 22 Sep 2026 06:30:41 +0000 Message-Id: <6ab22091.3fd77.2b258f0@gitrepo.freebsd.org> The branch main has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=6f3445006aa05550f14af65b04276c3d25169941 commit 6f3445006aa05550f14af65b04276c3d25169941 Author: Enji Cooper AuthorDate: 2026-09-22 06:22:57 +0000 Commit: Enji Cooper CommitDate: 2026-09-22 06:30:30 +0000 [tests] lib/libc/gen:assert_test: skip tests when NDEBUG set In the event that NDEBUG is specified in CFLAGS--which is most likely triggered via `MK_ASSERT_DEBUG` == "no" -- all assert(3) statements are optimized out by design. This breaks the assert(3) tests as they specifically rely on assert(3) actually raising a `SIGABRT` instead of quietly succeeding. Skip both tests if `NDEBUG` is set. There's no sense running the `assert(true)` test if the result could instead be a false positive. MFC after: 2 weeks --- contrib/netbsd-tests/lib/libc/gen/t_assert.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/contrib/netbsd-tests/lib/libc/gen/t_assert.c b/contrib/netbsd-tests/lib/libc/gen/t_assert.c index ce73015142d6..b4023223b446 100644 --- a/contrib/netbsd-tests/lib/libc/gen/t_assert.c +++ b/contrib/netbsd-tests/lib/libc/gen/t_assert.c @@ -43,6 +43,18 @@ __RCSID("$NetBSD: t_assert.c,v 1.3 2017/01/10 15:17:57 christos Exp $"); #include #include +#ifdef __FreeBSD__ +/* TODO: upstream this. */ +static void +skip_if_ndebug_set(void) +{ + +#ifdef NDEBUG + atf_tc_skip("Testcase requires code to be compiled without -DNDEBUG."); +#endif +} +#endif + static void disable_corefile(void) { @@ -74,6 +86,10 @@ ATF_TC_BODY(assert_false, tc) pid_t pid; int sta; +#ifdef __FreeBSD__ + skip_if_ndebug_set(); +#endif + pid = fork(); ATF_REQUIRE(pid >= 0); @@ -112,6 +128,10 @@ ATF_TC_BODY(assert_true, tc) pid_t pid; int sta; +#ifdef __FreeBSD__ + skip_if_ndebug_set(); +#endif + pid = fork(); ATF_REQUIRE(pid >= 0);