From nobody Tue Sep 22 02:37:12 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hpklD2NjGz6ss8w for ; Tue, 22 Sep 2026 02:37:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hpklD1bLzz4c5G for ; Tue, 22 Sep 2026 02:37:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790044632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SW0yPFckjDpW632OSgd3dFT1Ol31HuX3V8/QNY9HGZo=; b=qXJRPgUYTEnjUfhCH7qnLVVM6V1Zx7/TWeZcsjFIQIYJR8eNVSDqJZYH9n28ePPJvQ/NbX FcrD346FIdOwOLa1LLfaDIqlescGGs+fJ5ANiRR9pY9OvdJ48KSebWmVCz/oCLuOONqTIn cvEPzdeycQ7dFsTqrZ/QVF5w4SvnI7O67n1KeOKja9SjSU+J+EwS/HL3md4ilOeYHBhlnw ud0LunvywmlhlML/YHl6nGE35qRjFOTdh5djgSRQmMWFu2mDTTAy+704zxQaGN86IyKtU8 a6qt7gSBDg+j8A53l/XoQSxMF6SUFxnzu0chF1ADReFju4Ns7mndkGsGxVnD0g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790044632; b=Il/6bLYjT+4GbBM11QDLQ52WkpMqqF5JTt9E9IRvDX5UJ6w/9cGkXNWl4g3PyLBJd02PY8 zm0FkwrPyrHkd4dorQVW4B3eMX4J3ek7/A/jEm6K7lWDc71Kmd2faYNS3iYVPxR05rv/GV Pg4dscAKst9G8Anio+DInvxMEO0uWqvC3/VIsCPmvbt52eMQXW2KFpaVi5YMA7seBFQTRq tQpqkjb1XN5ACXnQ/no9TK+BZothyt53tD8f48fnryRQ7G4528YNW52IA19wSaOzJWTnuN X688PpnjzmK5jBxUC9BE7OouAaKR4K0TDQCtoJ9JknrIZjEd/jiJeALSJFiatA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790044632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SW0yPFckjDpW632OSgd3dFT1Ol31HuX3V8/QNY9HGZo=; b=hKx/zhIgxTtAiXz5A41wrnoei/E7zZz4HeaQLDZ5CN7t1Fpxb5dsDwim5yvxlN+x2V1DgA 99fG0F2LFQ3RRClIouOZ3AygqPgNI6m03+UXrA5qBNRsE5zjx1ce0PbqxapABLkNWZEhwE x324hhzfS8+RJvnStAXEELDLgNC9v6xg8JCTcODSuS9k1+t1DEETZcB20CP+9bJ97l3QtJ P71ToMwayXE3ylEuHa8TmUY3+FxyNwT5Imx66x9UR8XBpBBhkVB9+DE27u5XQyoexGUsT2 2yq+62yQiIvh5vKsnSWsQGh/zp4fxfLEvvQnDAyGgTTjWqnjPCH3rQhy8XGmlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hpklD0dZmzndr for ; Tue, 22 Sep 2026 02:37:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 215f3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 22 Sep 2026 02:37:12 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Maxim Konovalov Subject: git: 04fcf3096126 - main - dummynet: do not overflow the points[ED_MAX_SAMPLES_NO] array List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: maxim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 04fcf30961266cd77139b40774cb0d6ef6eb2be5 Auto-Submitted: auto-generated Date: Tue, 22 Sep 2026 02:37:12 +0000 Message-Id: <6ab1e9d8.215f3.12830f63@gitrepo.freebsd.org> The branch main has been updated by maxim: URL: https://cgit.FreeBSD.org/src/commit/?id=04fcf30961266cd77139b40774cb0d6ef6eb2be5 commit 04fcf30961266cd77139b40774cb0d6ef6eb2be5 Author: Maxim Konovalov AuthorDate: 2026-09-21 23:32:09 +0000 Commit: Maxim Konovalov CommitDate: 2026-09-22 02:36:46 +0000 dummynet: do not overflow the points[ED_MAX_SAMPLES_NO] array Otherwise, the following would segfault dnctl pipe 1 config bw 1Mbit/s profile 1025points.txt Found with: Claude Code Sonnet 5 MFC after: 2 weeks --- sbin/ipfw/dummynet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sbin/ipfw/dummynet.c b/sbin/ipfw/dummynet.c index a0cefcffd183..3cf9a1854365 100644 --- a/sbin/ipfw/dummynet.c +++ b/sbin/ipfw/dummynet.c @@ -959,6 +959,9 @@ load_extra_delays(const char *filename, struct dn_profile *p, } else if (do_points) { if (!is_valid_number(name) || !is_valid_number(arg)) errx(ED_EFMT("invalid point found")); + if (points_no >= ED_MAX_SAMPLES_NO) + errx(ED_EFMT("too many samples, maximum is %d"), + ED_MAX_SAMPLES_NO); if (delay_first) { points[points_no].delay = atof(name); points[points_no].prob = atof(arg);