From nobody Mon Sep 21 16:41:26 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hpTWr0Pq0z6srmM for ; Mon, 21 Sep 2026 16:41:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hpTWq0Pl0z4pmw for ; Mon, 21 Sep 2026 16:41:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790008887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=71u3m0iVkZBBVjEX+7Nqawi4dp+r+wA/OIzQw9VCYwE=; b=xkDnWZTt1yxxz8QfRCrPz5/CmlD/DQBQ7UjHvYqHNImQEKqmp1whiZLq5YlpxJAVhgdwUL 5/8IQCKGpE1NOiKuMyKeVP/3nd2DyS/s2vYNlRDLKEoCx2H1v0DTHDZAiTbDd3BIdB2h2/ up54GlzZCL6IxPoYE3P4ltTRcJv+bpzEsuEk/k2pzJqr1zqba6bw8/2IrwTop+3ELRMVkI 4uBvDUuXB1LShTLBO9jh3U9CVs4EsYRdu+WSbThdDviLxzGKW0Pqvow88Zqq/8yDbxewtr 7Q10NaUH9SFxawhsre6n2n98DZaFwGTy+OqFXalrP275XsrY3N5Z2QXxcBkpHQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790008887; b=UFRu6WX3lrmLVrR9Q3382j2k/uNxhWP+r9xIKvOzJZ02RCrjL3lDydoXLYPZHzqNsyw6GV dKeQbJ1loYrryhV6/9CruILeOAzE7BXmDJI0nU4sg/M1z9uvp9N44NBXqqTnHb+Su/f3oF AB9nMM5smdFUS5l90pEleXZidJ2DvhLCxlVZz6cEC6KcHkOAvkhsxj3XSP/8jKJ5i6y/+f j8606ywRpRKgrtt5mq7LGhjOlszZkgfZ69KEJ5uioULiZQMGKEyCa5rmgHiJRgTgniKCAJ nF+lqKOigu4EJcXWbwdXiayyyLNHRFf8bVFvZVJ427UV3UtfOHcCwRwYOsQMUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790008887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=71u3m0iVkZBBVjEX+7Nqawi4dp+r+wA/OIzQw9VCYwE=; b=KZfE/bbsrlvi0g+lI10pwrOEYzMqjCJliwci2rR3Eql8ZO439l28qB3MzV7q68xyukUdZK 8cRUH97qEI7SjWVV7DPBSHojnf6KqcF8ZPXaUJf3e0DNvEV43hrEdMUBJsIFVBziRuDd9i jEEM0Cbns4StK82xGLxqkSNyU/xNxuHrHE8wPs1P2zv5cPwOLA5OzM0ZNXyZSgOjNUNAKO gHJuhoxnzHB7CIHLlO8aXdv14QkKv6PygryVTT0laJKmKn8P6W0CqiCtjPJk26XqIp9A14 4RywgDF4yzkmOH4Z7gbVC2lHbbjcQX5Pn8qvYe6ZppW/s+SFRV8iMWxmKdRiNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hpTWp5LZCzSJm for ; Mon, 21 Sep 2026 16:41:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39ea0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 21 Sep 2026 16:41:26 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Hayzam Sherif From: Mark Johnston Subject: git: fc44154841fc - main - vmm: Re-arm the PIT callout for square wave mode List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fc44154841fc2ebb1530a10cad719edb58559a88 Auto-Submitted: auto-generated Date: Mon, 21 Sep 2026 16:41:26 +0000 Message-Id: <6ab15e36.39ea0.67ca7846@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=fc44154841fc2ebb1530a10cad719edb58559a88 commit fc44154841fc2ebb1530a10cad719edb58559a88 Author: Hayzam Sherif AuthorDate: 2026-09-21 16:34:37 +0000 Commit: Mark Johnston CommitDate: 2026-09-21 16:36:11 +0000 vmm: Re-arm the PIT callout for square wave mode The 8254's square wave mode (mode 3) is periodic, with the same interrupt rate as the rate generator mode (mode 2), but vatpit_callout_handler() only re-arms the channel 0 callout for TIMER_RATEGEN. A guest that programs mode 3 therefore receives a single IRQ0 and no further timer interrupts. Re-arm the callout for TIMER_SQWAVE as well, matching illumos change 13301. Reviewed by: markj Obtained from: illumos 93d78aba5b32996fc2ae893a6237a0d3972f86b2 MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59816 --- sys/amd64/vmm/io/vatpit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/amd64/vmm/io/vatpit.c b/sys/amd64/vmm/io/vatpit.c index 595c2e070c7a..bdc93d2b8e27 100644 --- a/sys/amd64/vmm/io/vatpit.c +++ b/sys/amd64/vmm/io/vatpit.c @@ -165,7 +165,7 @@ vatpit_callout_handler(void *a) callout_deactivate(callout); - if (c->mode == TIMER_RATEGEN) { + if (c->mode == TIMER_RATEGEN || c->mode == TIMER_SQWAVE) { pit_timer_start_cntr0(vatpit); }