From nobody Sun Sep 20 18:19:22 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hnvlg31FCz6sGyj for ; Sun, 20 Sep 2026 18:19:43 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pj2-x1b.google.com (mail-pj2-x1b.google.com [IPv6:2607:f8b0:4864:39::1b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hnvlf2zv8z4YVD for ; Sun, 20 Sep 2026 18:19:42 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=YanjmnN8; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:39::1b as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj2-x1b.google.com with SMTP id d9443c01a7336-2d747f066d8so8084645ad.1 for ; Sun, 20 Sep 2026 11:19:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789928376; x=1790533176; darn=freebsd.org; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1nXD11U1g9YU0mIrRZ+ExJ4ltf7kVfQhSBSlqdqg8lE=; b=YanjmnN88IIdCkRxtJNaQRZVT24HTu8FHdpVj1XmI5q347QlPZGT0GUQECTdgovfbE k4h3zuC1KPgW9oT0BRZ+zmaVG+TEozg1eTiqambZnQATT1u41Irj5eGY6Ck/9UeLble/ Mn1ZqRZxZ7jkfd725NaNG67soiefzB2HEJHdKqnNU0pGhfqfzjYkKQlgzi4vge3MhhoI nnvvSxtR1BxjaUVgxLNtUnXBIg3821dVMzi+X82a9Q5Ea7zDEVtazXCbPKaYBb2ltiqM Il41iM59GEXKH2iEV7i3psqlWgm03WelnmbK1qihKU4iTvAGC3TzM+pO33uLS76CBZHZ dAwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789928376; x=1790533176; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1nXD11U1g9YU0mIrRZ+ExJ4ltf7kVfQhSBSlqdqg8lE=; b=o/Z+AoKN9x9sAoTFPPIBbrqvN7RVabZAeVoynL4ypDyqgD5SQDqwNY0VCNgh57DfZs uxdCRvflLvDwBNJtEQV5VRfKIKKw+JLaLepUpvaapGMx4MpsZt+Gb8QS40pSkV45uXLg 3x2MA/I6kPNDdR3MzKwF2Cj+y60A4x9L6hv+7JxraFib47IENXVOMpH7xWk4FCb5CrFa GehJmvbUsVjVgrJcLxYhHIl91YswJeQbNFjKR5CWcp7IKmOfAo/bn3Iou9p0wuHI2Eo6 594hzjqPFRJToT3Yp1awKQdtVFFiSGZId1lQOAWBQ6uX1nTXuO2+Ld+GK9UBub5W7b2k ROhg== X-Forwarded-Encrypted: i=1; AKwUvBwTR4IH8lxTHNfm/VBskNcgacRy8+mwjtsPawAXHxEl2aEEfljI5qosQSGs/ZorQEi88OVcVJSy+sBWeytvUJq2wl2k8Q==@freebsd.org X-Gm-Message-State: AFuF++mJyrqbvksnHx7bqKT25EHPiHSOUBYy6re3PPsH6oPsg4Vr3gs6 NaQuGikSxtFf4Ok32W/BD+qEE8bMt00qKMk2uDU6kq4rqspRpvFLIU4rDJoScWCy X-Gm-Gg: AYBFou2fXQCbkMGyTVSDscRBZY09RsIamNL167QgZD0zZcsSlU0UTceSSpYx/3uZBkk Q/04idf1uQ1pSMlLT/B5GtVXP2gT37LO6+5hZWcYolNMxwhdrRUg5zJyXNVWjFKdnKcFEoZSBLs rHyhFHvrtzun7mKHpiQWSm1OpOzwYEWzJJkabZNGtlF3hgKxMTfQBK0F/PymZw/4zSnMn5LxCsS ZcDB4tmi0Y71uebUv3cCK4xQzj8UGZ/upbDLpwJi3S8t/DMlGW4LawkAD93VcpIxVPzlcQofzrC jYR8NuaugfRaY+4b9lxUzLIkZOkN72ieqw35rJiR7s9zkE73zX3dUbjtaHJniVl8TTk8eohaswE z22CFbmp3jYmE9PNHGPeMhUgzW2RU0NPN5386ZHGA9KkytaEPZobpI2FnD6gYhTxae5GmNahdTb 1fHHkuvM/Qs9aV4FfMSmVKUG1ohJFcbcHs7QcGsH1WuDGS5l9qeseh2A/szX+c6cFwpvwSik/5u Ufemwfh/ibKknadlZ7n7Fg= X-Received: by 2002:a17:903:2f8c:b0:2dd:c100:251b with SMTP id d9443c01a7336-2ddc100258dmr53368535ad.36.1789928376015; Sun, 20 Sep 2026 11:19:36 -0700 (PDT) Received: from smtpclient.apple ([187.15.154.157]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2df3fd8c9a0sm9306515ad.38.2026.09.20.11.19.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Sep 2026 11:19:34 -0700 (PDT) From: "Enji Cooper (yaneurabeya)" Message-Id: <523A3EC8-6827-4B6A-83C7-2E793160596E@gmail.com> Content-Type: multipart/signed; boundary="Apple-Mail=_3046BE27-B678-449B-8847-1D2D77E923A5"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.1\)) Subject: Re: git: 4cc85d1f00fa - main - tests: Fix graid3 insert tests Date: Sun, 20 Sep 2026 11:19:22 -0700 In-Reply-To: Cc: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org To: Benjamin Kaduk References: <6aa697c6.1cac2.4a349564@gitrepo.freebsd.org> X-Mailer: Apple Mail (2.3864.700.51.1.1) X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; SIGNED_PGP(-2.00)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; MIME_GOOD(-0.20)[multipart/signed,multipart/alternative,text/plain]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20251104]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~,4:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4hnvlf2zv8z4YVD --Apple-Mail=_3046BE27-B678-449B-8847-1D2D77E923A5 Content-Type: multipart/alternative; boundary="Apple-Mail=_C7C6E095-ABA5-4897-B7F3-88194586B32D" --Apple-Mail=_C7C6E095-ABA5-4897-B7F3-88194586B32D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Sep 14, 2026, at 10:10=E2=80=AFPM, Benjamin Kaduk = wrote: >=20 > On Sun, Sep 13, 2026 at 5:32=E2=80=AFAM Dag-Erling Sm=C3=B8rgrav = > wrote: >> The branch main has been updated by des: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D4cc85d1f00fa1938923fe8d6fc293459= 3d4303b4 = >>=20 >> commit 4cc85d1f00fa1938923fe8d6fc2934593d4303b4 >> Author: Dag-Erling Sm=C3=B8rgrav >> AuthorDate: 2026-09-13 12:27:50 +0000 >> Commit: Dag-Erling Sm=C3=B8rgrav >> CommitDate: 2026-09-13 12:27:50 +0000 >>=20 >> tests: Fix graid3 insert tests >>=20 >> The script was passing the wrong device name to `graid3 insert` = and >> didn't notice that the command was failing. >=20 >=20 > It looks like nothing changed w.r.t. being able to notice the command = is failing ... is this something where `set -e` is appropriate? Using set -e in tests seems like it=E2=80=99s more likely to cause = problems than solve them just based on past experience with = integrating/maintaining tests written in other (non-ATF) paradigms. I = agree that that would be the best default behavior for production code = though. Cheers, -Enji= --Apple-Mail=_C7C6E095-ABA5-4897-B7F3-88194586B32D Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On= Sep 14, 2026, at 10:10=E2=80=AFPM, Benjamin Kaduk = <bjkfbsd@gmail.com> wrote:

On Sun, Sep 13, 2026 at 5:32=E2=80=AFAM Dag-Erling = Sm=C3=B8rgrav <des@freebsd.org> = wrote:
The branch main has been updated by = des:

URL: https://cgit.FreeBSD.org/src/commit/?id=3D4cc85d1f00fa19= 38923fe8d6fc2934593d4303b4

commit = 4cc85d1f00fa1938923fe8d6fc2934593d4303b4
Author:    =  Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org>
AuthorDate: = 2026-09-13 12:27:50 +0000
Commit:     Dag-Erling = Sm=C3=B8rgrav <des@FreeBSD.org>
CommitDate: 2026-09-13 12:27:50 = +0000

    tests: Fix graid3 insert = tests

    The script was passing the = wrong device name to `graid3 insert` and
    didn't notice that the = command was = failing.


It looks = like nothing changed w.r.t. being able to notice the command is failing = ... is this something where `set -e` is = appropriate?

Using = set -e in tests seems like it=E2=80=99s more likely to cause problems = than solve them just based on past experience with = integrating/maintaining tests written in other (non-ATF) paradigms. I = agree that that would be the best default behavior for production code = though.
Cheers,
-Enji
= --Apple-Mail=_C7C6E095-ABA5-4897-B7F3-88194586B32D-- --Apple-Mail=_3046BE27-B678-449B-8847-1D2D77E923A5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmqwI6oACgkQGpE5DjPs NJhg9g//ZGVAOuKtOoMOrXgnc3s2roCTjZSNNisARhxbekdNTstWyad65tI/MCsN VnIttGLuDkpvGhVRXiQ92bFAIJHhcaOVr7H4HAl3QUZvHltGwBuYWnWbOdWbp0e8 OsB4HbaZYrnUkrZt188pKIv840XGWVCnVxPzwXaEcU5d87xlGW3cGek16T1NeaAW FE0Nmj9UmroQ7rK5yVCagLuyiKl2VBv2Q7mF8WTo6CTxD9xIjEAch4XZG5o5ZWLs ttZ65EO/Bdv4kCZzlJ7SEO9MC6o24G+wNLcaahKslMUK2BxpHkKSpnIbBVgLvP94 SoF7sO8D8rX7DoviHtmv+lnbvd8BXNvBzDSsF42+kCWCahrLO808AOpPXD04Y1hr cWQfnNrfuPubukTNNYWHVEOxmVNC5t3z3gwMLH9+CjchP8ANkdq80ZOdGokLE7UG gDHngH96FBTKJEDs5K3JjtiGFpPY9EgkJ+F0257T6FOq3awdugLksf5nBt0EvQXQ pz/hlWdlFa5aAPSWvLRBXyzXVIJ0NDFlCYoOd98inzghGdX5AHrAdhfEqzlWI5F+ P5Isp2zmy2cK5RNXebKd4E9PgrNaLtTvIU8p7qJwW/iKi1rf9EnID6O6c1NIJad0 DmvskZkTnh4XL/X8KsJo8eZKslUKUBFae6+N+Sd9ifvR/Pgw5mE= =evQS -----END PGP SIGNATURE----- --Apple-Mail=_3046BE27-B678-449B-8847-1D2D77E923A5--