From nobody Sun Sep 20 16:16:24 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hns1h0WbBz6s70M for ; Sun, 20 Sep 2026 16:16:40 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pz2-x0f.google.com (mail-pz2-x0f.google.com [IPv6:2607:f8b0:4864:3b::f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hns1g33lCz4BKf for ; Sun, 20 Sep 2026 16:16:39 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=pWJAj2++; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:3b::f as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pz2-x0f.google.com with SMTP id d2e1a72fcca58-85469a34908so2081409b3a.0 for ; Sun, 20 Sep 2026 09:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789920997; x=1790525797; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:from:to:cc:subject:date:message-id :reply-to:content-type; bh=HUATsA/YM5oOM0RNX9Gc70mL9FByehzVMJvCRfv+lok=; b=pWJAj2++RGhvn18uIvVSHo/fv6u6AT7o7IlCbwh/27xey1LorCi6g84jPwwz9Xmbz5 AiRxfGXs28/FTXyEa+0GsXr7zrfDccik/bIQPow3M0pZEVx9vkJbvRy2ypM96iaNHNVi wxVQ5sh+1qPlVRr2OjFt+iJa6LJkBDQyFWu6t4apaqZlICKI2KyNEqJzCy/RhPCfQDJG fdt3dHgqBCy+h6UdtNcn5X9KQzggeHP/HePYlplQ1+hiYFBbS4vdWGu3k5+Mt/yNuq7L 1uNbRO4IU9+eqgmL/PBE7XeQTADdTT9MQLatMx42SLDi+3Vze5oqK6bYmPzrvTw0Vdww KgPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789920997; x=1790525797; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=HUATsA/YM5oOM0RNX9Gc70mL9FByehzVMJvCRfv+lok=; b=Ng/zlrqPBjj3OTUzf21BXsJi9fxg907Amj436K4L79WgWqfoSx4zKGqYVWKBDzv9eE 0YOKNjmRaFvSjjClJvQRTpUln6WTkXFscqeWa7nMsFBhoBv7YJjxbuk6zW51jEBmowgY POpnVCQfEtkxKbZAT+W+EgO7io74zUrWNQwS1VbunOXwAtppiGYlbSucrpwxxUs7iRKo K8nKq/hYzXvSwWWQzEvnvOUBTp9caBvX+XzLGhQCZjE0TJwQIvUkU3DgiJ2rnK2a64ZV ZcC424QQcj63+QVzvc5C/dyQInrWsDA+h4Meg8IWAhWWMixf2jVokb1JudoOQcr3Op1+ EErA== X-Forwarded-Encrypted: i=1; AKwUvBw3J/eCpGn5TQsJGMoaEVpY2ceSVqbYCn/vQVEU5Lj8c1ebsoM87Tn0GCb+O2sn2vRaU4pUYGVKil4NvE+iY+UQefNTyg==@freebsd.org X-Gm-Message-State: AFuF++k3fV9wDQs8+MIWAsp+1yIT/9mqpbGie4ZgaS0SyD8AiBHAW+vj e0AzZe4u3mZCLwBcj6a+2C7xdBre5nVBF3igdK127fUmMYWWphuYlFd+dkWknmYp X-Gm-Gg: AYBFou1MoZd2uoLEq2RCEecuDkrZZkCNbRxcPCabB3r3oaX72/CVx1C8iSQDwHjfVp3 1T+/d7dHdfx66USYyfi2U2OKYrvUFeEEPNsbmfdB8a/xHspJ8xk2oUc2XpRN7u4olQk7BkvuSxU 5jVJHEzdCD92TIcyLzoKnc91ftTOgj/7EmA6UeQinpZr+K0PMdYTCtX8EOnf2HCUFxoZd+aAc2m DJL/FZpyBz/xEsViRlOo2prfeaSArcnjfijVTgZT3BY26+zgbUQwY/JV9juqDkj9ULbnOU1tqKa 0TKXGvAB/NLovmMWgmfLU+gHbC/JbRgzO0cNjt8xtQx04sArQdGP6nTIqdtX4r1sTQJCfrGifPQ 3M6H6T/yW5hFvrFJf1y0nzLvydLA0baerLgjbCs9lWiTFMoQuRSKrEdHPKz0j9cYonjmroMek3l sFtYqTlOCprckqabMQTzidbOs1K7ZU4hh7fHlniw3rrh4UzT9I1GAWLHURtT05guBnOADsdjWaK YzAnZG9lwqpZ2wDcorGJLc= X-Received: by 2002:a05:6a20:729b:b0:3dd:a196:69e1 with SMTP id adf61e73a8af0-3dda196786fmr6528861637.60.1789920996807; Sun, 20 Sep 2026 09:16:36 -0700 (PDT) Received: from smtpclient.apple ([187.15.154.157]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc72acd1767sm2286267a12.2.2026.09.20.09.16.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Sep 2026 09:16:35 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_6C8E3729-318A-4ACB-ACFF-823F78F66C1D"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.1\)) Subject: Re: git: a5a3daf88af5 - main - fixup! libmlx5: Extend mlx5dv_get_qp() to return UAR mapping info From: "Enji Cooper (yaneurabeya)" In-Reply-To: <0a479927-623a-4889-9eb0-aee3d1cf0755@FreeBSD.org> Date: Sun, 20 Sep 2026 09:16:24 -0700 Cc: Konstantin Belousov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-Id: <08FF7D22-372A-4AB8-A49B-EAA815F6EB91@gmail.com> References: <6aaaa3d7.35fc8.1961289@gitrepo.freebsd.org> <0a479927-623a-4889-9eb0-aee3d1cf0755@FreeBSD.org> To: John Baldwin X-Mailer: Apple Mail (2.3864.700.51.1.1) X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; SIGNED_PGP(-2.00)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20251104]; SUBJECT_HAS_EXCLAIM(0.00)[]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4hns1g33lCz4BKf --Apple-Mail=_6C8E3729-318A-4ACB-ACFF-823F78F66C1D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Sep 18, 2026, at 7:42=E2=80=AFAM, John Baldwin = wrote: >=20 > On 9/16/26 23:07, Konstantin Belousov wrote: >> On Wed, Sep 16, 2026 at 02:12:39PM +0000, Konstantin Belousov wrote: >>> The branch main has been updated by kib: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Da5a3daf88af5e4d30952a7fc8b4d27d8= 3458f484 >>>=20 >>> commit a5a3daf88af5e4d30952a7fc8b4d27d83458f484 >>> Author: Ariel Ehrenberg >>> AuthorDate: 2026-07-28 12:02:36 +0000 >>> Commit: Konstantin Belousov >>> CommitDate: 2026-09-16 14:12:06 +0000 >>>=20 >>> fixup! libmlx5: Extend mlx5dv_get_qp() to return UAR mapping = info >> To answer some questions I saw on private comm channel: >> The form of commits was intended, I initially have a plan to squash = fixes >> into the corresponding commits. But after some thought, I decided to >> keep the original commits intact, and push fixes as separate changes. >> This preserves the authorship and does not attribute changes not made >> by the initial author, potentially putting him off the hook. >> Might be I should have edited the 'fixup!' rebase markers. Note that >> using the 'Fixes:' tags is impossible because I cannot know the final >> hashes in advance. >> This patch series as a whole was validated by Nvidia verification for >> ConnectX RDMA. >=20 > FWIW, when I recently pushed a set of changes to iw_cxgbe I used > Co-authored-by: tags to acknowledge changes made by other authors > while keeping the Author field as the "main" author, including when > cherry-picking changes from the Linux driver rather than using > separate fixup commits. I think the specific phrase fixup! is also > best if reserved for commits you intend to squash (e.g those created > with git commit --fixup for use with a later git rebase --autosquash). > If you want to keep them as separate commits it would be best to > reword the title to avoid confusion. As someone who uses `git rebase -i =E2=80=94autosquash` frequently, this = could cause havoc for me (and other downstream projects) if that flag is = used. Thank you, -Enji= --Apple-Mail=_6C8E3729-318A-4ACB-ACFF-823F78F66C1D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmqwBtgACgkQGpE5DjPs NJijdQ//VtQ6n/dI6N78Koa+1Zve6uQZMKg8ceK9TJrpw1UmjY5KCtyGxAFyI6EL s6hxnwHqyojIkgoJSWdeA0wlwYPqtxFTg7L5JgakXKhLgnDm/L186QGay4FaFqUT 8a+IfntlFvu2+8eCEG0GRcpdYUueZQgogcsY9biArgUa94FD92iv4P4UE6E1zs8L IzlKc0umnkvNGCp6GGbj1pZ3c+2doExLHB5m57nc/oGbebWYmxwAepbMAt6d7Tey L+5CroJFMihFD0/9mWzxyRmz5FWUTjqNuwm+Hy6U+ozv1dstaDhECcEo35d2846+ 4dufXTo/bTwMzta0dJtq5zrKPJSjlcq2OVtW1EWZ6DZv5kVKJGiKjeLkzORTjfW3 HRix/+OnyXDu41umIEpnKktAZEtU/xhfYM9M9GRjKpsH4a/OC7nSA/KXTglIyw8k o1mkJiFappr0fkb8MN53kUZ8f9TM52vqmd+6ZKWAeTGXiNWvMlsXOyO1tAODMs1R i5q1kyUWu73VppoDD6s4Ciz1D/mNQXdL+IwDh0kw/QajEwH4PFThuNKfdNL60KY0 aKnoPyQHemEP5yfM50aTQwoVVntNigjulp4fx6ZJ5VmLWAvrT44f20+qP+ISpNkC Jhd2/Xf5hsFFemx7IAVrxoyf+pjtHfwO72nhQyKJqkDQJ9TJMLM= =kC80 -----END PGP SIGNATURE----- --Apple-Mail=_6C8E3729-318A-4ACB-ACFF-823F78F66C1D--