git: 28cad382a2bb - main - ec2-desktop: Fix shell expansion in ec2_setpass

From: Colin Percival <cperciva_at_FreeBSD.org>
Date: Sun, 20 Sep 2026 01:28:08 UTC
The branch main has been updated by cperciva:

URL: https://cgit.FreeBSD.org/src/commit/?id=28cad382a2bb5fc398bd11f8e7b3637ad6c03334

commit 28cad382a2bb5fc398bd11f8e7b3637ad6c03334
Author:     Colin Percival <cperciva@FreeBSD.org>
AuthorDate: 2026-09-19 23:53:15 +0000
Commit:     Colin Percival <cperciva@FreeBSD.org>
CommitDate: 2026-09-20 01:09:36 +0000

    ec2-desktop: Fix shell expansion in ec2_setpass
    
    Using a backtick inside a backtick-expansion isn't a good idea; switch
    instead to using $( ... ).
    
    Fixes:  a9710349513f ("EC2: Add desktop flavour")
    Sponsored by:   Amazon
---
 release/tools/ec2_setpass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/release/tools/ec2_setpass b/release/tools/ec2_setpass
index 6bc5a73dc33b..cd3324a58ebb 100644
--- a/release/tools/ec2_setpass
+++ b/release/tools/ec2_setpass
@@ -43,7 +43,7 @@ ec2_setpass_run()
 	# Set a random password, and print it in encrypted format
 	PUBKEY=$(mktemp -t ec2_setpass)
 	ssh-keygen -e -m PKCS8 -f ${SSHKEYFILE} > ${PUBKEY}
-	PASSWD=`jot -cr 16 / z | tr '\\`' '-+' | rs -g 0`
+	PASSWD=$(jot -cr 16 / z | tr '\\`' '-+' | rs -g 0)
 	echo "${PASSWD}" | pw usermod ${ec2_fetchkey_user} -h 0
 	echo "Username: ${ec2_fetchkey_user}"
 	echo "Password: <Password>"