From nobody Sat Sep 19 10:18:32 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hn56w5Qm5z6sbHh for ; Sat, 19 Sep 2026 10:18:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hn56w4xsNz3Qkm for ; Sat, 19 Sep 2026 10:18:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789813112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=M8DFnizloxLPAOQtuQU5pch12jmlT6Jb2sMNYXj6WbU=; b=H0HvI4z2J90uEgzrvtrZMQmnX0db10Lr7/kxykwkbYbBAHeATiqHQ/D/jg7kq33MPXmzzq GXp6TwQ3bTF3M5E9FWxVxJ/0gad6l/GigWtsHT5rb/5eMNkf4jJh+grKWg8cfwwPfcRAPU KHkqgpRowUL73MBAiSFqyRKu3vnpY5apaFEPfrhzZ/0eqeaqw9nPHdq+8OD8E+QT9n20hq AUpjaTM3RJKR8C7PhlzwGRtt47pM9LCFRsRHicLVM7siKaLLxceHtk8Hses9Okx3MgRYWW n91Wv48qwKlXJPY8M70Fh5K1g8n69/HQQU1/GNoVLdN+i42lH9jvZr0cf/AKRA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789813112; b=ipqPVSFMJqn5awj8LO6oUw5np18wJXkXc2fOTOc40u/1Z+5ue0Iy5vGXNWbljcV0mQ4tSA tjhySoVmCu7RLfHv4fM06KKJbLNUCWFErVDqAOoU5ECt7uIqthITmmucvK10clGKg+t4Nn o4HP/0hCYo8Bla9mM3qglNQBcnpCBBMvscmS52isnNJ/7Ym7YD/WiX71sgbY9VzhCZJQgn BBzIyCLe5k/1TJbgfyJQV8VpOArHB4lUNBO+zlV9vpXoTDYBMcZSZIsmAs6cgb0DN4ic8J zl4F3pxNjb38cKC467IMkXOVufIl2M6NU3L9RTh5ITts28U499t/MbfUCd9r+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789813112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=M8DFnizloxLPAOQtuQU5pch12jmlT6Jb2sMNYXj6WbU=; b=FOboJDv+DDBU/A0oYfkSu8DWOCxEhGEMsVVWBzIAJK5a+u5qz8vq7A9NSrZmmfxyBTcu1Z avBpsMRJ9l+IZBLDNQ6CaQ0Z+FBJiiUEWCdoC8dsLFOCGTbi9hWG4pDs4tyo8SIuItDQvw yj8ztlkP7G10qMcuJ7I17KsGAtvR4/ekBbZguD1N0sDN+i7tHKdWji+W3WkNfz1GE/48LA 8gjypNsnatGb2lG/8YlL9MV00KZiFZ5tFvJBj0dyALJHxf20Azx2F7C2a5SeXnd2PWTJLF g4pQLkndu8xrKpB2YnS7Q5IKOJxQ/lXv3mIQ6iCnlfdSY/+4jfFQ4F8Qjp8puw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hn56w3c5jz119N for ; Sat, 19 Sep 2026 10:18:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21ffb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 19 Sep 2026 10:18:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Faraz Vahedi Subject: git: 225612c76d87 - main - dd(1): Preserve const qualifier on bsearch(3) results List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kfv X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 225612c76d870aa6467853fbafcbe34e8296d0d9 Auto-Submitted: auto-generated Date: Sat, 19 Sep 2026 10:18:32 +0000 Message-Id: <6aae6178.21ffb.2b252dff@gitrepo.freebsd.org> The branch main has been updated by kfv: URL: https://cgit.FreeBSD.org/src/commit/?id=225612c76d870aa6467853fbafcbe34e8296d0d9 commit 225612c76d870aa6467853fbafcbe34e8296d0d9 Author: Faraz Vahedi AuthorDate: 2026-09-19 10:13:20 +0000 Commit: Faraz Vahedi CommitDate: 2026-09-19 10:13:20 +0000 dd(1): Preserve const qualifier on bsearch(3) results Reviewed by: fuz, dteske Approved by: fuz (mentor), dteske (mentor) MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D59754 --- bin/dd/args.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/bin/dd/args.c b/bin/dd/args.c index 10bb89e632b0..0ae50c40414c 100644 --- a/bin/dd/args.c +++ b/bin/dd/args.c @@ -103,7 +103,8 @@ static char *oper; void jcl(char **argv) { - struct arg *ap, tmp; + const struct arg *ap; + struct arg tmp; char *arg; in.dbsz = out.dbsz = 512; @@ -117,7 +118,7 @@ jcl(char **argv) if (!*arg) errx(1, "no value specified for %s", oper); tmp.name = oper; - if (!(ap = (struct arg *)bsearch(&tmp, args, + if (!(ap = bsearch(&tmp, args, sizeof(args)/sizeof(struct arg), sizeof(struct arg), c_arg))) errx(1, "unknown operand %s", tmp.name); @@ -265,7 +266,8 @@ static const struct iflag { static void f_iflag(char *arg) { - struct iflag *ip, tmp; + const struct iflag *ip; + struct iflag tmp; while (arg != NULL) { tmp.name = strsep(&arg, ","); @@ -375,7 +377,8 @@ static const struct conv { static void f_conv(char *arg) { - struct conv *cp, tmp; + const struct conv *cp; + struct conv tmp; while (arg != NULL) { tmp.name = strsep(&arg, ","); @@ -411,7 +414,8 @@ static const struct oflag { static void f_oflag(char *arg) { - struct oflag *op, tmp; + const struct oflag *op; + struct oflag tmp; while (arg != NULL) { tmp.name = strsep(&arg, ",");