git: ef98d080404f - main - clnt_bck.c: Fix the "glue" for the nfsrdma.ko module
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 19 Sep 2026 00:41:30 UTC
The branch main has been updated by rmacklem:
URL: https://cgit.FreeBSD.org/src/commit/?id=ef98d080404f8dacb0a96799f92df6285fbc895c
commit ef98d080404f8dacb0a96799f92df6285fbc895c
Author: Rick Macklem <rmacklem@FreeBSD.org>
AuthorDate: 2026-09-19 00:39:27 +0000
Commit: Rick Macklem <rmacklem@FreeBSD.org>
CommitDate: 2026-09-19 00:39:27 +0000
clnt_bck.c: Fix the "glue" for the nfsrdma.ko module
Without this patch, the code failed to acquire the error
return for clnt_bck_rdma_send() and could use "error" uninitialized.
No semantics change for non-RDMA NFS service.
MFC after: 3 months
Fixes: 7144a1d58c5c ("nfsd: Add glue for the nfsrdma.ko module")
---
sys/rpc/clnt_bck.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sys/rpc/clnt_bck.c b/sys/rpc/clnt_bck.c
index 65eb95c56fa5..d7c530702745 100644
--- a/sys/rpc/clnt_bck.c
+++ b/sys/rpc/clnt_bck.c
@@ -303,6 +303,7 @@ call_again:
TAILQ_INSERT_TAIL(&ct->ct_pending, cr, cr_link);
mtx_unlock(&ct->ct_lock);
+ error = 0; /* Keep compilers happy. */
if (xprt->xp_socket != NULL) {
/* Handle TCP sockets. */
/* For RPC-over-TLS, copy mrep to a chain of ext_pgs. */
@@ -339,7 +340,7 @@ call_again:
} else {
/* Handle RDMA. */
if (clnt_bck_rdma_send != NULL) {
- clnt_bck_rdma_send(xprt, mreq);
+ error = clnt_bck_rdma_send(xprt, mreq);
mreq = NULL;
} else
error = ENOTCONN;