From nobody Fri Sep 18 23:12:29 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmpLQ1Mgqz6t770 for ; Fri, 18 Sep 2026 23:12:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmpLQ0dykz3Ht8 for ; Fri, 18 Sep 2026 23:12:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789773150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WrTKZ5Ymmn25iliSHYnj96fKI3U/VXLtKZ6SfUL0ha4=; b=MvePrqkpiq71TnEd4z2mOhP013knR2NJwMddjrE9YUkR3uwEfvTC6i4YfcSx8svD3MkThx QZ8E8LpiNFlI0ZVJI7IPCVFzKWixNwMSpywZl9la7wQPwcTNdiQbjqxqKaMR2zxE1X63po WCFBfpyy+5uFORyIcmT1daopa/wkZ1FGLU06xxWyXz9MgF3DraBjPp6OSVYkhfQMC+TqeR ps6bnGMqfCn04zR/oCyF3KBa0HHPWJrxiLO6BmUUYIi1LzMtdie64Zi+5n81cvOzz1wQ7y FWe16OeL9E3O7l91no6xSz/9UD+VyIyKorhjT/hejkxOlXy0NG47qmuT42kEyw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789773150; b=m3F/DAsa9NVQ/2B24ORk4zCLOzry93Xb0RhNS7eBKPPKBDSxdRMK78wpXsVeBkGNwwIesv Q5vl/1SONtZjapUMdJLjZZLv3OTUSNymJe4He/2w5JqeuFEbpIIu8S+F1bp8bZE5rg/Gss SBEaQ4rb4l30kQYpJHInt4dAtjLD1NM1MEKZp4GiIBeZGpdhA29nZ+Es2q2T+dYkk7aYqr hZBOL6HvJ/qK32ZKfEBPOTkA9/q0H2PyI05CyZQIeFDMnjGsJSvUQr/46cLFzOU0GYIWBu b8hFpugK9hgatnUd3Rj5PhWwTZKEQ5QeYcZNu7QMwfhICG0PRQHTkLWnzQwnsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789773150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WrTKZ5Ymmn25iliSHYnj96fKI3U/VXLtKZ6SfUL0ha4=; b=FGfogA1rfMQDl4d/VVQyR23FY511JtcUmj6Bi1L1vqqZMdgs8v2yIxO2FywaBa2oIq6T3i +FtcUlQSVk31qBExDfX0MvFuoQP6zhiXnY9DPrdt3POhyi8JdfQ9qSgQh5/dRj660YXnqg DanMCVmWVKxzJ8EYCTlmYjaA5JHafxw9Zk3A2y52lmHNMEk3GnLLODX9/YjmbPD9jUeF+s kX6uGdcAH2P3285fd4n3rkNJDJP8jmSTQ4gHDNVMrYocMYEtxRGHD77xZIjj9Fgs/hxDHI c79HAzaYH5I6jWDrNz6x55ClDzZS8HOV8LGrpvfUQa6SYt/Gxvb13Ro3kx9Jmw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmpLP6qdFzh8h for ; Fri, 18 Sep 2026 23:12:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 25a36 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 23:12:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 8c25b70120e8 - main - vnic nicvf: Program the common RSS key in network word order List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8c25b70120e8838135cb356c94d350105f45ff7c Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 23:12:29 +0000 Message-Id: <6aadc55d.25a36.73acd9e@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=8c25b70120e8838135cb356c94d350105f45ff7c commit 8c25b70120e8838135cb356c94d350105f45ff7c Author: Kevin Bowling AuthorDate: 2026-09-18 08:56:00 +0000 Commit: Kevin Bowling CommitDate: 2026-09-18 23:11:48 +0000 vnic nicvf: Program the common RSS key in network word order Replace the repeated hardware-reset key with rss_getkey(). Decode each eight-byte chunk with be64dec() into the register-word array before programming the five key registers. This matches the key serialization in DPDK's nicvf_rss_set_key(), added by commit 7694fab264ac666d62a4cae04f2979991ce64259 ("net/thunderx/base: add RSS and RETA configuration"). A raw copy into the word array on little-endian hosts would reverse bytes within each register relative to that convention. Preserve the CPI-algorithm gate, enabled hash fields, and round-robin indirection table. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59806 --- sys/dev/vnic/nicvf_main.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sys/dev/vnic/nicvf_main.c b/sys/dev/vnic/nicvf_main.c index 59f7abeacdd5..b6858a73b978 100644 --- a/sys/dev/vnic/nicvf_main.c +++ b/sys/dev/vnic/nicvf_main.c @@ -60,6 +60,7 @@ #include #include #include +#include #include #include @@ -1055,6 +1056,7 @@ static int nicvf_rss_init(struct nicvf *nic) { struct nicvf_rss_info *rss; + uint8_t rss_key[RSS_KEYSIZE]; int idx; nicvf_get_rss_size(nic); @@ -1068,12 +1070,12 @@ nicvf_rss_init(struct nicvf *nic) rss->enable = TRUE; - /* Using the HW reset value for now */ - rss->key[0] = 0xFEED0BADFEED0BADUL; - rss->key[1] = 0xFEED0BADFEED0BADUL; - rss->key[2] = 0xFEED0BADFEED0BADUL; - rss->key[3] = 0xFEED0BADFEED0BADUL; - rss->key[4] = 0xFEED0BADFEED0BADUL; + _Static_assert(sizeof(rss->key) == RSS_KEYSIZE, + "RSS key size mismatch"); + rss_getkey(rss_key); + /* Each key register holds eight bytes in network order. */ + for (idx = 0; idx < RSS_HASH_KEY_SIZE; idx++) + rss->key[idx] = be64dec(rss_key + idx * sizeof(uint64_t)); nicvf_set_rss_key(nic);