From nobody Fri Sep 18 22:38:05 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmnZj3n2Cz6t4v5 for ; Fri, 18 Sep 2026 22:38:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmnZj35Jvz54Hf for ; Fri, 18 Sep 2026 22:38:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789771085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OtQ/pJTxLwX8nFMEh3Nx8VI6wBAQg5e8T9+77vNYlSo=; b=mENSKtvRFgiI1+FFwYTo5ueK7eHT48s29+TptOoY1oBZbLsGwIW4p3ZieBqi/mjm1WpqAO kOKvkoXL+9uYEcEX3dhvOTXwZRxzE/mKvZl+CHNuh+FEQ8EPwI1g/9u86j5a6WSmTMSwd4 tme3ZogA3vEhDTppn/enkFESPv5J1qkqByVWamPsaHxWFIY9DZ5TD7GqzzuJ4WNYIK8VyN om2pVkradqcsmNsOYfGrBOUKeSes/kOECnYIGYALrA3I9tKmmONl7XyylYQRTyO16TkL1y igfZ1dRwN7W7JIAhCmObAXCBHr9zK3c6rPjDGJGUv8Qx4YYFtbFNn11UBOuppA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789771085; b=YD2+1ukKCotwl4N5aIjTjqZA5X0LxKpnHmoYb+6kJlHdhdh2tdqn2a0AQjaGDSLXQPQdyU vh6S02NjBVZBcXK4UICqRQK4VDdIJavnrrLQgq82KTsh0hMlyEWsSIbSgQJ6HQOL+mKnBK VELWTsFamYaevZftRpsuQHm3bs8B23F1O9jDoaq33OBzwQDSOjNmWgMs/oAvQJoS/UkBo4 j8oFatOPO0j44vRrSQ/jNafBoIJcnkKrAOk3eyKvLHfC6IU52K4kFIgYzxCNmSJe9ozgcV pihXduNc8GGHdmpza+r9A+Y3UD1SyI6YA2ebuwijB/u2+Hq5iQCNokUmYuPgTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789771085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OtQ/pJTxLwX8nFMEh3Nx8VI6wBAQg5e8T9+77vNYlSo=; b=Nu6bkFWsSuHv1AgTew/tNLpuUydH1mUz4+yzMngl2txrFb5DdEpS/+MGv+0eObgsiOcNAf 1eEVMkmXibJHZbF6nsmhzZecgTznYJh3lSG8B2QAyP1QFoln77Hr+SAPZjohBx0i2g95tW p2Iu9CqGcs/nyrRXJrXwiRg9+7jSfcpdtUjfFla80IOnSDO1AKCMT8VfpsUbHnvFYrmFB0 vD56mj5czKqtOQtINlo7dfgEVCExQe8yu5wLzV+005szgGIUaHnRTFVoW6nYMekXfVBwFM Fbyjep4EqpQHuOuI7fxgap5XMNA5m61odSD0SyBji0Ah1TC5Gtc55A/7Hypybg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmnZj1thFzfcT for ; Fri, 18 Sep 2026 22:38:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 215f4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 22:38:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 709d7cf3039f - main - ixgbe: Use the common RSS key without options RSS List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 709d7cf3039f648e23260a35c1094b15b4d4593b Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 22:38:05 +0000 Message-Id: <6aadbd4d.215f4.135d8e1e@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=709d7cf3039f648e23260a35c1094b15b4d4593b commit 709d7cf3039f648e23260a35c1094b15b4d4593b Author: Kevin Bowling AuthorDate: 2026-09-18 07:43:37 +0000 Commit: Kevin Bowling CommitDate: 2026-09-18 22:35:53 +0000 ixgbe: Use the common RSS key without options RSS Use rss_getkey() for PF and VF RSS programming even when options RSS is not configured. The common key is available independently of RSS queue placement and is also used by software hashing. Generating a private key on each initialization defeats that agreement and changes receive hashes across resets. Leave hash-field selection and indirection-table placement unchanged. 82599 and X540 VFs retain their PF-owned RSS configuration. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: BBOX.io Differential Revision: https://reviews.freebsd.org/D59789 --- sys/dev/ixgbe/if_ix.c | 8 +------- sys/dev/ixgbe/if_ixv.c | 8 +------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 9aca44c6d8fa..74ccfb7f629f 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -687,13 +687,7 @@ ixgbe_initialize_rss_mapping(struct ixgbe_softc *sc) u32 pfmrqc; #endif - if (sc->feat_en & IXGBE_FEATURE_RSS) { - /* Fetch the configured RSS key */ - rss_getkey((uint8_t *)&rss_key); - } else { - /* set up random bits */ - arc4rand(&rss_key, sizeof(rss_key), 0); - } + rss_getkey((uint8_t *)rss_key); /* Set multiplier for RETA setup and table size based on MAC */ index_mult = 0x1; diff --git a/sys/dev/ixgbe/if_ixv.c b/sys/dev/ixgbe/if_ixv.c index b2c192caaae1..378a0c18cbf6 100644 --- a/sys/dev/ixgbe/if_ixv.c +++ b/sys/dev/ixgbe/if_ixv.c @@ -1788,13 +1788,7 @@ ixv_initialize_rss_mapping(struct ixgbe_softc *sc) int i, j; u32 rss_hash_config; - if (sc->feat_en & IXGBE_FEATURE_RSS) { - /* Fetch the configured RSS key */ - rss_getkey((uint8_t *)&rss_key); - } else { - /* set up random bits */ - arc4rand(&rss_key, sizeof(rss_key), 0); - } + rss_getkey((uint8_t *)rss_key); /* Now fill out hash function seeds */ for (i = 0; i < 10; i++)