From nobody Fri Sep 18 18:18:47 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmgqX0PHRz6spCJ for ; Fri, 18 Sep 2026 18:18:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmgqW6GyRz4P00 for ; Fri, 18 Sep 2026 18:18:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789755527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wILcNHAaUHT+tIDSxNOQWkOLLX6fQl0i3HGDceDqpCo=; b=HDQl/ezDYh2Z8fhfJ8qFr62sWp/qvXA2y+DBTPP7IV/xxA1AX8QM34yFka/dKiHQpsiyml 8aorXo1OR6ZJ65MWZocb9Bwc8tMvi4viAXcJE9L2rhcF7LEwuLA2ZvYzyVRBjuk16C8BKa vmuhmPv0MmB+P1eqB12GDjcujsQD5vLLKbYCXxqcq4Wfc+YpA3W3XoLSqL0VMs7VHkQsSy u420hmxsr0IaMmdgtaRTlfaZdXGWQ0ekw6d/VcSt1ysWIy+PeyC4x0C821SCkkUE5YoJ2V Q+8FntCS/hZjJiufyIeDH5+0NFMx0YyaNCBk3YHYg9YVZ9SANmUXqCeUbYfvsg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789755527; b=cjfGxy0Hn+Q/sZBqNoUScaAEfboQT1NELBUguXaOHtfHCup3vmKUnppYTJyRQZq6mlFTWl HtJox4fWhOLwbBxnwokia/bickWb1TOHycsk06zESZEAuXAA6i6b0oT0rqk6AbykJaFlMj J5NwtQ9q4s2eNE3QMRxA/i+KM7T1j5c8lz+a/imuN68QOj/1uqZsOA6pBI6cyD+OtEfyFZ wZ3QoyiN6rKOTSBu9B4sUED7LEvKMgSBWbADmVvXNc88g0b1SYEouuMHJUrosdOfWdL71w +8cD3V7PLRGBGFPAV6pvzbrTMsEdKyXknGOqR9tWpMYC80MEq4tZoEIWY3eMnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789755527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wILcNHAaUHT+tIDSxNOQWkOLLX6fQl0i3HGDceDqpCo=; b=jDvPgODPF1l+frreum+aL0FpPx4in62fZesBpgroGi+9OZrdwaLU0ztyDRQBPAJ89XK6zq zLBT4d7rctuQidRIaA16aKLpgyUQfiP83SuO867tx8otDQmZSa33G33pDZL47lIhsJQ/SE Y8Fl5rrSaVX/y5U33xx95wctHsmdyGgBvSP5OipfL4WYaQqzOeckou2xdBFB9dCUPr1dRs 0YnsdgbGZWe9zkHZjlohdFIAJ8HKgOvLF55/wLe4Efn6UrysTaf4TukjVrZwlyNJESsgKN cvYFKeKHz8MsrdZe71aGSUkikCjWG/LJxXULD+XGmBeh2N3mEH+pMI5J9zYQQA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmgqW4ctSzV3x for ; Fri, 18 Sep 2026 18:18:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36fb9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 18:18:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 47cf9dc78613 - main - sound: Lock around mixer_set*() in mixer_init() for consistency List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 47cf9dc7861371edcfdb85a38e2c240f430ccb28 Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 18:18:47 +0000 Message-Id: <6aad8087.36fb9.7da8583d@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=47cf9dc7861371edcfdb85a38e2c240f430ccb28 commit 47cf9dc7861371edcfdb85a38e2c240f430ccb28 Author: Christos Margiolis AuthorDate: 2026-09-18 18:18:20 +0000 Commit: Christos Margiolis CommitDate: 2026-09-18 18:18:20 +0000 sound: Lock around mixer_set*() in mixer_init() for consistency Sponsored by: The FreeBSD Foundation MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D59110 --- sys/dev/sound/pcm/mixer.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/sound/pcm/mixer.c b/sys/dev/sound/pcm/mixer.c index ff591cef799f..e3782e7ace04 100644 --- a/sys/dev/sound/pcm/mixer.c +++ b/sys/dev/sound/pcm/mixer.c @@ -557,6 +557,9 @@ mixer_init(device_t dev, kobj_class_t cls, void *devinfo) if (m == NULL) return (-1); + /* There is no need to lock here, but do it for consistency. */ + mtx_lock(m->lock); + for (i = 0; i < SOUND_MIXER_NRDEVICES; i++) { v = snd_mixerdefaults[i]; @@ -572,6 +575,8 @@ mixer_init(device_t dev, kobj_class_t cls, void *devinfo) mixer_setrecsrc(m, 0); /* Set default input. */ + mtx_unlock(m->lock); + snddev->mixer = m; if (bootverbose) {