From nobody Thu Sep 17 06:16:31 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hllrb2yPvz6sVjT for ; Thu, 17 Sep 2026 06:16:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hllrb2SHhz4ZLj for ; Thu, 17 Sep 2026 06:16:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789625791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HskNTEH69a3wIpBMTeamR6T9cwNlrX4iQD99A8l0PnY=; b=FAufYdsVJ1cZrZC0MJsCwcePYWxKOIjUyvf5r7JavsGpWYm74YDpEDkLKuQBYonFJ/K5R2 Kr4l+VrfgyUG3yFTj04F3H/PSTzorbdZgbDPBafnCPCAyNGPGdW8VbsjlSguDidtgxc5i/ pB2zQrIcOMDJhLUrsuUwL59xG1Uv5q2uW9wr2Jy37CEIELr65rlN/wLIc8OXjwCifXE7TR KkrexuZRDdNMY6xmCkaW+BwJMmM1sbFNhyZt5cRj67wklOcl7oTS0QwgwwMgVt5vDLcP0X 6LnpKArcySzLoWwyF9cs29XsJ+dTFN5uG0PfURe4AwP7gMbJzpst4yeR6fEpBw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789625791; b=JflsUw6/L59hty9KPshSvI6aHva5UgUDQd4zjOuX23Cy5OK9VUsy62D/2FpjQciTHujY1U ELMonKRvjudkJendeMzTotfF6+ojoPOz2AH2IJOTjh3jl9WKZjDI+gFJgZlZGHtMvyusEc dEg4AzlrXjouiOohkVwgy/sxj+SnhQA1v77cdnXvTVhbMdBi5dINzLwCOcTuOaMGoFYfoT t4mx0YD24srTipgG7aL4RMjSGwuEaLcpyhY8WdHCQzVSgkWCBYBQ4Z9+MNZXNk4kvHAZ1D N0TC5AtLRyhsay01nclx5WcSqnYYAPEUGuxd94NzJ4AIob7LzN5nOEc0XVrUOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789625791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HskNTEH69a3wIpBMTeamR6T9cwNlrX4iQD99A8l0PnY=; b=fVZZ8JbvBrMt7Rhbw4YT9o5hQlCj1yjlsA55GTvKabx4PiUtKi7nWE1LZ3a6h+uZBhvw3D 0hTkyjSn6/TlT1qTqHDVo37xtljTrYC3pAa4iah+sPEVSTDzjTKCtnNYJvIsPJBrKdVG/0 vvtmSDns+MqjXKKDqOG92MLrNFTZwSNtWUe8ZVb5lZn8e2gWbeI9EF2ikgEJDemxXfkyAd p4uWVoURZDljYIUYVZXfglGja9lcAMgnNGPE6j/PgMS1pv1Ydfd6Ck4TQQo+A5BUwCUb1q +Wrg6RedzFtabCBHKZoVfRp7nlQ6yjGg/D+AqVVL2ytsy8YatZAfIa/078UZwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hllrb1WVczKqs for ; Thu, 17 Sep 2026 06:16:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26c58 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 17 Sep 2026 06:16:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 9a1756f831a7 - main - enetc: Correct transmit queue timeout detection List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9a1756f831a77ee8292821c9efd38c2125bff88c Auto-Submitted: auto-generated Date: Thu, 17 Sep 2026 06:16:31 +0000 Message-Id: <6aab85bf.26c58.5391a50@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=9a1756f831a77ee8292821c9efd38c2125bff88c commit 9a1756f831a77ee8292821c9efd38c2125bff88c Author: Kevin Bowling AuthorDate: 2026-09-07 13:44:59 +0000 Commit: Kevin Bowling CommitDate: 2026-09-17 06:16:13 +0000 enetc: Correct transmit queue timeout detection Test the producer and consumer indices after waiting for transmit completion. The post-decrement loop leaves timeout at -1 on exhaustion, so testing timeout == 0 missed the actual timeout and could report one when the final poll completed successfully. Leave the hardware shutdown sequence unchanged. This only corrects the diagnostic; runtime FLR recovery and command-buffer lifetime handling remain separate work. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/enetc/if_enetc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/enetc/if_enetc.c b/sys/dev/enetc/if_enetc.c index 55fec66266fe..81e59dc10559 100644 --- a/sys/dev/enetc/if_enetc.c +++ b/sys/dev/enetc/if_enetc.c @@ -972,7 +972,7 @@ enetc_disable_txq(struct enetc_softc *sc, int qid) cidx = ENETC_TXQ_RD4(sc, qid, ENETC_TBCIR); } - if (timeout == 0) + if (pidx != cidx) device_printf(sc->dev, "Timeout while waiting for txq%d to stop transmitting packets\n", qid);