git: b44da2b82bb6 - main - fixup! mlx5en: Add sysctl variable mapping driver name to IF name
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 16 Sep 2026 14:12:51 UTC
The branch main has been updated by kib:
URL: https://cgit.FreeBSD.org/src/commit/?id=b44da2b82bb6bbe93de507a96eb78bbc2b264620
commit b44da2b82bb6bbe93de507a96eb78bbc2b264620
Author: Ariel Ehrenberg <aehrenberg@nvidia.com>
AuthorDate: 2026-07-28 10:38:56 +0000
Commit: Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2026-09-16 14:12:07 +0000
fixup! mlx5en: Add sysctl variable mapping driver name to IF name
Mark the new "ifname" sysctl MPSAFE and use strlcpy() so the interface
name it returns is always NUL-terminated.
Sponsored by: NVidia networking
MFC after: 1 month
---
sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
index 7c03a1fcea6b..8983762b9af4 100644
--- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
+++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
@@ -4130,7 +4130,7 @@ sysctl_ifname(SYSCTL_HANDLER_ARGS)
char name[IFNAMSIZ];
int error;
- strncpy(name, if_name(priv->ifp), sizeof(name));
+ strlcpy(name, if_name(priv->ifp), sizeof(name));
error = sysctl_handle_string(oidp, name, sizeof(name), req);
return (error);
}
@@ -4969,7 +4969,8 @@ mlx5e_create_ifp(struct mlx5_core_dev *mdev)
SYSCTL_ADD_PROC(&priv->sysctl_ctx,
SYSCTL_CHILDREN(device_get_sysctl_tree(mdev->pdev->dev.bsddev)),
- OID_AUTO, "ifname", CTLTYPE_STRING | CTLFLAG_RD, priv, 0,
+ OID_AUTO, "ifname", CTLTYPE_STRING | CTLFLAG_RD |
+ CTLFLAG_MPSAFE, priv, 0,
sysctl_ifname, "A", "ifname managed by driver");
return (priv);