From nobody Tue Sep 15 22:08:54 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hkx4h0Y96z6rdbD for ; Tue, 15 Sep 2026 22:09:08 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hkx4g28Hkz4VY8 for ; Tue, 15 Sep 2026 22:09:07 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 74.125.225.76 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-48583cc7ab1so84792f8f.2 for ; Tue, 15 Sep 2026 15:09:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789510146; x=1790114946; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PKlgiRqxvIfc84L6ePuVxD1/xb25hxqF6X1TCaTa1mw=; b=WK89vUNDCShFxzxx9E8IYpIU0BGx+LXNY587vWhOKR+10H5A4z07HYDQdXGtL+E5Ma 6Amsipk58gsLVK+lMCy8SHVIkjiAT+Qrmo+w/ggNIlGiQd9ZK9+ttRb1b4yFhplsPW91 0GyLE3Ne43ZuvLwiMjPXWYXyhABKrYkCpZZRInUfuaoN763T+7kCbp5me9dlgfeZ9069 q0zL4s7/cpccYZrM3IKwlqy4S/Q5zzUhsMQu83BGYp5wIJsBioP19SEY+2mzcy3jOuor DOavnrwtGCzz2UVstCuF0YboJtxAnF6YOe7TAmw7GtgnOvVJKpqD8Oz4k3SXSV3r5fgD kp/g== X-Forwarded-Encrypted: i=1; AKwUvBxRLziUP4ooEhiM79y9a2tpSDwwLeEe049Wrf1SN6QncVR2CdiYWbUXt0AUw/Td1LKLQ9jn60f5zzoMTYUYXjwrDXBEBw==@freebsd.org X-Gm-Message-State: AFuF++lRJHranFeloWyQrBxlyV6iNTi3LAuGgSCN7vH+kEQlLLtxsXx6 K/+b2cNUGBZMeSSX0p8WmSj1QnyFBtCgYEbiVZv6zBn8xChZuW3OPBgQ+NFCAGrhzX8iQe0wVkm DyMQGjJY= X-Gm-Gg: AYBFou2OJ1rcm314NlBDNhei/9eI0gljcGJ35OguGkqQQHwtbvAlv9diUGHkOr+H0lI jbg5QGZMR171HuamWTVrZEVF6gOs/zcny3lZspXqHJjU/mJhsBv8Tdb78PMYnEQZ9kKZfhKoPDf f2m0b3MsCtrINPOmM2BNAMdjQFF4hShDm5uAQ/X1MmwAItSlzwZB/U18HNhegouEYcK2dIugLOJ RXWSyLMCbtecsTSpo45D9unOxVzzwR5WIqFQQEvavC7qTLla+/0Ps6TcYzraQOtH2UKp0qtXUej jm2vKy2fKnl+d1V6jD75HGPiaFaU4nhY84pHWZxsnqCJ/22RYkh2uBejMBy/BwIPyR3taoUcA0q +IMpBU9MMH8uDO60vugf55L8BeElKUhGWegHSVcpa42qWPKtom2ZCE6vULFj16NunSGwjjxLeZz vzn/FxXrq0fMXM6n3ju7vRbrN8c4XF4JpkqfCj5cmOF5pDVTq03lrdrIluiraAGyiQUNy4EmKhQ BApd0ohy+slp3yLPkGdn4ZasnAu4Q== X-Received: by 2002:a05:600c:3547:b0:49c:f4e1:4c2d with SMTP id 5b1f17b1804b1-49eb732633bmr391375e9.16.1789510145636; Tue, 15 Sep 2026 15:09:05 -0700 (PDT) Received: from smtpclient.apple ([2a00:23c8:d60b:1d01:f97b:ed14:3f2a:b746]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4870bf438fbsm2098202f8f.36.2026.09.15.15.09.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Sep 2026 15:09:05 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.100.1.1.11\)) Subject: Re: git: 09711ccb09f4 - main - Remove source_rc_confs, inlined from defaults/rc.conf From: Jessica Clarke In-Reply-To: Date: Tue, 15 Sep 2026 23:08:54 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <6aa9b038.338f3.46192136@gitrepo.freebsd.org> <9467A34A-BDA8-4AC0-9883-1A5401EFF7F3@freebsd.org> <96890F48-7939-459C-92D6-026174AF5281@freebsd.org> <8192F29B-C42C-4579-AF0D-109F483846D5@freebsd.org> <6651F051-4227-4ABA-A4A7-06DBB855FE93@freebsd.org> To: Devin Teske X-Mailer: Apple Mail (2.3901.100.1.1.11) X-Spamd-Bar: / X-Spamd-Result: default: False [0.60 / 15.00]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:74.125.0.0/16]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; ASN(0.00)[asn:15169, ipnet:74.125.225.0/24, country:US]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RWL_MAILSPIKE_POSSIBLE(0.00)[74.125.225.76:from]; R_DKIM_NA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[74.125.225.76:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4hkx4g28Hkz4VY8 On 15 Sep 2026, at 22:55, Devin Teske wrote: >=20 >=20 >> On Sep 15, 2026, at 2:31=E2=80=AFPM, Jessica Clarke = wrote: >>=20 >> just because you=E2=80=99re listed as a maintainer doesn=E2=80=99t = mean you >> shouldn=E2=80=99t seek review from others for 100+ LoC commits. >=20 >=20 > LoC is not the handbook=E2=80=99s "non-trivial=E2=80=9D test; most of = the diff is comments and deletion of the mistaken inline. >=20 > The committer's guide encourages review for non-trivial work. It does = not require a Differential for a trivial follow-up on your own files. = eaeb5f29bc6f inlined source_rc_confs from defaults, broke A_flag, and = left a load path that could not work. I took that out and the direct = debris. That is trivial in the handbook sense. >=20 > https://reviews.freebsd.org/D59658 >=20 >=20 >> We all make >> mistakes even for code we wrote that we know like the back of our >> hands, so more eyes from peers can help us all reach a better end >> result. >>=20 >=20 > I=E2=80=99m correcting mistakes I failed to catch in bapt=E2=80=99s = review; siva later caught them in the tests. >=20 >=20 >> just because each of these changes is fixing something in the >> same commit doesn=E2=80=99t mean they all need to be bundled into one = commit. >> Splitting them up into multiple commits makes it easier to review = (both >> pre-commit and post-commit), and makes it clearer which source = changes >> correspond to what part of the commit message (even if maybe in this >> case it=E2=80=99s relatively apparent when you look at the diff, = modern source >> control software makes it easy to break changes into multiple = commits). >>=20 >=20 > Splitting leaves landmines for bisection. >=20 > The bundled pieces have to land together so main is not left = half-broken for bisect. =46rom what the commit message says I find it hard to believe that it would not be possible to split it into multiple commits without introducing new, temporary regressions. Is that what you are trying to say here? Also, can you please not be so aggressive to any negative feedback? I really don=E2=80=99t think it should be this controversial for me to = have pointed out that a commit listing what sounded like at least five separate things should have been broken up. Jessica