From nobody Tue Sep 15 21:55:22 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hkwn234fqz6rcl2; Tue, 15 Sep 2026 21:55:34 +0000 (UTC) (envelope-from dtf@shxd.cx) Received: from shxd.cx (shxd.cx [207.231.82.159]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4hkwn1482rz4SsD; Tue, 15 Sep 2026 21:55:33 +0000 (UTC) (envelope-from dtf@shxd.cx) Authentication-Results: mx1.freebsd.org; dkim=fail ("body hash did not verify") header.d=shxd.cx header.s=shxd2024 header.b="OA3E5 0F"; spf=pass (mx1.freebsd.org: domain of dtf@shxd.cx designates 207.231.82.159 as permitted sender) smtp.mailfrom=dtf@shxd.cx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=freebsd.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=shxd.cx; s=shxd2024; h=Sender:References:To:Cc:In-Reply-To:Date:Subject:Mime-Version: Content-Type:Message-Id:From:Reply-to:Content-Transfer-Encoding:Content-ID: Content-Description; bh=GXahm/UlIWFFXDoLks13OGNB1hfzUTQuzbG63hmd6fk=; b=OA3E5 0FTJrwoq1pwO6/7cS2IGYeTGgfkHNloZkz+WUp2vovs0QGKYG4p651odqKiCHO5U5FvIogEILixPV 7MmXGELH0pMrSb0cT6Gy9WaOAvZw8APc2swSi76L4L9I3w0ckRgfOgFZ9LLvhfVik70OK+eVMCaqo MmbIHncubhKk=; Received: from lummox.shxd.cx ([10.0.0.254]:62500 helo=smtpclient.apple) by shxd.cx with esmtpsa (TLS1.2) tls TLS_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1 (FreeBSD)) (envelope-from ) id 1x6b7B-00000000HpC-2MpC; Tue, 15 Sep 2026 14:54:57 -0700 From: Devin Teske Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_DDE6BF52-7E59-411D-931A-6FB4EEBC3243" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: git: 09711ccb09f4 - main - Remove source_rc_confs, inlined from defaults/rc.conf Date: Tue, 15 Sep 2026 14:55:22 -0700 In-Reply-To: <6651F051-4227-4ABA-A4A7-06DBB855FE93@freebsd.org> Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Devin Teske To: Jessica Clarke References: <6aa9b038.338f3.46192136@gitrepo.freebsd.org> <9467A34A-BDA8-4AC0-9883-1A5401EFF7F3@freebsd.org> <96890F48-7939-459C-92D6-026174AF5281@freebsd.org> <8192F29B-C42C-4579-AF0D-109F483846D5@freebsd.org> <6651F051-4227-4ABA-A4A7-06DBB855FE93@freebsd.org> X-Mailer: Apple Mail (2.3864.600.51.1.1) X-Spamd-Bar: + X-Spamd-Result: default: False [1.80 / 15.00]; R_DKIM_REJECT(1.00)[shxd.cx:s=shxd2024]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[dteske@freebsd.org,dtf@shxd.cx]; ONCE_RECEIVED(0.20)[]; R_SPF_ALLOW(-0.20)[+mx]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed),none]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ASN(0.00)[asn:14051, ipnet:207.231.64.0/19, country:US]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_ONE(0.00)[1]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; FROM_NEQ_ENVFROM(0.00)[dteske@freebsd.org,dtf@shxd.cx]; RCPT_COUNT_FIVE(0.00)[5]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[shxd.cx:-] X-Rspamd-Queue-Id: 4hkwn1482rz4SsD : at_start: {auth_results {shxd.cx}} --Apple-Mail=_DDE6BF52-7E59-411D-931A-6FB4EEBC3243 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Sep 15, 2026, at 2:31=E2=80=AFPM, Jessica Clarke = wrote: >=20 > just because you=E2=80=99re listed as a maintainer doesn=E2=80=99t = mean you > shouldn=E2=80=99t seek review from others for 100+ LoC commits. LoC is not the handbook=E2=80=99s "non-trivial=E2=80=9D test; most of = the diff is comments and deletion of the mistaken inline. The committer's guide encourages review for non-trivial work. It does = not require a Differential for a trivial follow-up on your own files. = eaeb5f29bc6f inlined source_rc_confs from defaults, broke A_flag, and = left a load path that could not work. I took that out and the direct = debris. That is trivial in the handbook sense. https://reviews.freebsd.org/D59658 > We all make > mistakes even for code we wrote that we know like the back of our > hands, so more eyes from peers can help us all reach a better end > result. >=20 I=E2=80=99m correcting mistakes I failed to catch in bapt=E2=80=99s = review; siva later caught them in the tests. > just because each of these changes is fixing something in the > same commit doesn=E2=80=99t mean they all need to be bundled into one = commit. > Splitting them up into multiple commits makes it easier to review = (both > pre-commit and post-commit), and makes it clearer which source changes > correspond to what part of the commit message (even if maybe in this > case it=E2=80=99s relatively apparent when you look at the diff, = modern source > control software makes it easy to break changes into multiple = commits). >=20 Splitting leaves landmines for bisection. The bundled pieces have to land together so main is not left half-broken = for bisect. =E2=80=94=20 Devin= --Apple-Mail=_DDE6BF52-7E59-411D-931A-6FB4EEBC3243 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On= Sep 15, 2026, at 2:31=E2=80=AFPM, Jessica Clarke = <jrtc27@freebsd.org> wrote:

just because you=E2=80=99re listed as a = maintainer doesn=E2=80=99t mean you
shouldn=E2=80=99t seek review from others = for 100+ LoC = commits.

LoC is not = the handbook=E2=80=99s "non-trivial=E2=80=9D test; most of the diff is = comments and deletion of the mistaken = inline.

The committer's guide encourages = review for non-trivial work. It does not require a Differential for a = trivial follow-up on your own files. eaeb5f29bc6f inlined = source_rc_confs from defaults, broke A_flag, and left a load path that = could not work. I took that out and the direct debris. That is trivial = in the handbook sense.



We all make
mistakes even for code we wrote that we = know like the back of our
hands, so more eyes from peers can help us = all reach a better end
result.


I=E2=80=99m correcting = mistakes I failed to catch in bapt=E2=80=99s review; siva later caught = them in the tests.


just because each of these changes is = fixing something in the
same commit doesn=E2=80=99t mean they all = need to be bundled into one commit.
Splitting them up into multiple commits = makes it easier to review (both
pre-commit and post-commit), and makes it = clearer which source changes
correspond to what part of the commit = message (even if maybe in this
case it=E2=80=99s relatively apparent when = you look at the diff, modern source
control software makes it easy to break = changes into multiple commits).


Splitting leaves = landmines for bisection.

The bundled pieces = have to land together so main is not left half-broken for = bisect.

=E2=80=94 
Devin
= --Apple-Mail=_DDE6BF52-7E59-411D-931A-6FB4EEBC3243--