From nobody Tue Sep 15 21:10:45 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hkvnY21ZFz6rYYk; Tue, 15 Sep 2026 21:10:57 +0000 (UTC) (envelope-from dtf@shxd.cx) Received: from shxd.cx (shxd.cx [207.231.82.159]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4hkvnX5JjDz4Lhx; Tue, 15 Sep 2026 21:10:56 +0000 (UTC) (envelope-from dtf@shxd.cx) Authentication-Results: mx1.freebsd.org; dkim=fail ("body hash did not verify") header.d=shxd.cx header.s=shxd2024 header.b="PUrQi z2"; spf=pass (mx1.freebsd.org: domain of dtf@shxd.cx designates 207.231.82.159 as permitted sender) smtp.mailfrom=dtf@shxd.cx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=freebsd.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=shxd.cx; s=shxd2024; h=Sender:References:To:Cc:In-Reply-To:Date:Subject:Mime-Version: Content-Type:Message-Id:From:Reply-to:Content-Transfer-Encoding:Content-ID: Content-Description; bh=uBb6C9M3Dm0RE93Ungo4/oI+z2Okwpx0gUimZrx1zSk=; b=PUrQi z2j2ONUiluXPwa+QLaEXgrehTVs1dIPKZHgMjTqMYthykohRXtG5inFLB9XAOWMdb+ESYHMqZ1N5q YIWypvLLCFiQuwj4eSpwXVLC9GX4YT0evrTwNs0ljnUcKBHmz/aPR2MG3uq3EwdUSA1AVv9rbsPUO WG6ITOgSNLC4=; Received: from lummox.shxd.cx ([10.0.0.254]:53821 helo=smtpclient.apple) by shxd.cx with esmtpsa (TLS1.2) tls TLS_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1 (FreeBSD)) (envelope-from ) id 1x6aQ0-00000000ISs-3lPM; Tue, 15 Sep 2026 14:10:20 -0700 From: Devin Teske Message-Id: <8192F29B-C42C-4579-AF0D-109F483846D5@freebsd.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_4AAEEB6F-9574-4C07-9EFA-6C8F2329B42A" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: git: 09711ccb09f4 - main - Remove source_rc_confs, inlined from defaults/rc.conf Date: Tue, 15 Sep 2026 14:10:45 -0700 In-Reply-To: <96890F48-7939-459C-92D6-026174AF5281@freebsd.org> Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Devin Teske To: Jessica Clarke References: <6aa9b038.338f3.46192136@gitrepo.freebsd.org> <9467A34A-BDA8-4AC0-9883-1A5401EFF7F3@freebsd.org> <96890F48-7939-459C-92D6-026174AF5281@freebsd.org> X-Mailer: Apple Mail (2.3864.600.51.1.1) X-Spamd-Bar: + X-Spamd-Result: default: False [1.80 / 15.00]; R_DKIM_REJECT(1.00)[shxd.cx:s=shxd2024]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[dteske@freebsd.org,dtf@shxd.cx]; R_SPF_ALLOW(-0.20)[+mx:c]; ONCE_RECEIVED(0.20)[]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed),none]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; ASN(0.00)[asn:14051, ipnet:207.231.64.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[dteske@freebsd.org,dtf@shxd.cx]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[shxd.cx:-] X-Rspamd-Queue-Id: 4hkvnX5JjDz4Lhx : at_start: {auth_results {shxd.cx}} --Apple-Mail=_4AAEEB6F-9574-4C07-9EFA-6C8F2329B42A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Sep 15, 2026, at 2:08=E2=80=AFPM, Devin Teske = wrote: >=20 >=20 >=20 >> On Sep 15, 2026, at 2:06=E2=80=AFPM, Jessica Clarke = wrote: >>=20 >> On 15 Sep 2026, at 21:53, Devin Teske > wrote: >>>=20 >>> The branch main has been updated by dteske: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D09711ccb09f482fd345b2b640dbbeb66= de535041 >>>=20 >>> commit 09711ccb09f482fd345b2b640dbbeb66de535041 >>> Author: Devin Teske >>> AuthorDate: 2026-09-15 20:50:20 +0000 >>> Commit: Devin Teske >>> CommitDate: 2026-09-15 20:50:20 +0000 >>>=20 >>> Remove source_rc_confs, inlined from defaults/rc.conf >>>=20 >>> Inlining source_rc_confs broke sysrc_test:A_flag >>>=20 >>> While here, switch to SPDX, bump version/copyrights, fixup = comments. >>>=20 >>> Prevent common function override when bsdconfig includes new >>> sysrc.subr that contains inlined commons. Fix non-unique duplicate >>> header variable incorrectly shared between bsdconfig's sysrc.subr >>> include and new sysrc.subr include. >>>=20 >>> Harden RC_DEFAULTS parameter expansion from DoS-via-glob (SC2223). >>>=20 >>> Move pgm to the correct location to not override bsdconfig's pgm. >>>=20 >>> Drop _SYSRC_JAILED=3D1 that is no-longer needed. Drop i18n from >>> jail_depend now that messages are inlined to subr. >>>=20 >>> Reported by: siva >>> Fixes: eaeb5f29bc6f sysrc: make independant from bsdconfig(8) >>=20 >> Hi Devin, >> This sounds like it should have been at least five separate (and >> reviewed?..) commits? >>=20 >=20 > grep sysrc MAINTAINERS Re: five separate No. Every change is a direct result of the changes in eaeb5f29bc6f =E2=80=94=20 Devin= --Apple-Mail=_4AAEEB6F-9574-4C07-9EFA-6C8F2329B42A Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Sep 15, 2026, at 2:08=E2=80=AFPM, Devin Teske = <dteske@freebsd.org> wrote:



On Sep 15, 2026, at 2:06=E2=80=AFPM, Jessica Clarke = <jrtc27@freebsd.org> wrote:

On 15 Sep 2026, at 21:53, Devin Teske = <dteske@FreeBSD.org> wrote:

The branch main has been updated by dteske:

URL: = https://cgit.FreeBSD.org/src/commit/?id=3D09711ccb09f482fd345b2b640dbbeb66= de535041

commit = 09711ccb09f482fd345b2b640dbbeb66de535041
Author: =     Devin Teske = <dteske@FreeBSD.org>
AuthorDate: 2026-09-15 20:50:20 = +0000
Commit:     Devin Teske = <dteske@FreeBSD.org>
CommitDate: 2026-09-15 20:50:20 = +0000

  Remove source_rc_confs, inlined from = defaults/rc.conf

  Inlining source_rc_confs broke = sysrc_test:A_flag

  While here, switch to SPDX, bump = version/copyrights, fixup comments.

  Prevent common = function override when bsdconfig includes new
  sysrc.subr = that contains inlined commons. Fix non-unique = duplicate
  header variable incorrectly shared between = bsdconfig's sysrc.subr
  include and new sysrc.subr = include.

  Harden RC_DEFAULTS parameter expansion from = DoS-via-glob (SC2223).

  Move pgm to the correct = location to not override bsdconfig's pgm.

  Drop = _SYSRC_JAILED=3D1 that is no-longer needed.  Drop i18n = from
  jail_depend now that messages are inlined to = subr.

  Reported by: =    siva
  Fixes:  eaeb5f29bc6f sysrc: = make independant from bsdconfig(8)

Hi Devin,
This sounds like it should have been at = least five separate (and
reviewed?..) commits?


grep sysrc = MAINTAINERS

Re: five = separate

No. Every change is a direct result of = the changes in = eaeb5f29bc6f
=E2=80=94 
Devin
= --Apple-Mail=_4AAEEB6F-9574-4C07-9EFA-6C8F2329B42A--