From nobody Sun Sep 13 19:35:28 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hjdmQ0WxJz6sRKN; Sun, 13 Sep 2026 19:35:34 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hjdmQ02t4z3PBg; Sun, 13 Sep 2026 19:35:34 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789328134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TQDupWTLueLTNhm4LoFa86nb9wnA+Vp2Cw4bydu7hwY=; b=Wchz6uFWl9xK4Ode4AylTj1PgRAk+s6m4sVAsaTB1L9uZ2cu9ZeXUKktVJZKeDCyfgGmDl ZKLfw7eGHjfFK9yXUICUvH95rr4zJjpI3+Q3vDTQgeDtDi77peMxLfJdJFxTHt6SiMF+7e 0NhW6XxirYYybc/Zi+FazqNW8tU4ymD8ohugTcEN9uOv3Z34e58DTEUA522EkgtslPpmME Tr62JBReYPCSy9YL8yIpXohLO8T4GiLmdXqLLARzkMsR5zl3dK75AIltZxXs04/LzbvI5o DFRMh49MHfkyBV7F/y1twOH12C7prRd3z88aqOI5CZtDPO9/b/qAA4g5CDrD6A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789328134; b=NhmnmaSWLnUCGUgCPuu1qK/iIh+T+iDP1KkPLJDQjSzO3mGMatR97vSS0jujkgW4so/LdN V9UDAWhL3WuHcXEkVPg4rp2sxldL1i+hnIMvw+BKhRusx8yhIgf2s8bSyUde7NlP7uOghF AIwq0tf9rxLFNtEh5JyTecIKefhFaDB1iFfnYFj2cGXbwEeH7JEYEdIAP+s33mc4mz2Tnt AyuJgyAaexZpYfAynH6+aVPR/miMRt9kvjO3apPz+pFPLhgA3ydi9IVwSBEit0JpIcIuVe LssHRy4z0fWeHKf5mh5dPjjccwarpl7XToUrL+PG0MLfmxdKOyyX7hUP/aQw0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789328134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TQDupWTLueLTNhm4LoFa86nb9wnA+Vp2Cw4bydu7hwY=; b=LHv565Js2y6pwd96A7TA9Sfcq1r+PViNTgA5rPQCbjEEPZ94KeUut0GdoIHMawQ8Z6fL5Q 4vLB4VCBrYWRGzSoHAvRiiQo8b4HR7mulBtsj7F+kkGIUfnGwWJo9zJGPjME9v5SO/wUgM Q07fQ3ZLqEaRGNGTHGPGY9fKcVWd478fJ9APfNKPbLcoIqa9LIDwjoaHIO1WGLM6dOg8EU XYns6zoW2BeS6M8oVeZkLfNSCC7VNV7gXUs5CAG1ZHJlIY8P9g+hZUFOyBnB8Wvbv7VZgs yOLsliCVaw3sDpibMIrt7jUDFd8kb9lNcdWNvSCuFXMxSm8Y+QXiIJ7GEu/9Xw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "YE1" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hjdmP56KLz17rX; Sun, 13 Sep 2026 19:35:33 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id E254D6195706; Sun, 13 Sep 2026 19:35:31 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id BCB132D029EC; Sun, 13 Sep 2026 19:35:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id hn7N0pkX38th; Sun, 13 Sep 2026 19:35:29 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 1DDF62D029D8; Sun, 13 Sep 2026 19:35:29 +0000 (UTC) Date: Sun, 13 Sep 2026 19:35:28 +0000 (UTC) From: "Bjoern A. Zeeb" To: Alan Somers cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: b551cb063c5e - main - During shutdown, announce each file system as it's unmounted. In-Reply-To: <6a9b3480.38176.68cc4be7@gitrepo.freebsd.org> Message-ID: References: <6a9b3480.38176.68cc4be7@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Fri, 4 Sep 2026, Alan Somers wrote: > The branch main has been updated by asomers: > > URL: https://cgit.FreeBSD.org/src/commit/?id=b551cb063c5efe66a634b5afded901a0323bcee2 > > commit b551cb063c5efe66a634b5afded901a0323bcee2 > Author: Alan Somers > AuthorDate: 2026-09-04 20:48:41 +0000 > Commit: Alan Somers > CommitDate: 2026-09-04 21:12:46 +0000 > > During shutdown, announce each file system as it's unmounted. > > But only if debug.bootverbose=1. > > MFC after: 2 weeks > Sponsored by: ConnectWise > --- > sys/kern/vfs_subr.c | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c > index 8d6793ad9573..f324e02e44d7 100644 > --- a/sys/kern/vfs_subr.c > +++ b/sys/kern/vfs_subr.c > @@ -5143,11 +5151,20 @@ vfs_unmountall(void) > if (mp == rootdevmp) > continue; > > + if (bootverbose) { > + printf("\tUnmounting %d/%d %s\n", ++n, nmountpoints, > + mp->mnt_stat.f_mntonname); > + } > unmount_or_warn(mp); > } > > - if (rootdevmp != NULL) > + if (rootdevmp != NULL) { > + if (bootverbose) { > + printf("\tUnmounting %d/%d %s\n", ++n, nmountpoints, > + rootdevmp->mnt_stat.f_mntonname); > + } > unmount_or_warn(rootdevmp); > + } > } > > static void Is there a reason this needs to be \t indented? .. Syncing disks, vnodes remaining... 0 0 done All buffers synced. Unmounting 1/2 / Unmounting 2/2 /dev Uptime: 1d7h36m47s uhub0: detached Just looks weird there... -- For there shall arise false Christs, and false prophets, and shall shew great signs and wonders; insomuch that, if it were possible, they shall deceive the very elect. Behold, I have told you before. [Mat. 24:24-25]