git: 9094f86b57a7 - main - graid3: Restore lock acquisition
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 13 Sep 2026 12:32:05 UTC
The branch main has been updated by des:
URL: https://cgit.FreeBSD.org/src/commit/?id=9094f86b57a7e4b356cae83f35c8d41c842b42a2
commit 9094f86b57a7e4b356cae83f35c8d41c842b42a2
Author: Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2026-09-13 12:27:18 +0000
Commit: Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2026-09-13 12:27:18 +0000
graid3: Restore lock acquisition
The lock acquisition in g_raid3_ctl_insert() was improperly dropped a
while ago, making it impossible to add or replace a device in an
existing graid3. This went unnoticed because the tests are broken.
MFC after: 1 week
Fixes: fcf69f3dbce6 ("Consistently use gctl_get_provider instead of home-grown variants.")
Event: EuroBSDcon 2026 DevSummit
Reviewed by: delphij
Differential Revision: https://reviews.freebsd.org/D59563
---
sys/geom/raid3/g_raid3_ctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sys/geom/raid3/g_raid3_ctl.c b/sys/geom/raid3/g_raid3_ctl.c
index 5eafcce917cf..11d612b93376 100644
--- a/sys/geom/raid3/g_raid3_ctl.c
+++ b/sys/geom/raid3/g_raid3_ctl.c
@@ -425,6 +425,7 @@ g_raid3_ctl_insert(struct gctl_req *req, struct g_class *mp)
no = gctl_get_paraml(req, "number", sizeof(*no));
else
no = NULL;
+ g_topology_lock();
gp = g_new_geom(mp, "raid3:insert");
gp->orphan = g_raid3_ctl_insert_orphan;
cp = g_new_consumer(gp);