From nobody Fri Sep 11 21:19:41 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hhS9T2mcrz6rKmS for ; Fri, 11 Sep 2026 21:19:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hhS9T201Nz4SWY for ; Fri, 11 Sep 2026 21:19:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789161581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nI4CcjBFsm0cheTlV3M4445jbrvgh0/xy67EFhr/ysg=; b=TeXLsROFuwrP3zEyJEJlf5pAJ4K0vQgZOmDGaEaM5gukPmy4f+2bp1PrVD8/CYULy/k8g3 12nejeJR013VQ7WNTKFfByP3S/9fUm1PpUBwML4VLLiP7ncBkw6crADAZUqe/DBIcUIW5a s+iF5Xeym8XeIaUw8osJ6hgVefKaZz+yuyXZS1p/okxVPgo6ZosEgxWbvPcAfsUJds2vVj agod0iFO0Gd86lKIAz+bgB8ZceqgHasoNY/+Lj/2S0PQVKwoARTE/fs5NYg5QuRCP34MZK 0fFU6r6QhVxX6czWb8hgkMX2kHuYIHO34IbOKFvHfxdJIAN3TSxbuSk1EWE1tQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789161581; b=yc+3Tb/INQjAFX8XKAfDXFaMlM27hKdjw9PE6LO0+9BLk/qwcbJ5+09zBt/ulh69niQ2ai iAMTGNZfDufHbOXmDeNqwn6i5kk3tOo3b3E2ByByUXijHMzdzo1+7se9LO73xwmv3v7lws I6VXNv/3e4lW4MDStkqR+UTFnReVcf7gh2gicJgc89JQxFK+evXJmoi2+qSlUBTGJLG9Ya HSBtPZesaho24Z/0ZK3s1Lv1ixqih4CrgzVqNSNvhUznFBJlVgFiua4c6X2payjVPfpfKc yd9UUjmbI+L1sMKUE9npG+unPJTZJC1a8v/zLfSHqZ4wkLFJ1u4wRd79Lliwqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789161581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nI4CcjBFsm0cheTlV3M4445jbrvgh0/xy67EFhr/ysg=; b=P03TRrt/0lqBzVpG+HiTS92bydQedXTOmszh8NN3AdU8M25vZqzeIHNa95RaeaMr5/isLw 0PnZiRh3LcUM2aKuorHnptsoiDRLrI8n0um6cFWDlynXLlh1kauukACXB0JEbL0ka55ycm YoX/QO9Bl06YjtTfi79T1xIYf7hsstoKR+i2IQKNUlTLTxkf1AF+YuNu49Ku1uYLpWW75S A7uCUZ7Ug74eb+rcUkfvMWa+H22hgh5c9bn83hZlF8EVO68mSe/i+/6xYW/xVXHHmYnJNx txxajj12Sn/3hEYztKVTdBe0xR6kXuWWHS9IpQdalIdxP+lCFLDI8+uLwNxAVA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hhS9T13LCzSyv for ; Fri, 11 Sep 2026 21:19:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 34046 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 11 Sep 2026 21:19:41 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 3a4e037989f9 - main - ixgbe: Leave run-state publication to iflib during FDIR recovery List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3a4e037989f91672974eeedf1fa81ce0b684beb7 Auto-Submitted: auto-generated Date: Fri, 11 Sep 2026 21:19:41 +0000 Message-Id: <6aa4706d.34046.1b26debf@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=3a4e037989f91672974eeedf1fa81ce0b684beb7 commit 3a4e037989f91672974eeedf1fa81ce0b684beb7 Author: Kevin Bowling AuthorDate: 2026-09-11 18:56:17 +0000 Commit: Kevin Bowling CommitDate: 2026-09-11 21:19:12 +0000 ixgbe: Leave run-state publication to iflib during FDIR recovery Rebuilding the Flow Director tables does not initialize the interface or restore its queues. Do not set IFF_DRV_RUNNING from that operation: iflib owns the flag, and may have cleared it while a watchdog reset is pending. Restoring it here could admit traffic before the deferred stop and initialization have run. Keep the table rebuild and Flow Director interrupt re-enable unchanged. This path is conditional on IXGBE_FDIR. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/ixgbe/if_fdir.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/ixgbe/if_fdir.c b/sys/dev/ixgbe/if_fdir.c index 37f45cb3808f..dcd930518d01 100644 --- a/sys/dev/ixgbe/if_fdir.c +++ b/sys/dev/ixgbe/if_fdir.c @@ -53,7 +53,6 @@ ixgbe_reinit_fdir(void *context) { if_ctx_t ctx = context; struct ixgbe_softc *sc = iflib_get_softc(ctx); - if_t ifp = iflib_get_ifp(ctx); if (!(sc->feat_en & IXGBE_FEATURE_FDIR)) return; @@ -63,8 +62,6 @@ ixgbe_reinit_fdir(void *context) sc->fdir_reinit = 0; /* re-enable flow director interrupts */ IXGBE_WRITE_REG(&sc->hw, IXGBE_EIMS, IXGBE_EIMS_FLOW_DIR); - /* Restart the interface */ - if_setdrvflagbits(ifp, IFF_DRV_RUNNING, 0); } /* ixgbe_reinit_fdir */ /************************************************************************