From nobody Fri Sep 11 20:57:47 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hhRhC66Rzz6rHyp for ; Fri, 11 Sep 2026 20:57:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hhRhC4WxMz4P5w for ; Fri, 11 Sep 2026 20:57:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789160267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eG8bPtBNwtrXOqgb0pcEbH8Lp+DEwhEOUIB1pQJARk4=; b=PDSqkc11t/64k7CIuTNqyGODDhKQyFioFnxB4m+OPXhMRW578VZc2BmSZCB8c2zWvbglOd 2Y11JnapGcLy3XmKqo0FyhCnh0nu1MJyUjYyI9G37xW8nBlyQGcex78mN+vOO0ojUoZJMq AcRX/t7N/Pln7qMXs5K2NXuI//MUWiLAKrRnt8CX5skAKQRZ5BoDtc804ZSgIUufVuxitB b70ztBhVie8t6wIURNulX/ZHVk8QccAnlAfvstOu5AKP20SRgmaPhG5uchE/nhdUK9gqHI I1zKUZT5JCGahJOHil/XuWy3FBcsU7bYkOX8vrnajxn67Osu5oyarsDu8b4Rdg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789160267; b=XAIvCgGAR24EGKUfwua09k/ZmkenWws3G0Mx2RUt7KKYzGIWSju4UEbQpPdtdsRZOgZ7Vd Hzxg1ZBYY302f6TyKvcSHtTKzWbsQYkIqueNJ9VUHDEHZq5iOwAvTCugr7fKbl3KFaGIpq +fJPQX8n9uwiyP8gg24dfiWeKzsULwyMVQOGUc+BkFvdeD0pwbdBmuXb4EkWCsUOLDiUln AC0wo/donlHSNZq9MNmSFGxepKznAo5eztawpTag5qTk5J24aU4pfNT6mlVAsJV/X+c1u4 p+JZCGK/WrMus59UMMmcgTdTHH+FGrJ1p8TCUV0I8a+iuUgaNvg74WM4P0kccw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789160267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eG8bPtBNwtrXOqgb0pcEbH8Lp+DEwhEOUIB1pQJARk4=; b=PS1hYaT6C/vKtlY/15qFPJsgk40mu6qXRoLaNcivqBPzljb5Y1C1fkhpJUigYzMBJ5rUR1 iVhAsiEwkmY/EmghfQhIisRXtn5t08fJiFL3PTCfoeQyccH5dVpFegWm3Xzcnxx/GFfS3c UmPOwTDnc+OP015NpBiM7Q8VtuXOMv7v60Pwj/ukhiIsfYxiUHKyeyeVP6qftW6P5znMuX dZHoATW2Y2jU+UUwIwv6xG8OTF1vDggRKztf1fMlQw2czOVnYod5w+RWn9sAPMMO8FYh6o 8Yekk8353GGxT59WgPpPO9LoCzRxKIKpGUcBtq9qtFNWq5DeFwl1XRbbeFsIQA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hhRhC3SC5zTGn for ; Fri, 11 Sep 2026 20:57:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31d8c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 11 Sep 2026 20:57:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 372803d65d24 - main - ixl: Set critical-error state bits independently List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 372803d65d242b308abd6b312a40ff6987fc3452 Auto-Submitted: auto-generated Date: Fri, 11 Sep 2026 20:57:47 +0000 Message-Id: <6aa46b4b.31d8c.43e62bcb@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=372803d65d242b308abd6b312a40ff6987fc3452 commit 372803d65d242b308abd6b312a40ff6987fc3452 Author: Kevin Bowling AuthorDate: 2026-09-07 13:36:06 +0000 Commit: Kevin Bowling CommitDate: 2026-09-11 20:46:33 +0000 ixl: Set critical-error state bits independently ixl_set_state() takes a bit index, not a bit mask. ORing the reset request and critical error indices produced the global reset index, so a critical interrupt could mask its cause without scheduling the intended PF reset. Set both state bits explicitly. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/ixl/ixl_pf_iflib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixl/ixl_pf_iflib.c b/sys/dev/ixl/ixl_pf_iflib.c index 90fc85198523..723b5b635220 100644 --- a/sys/dev/ixl/ixl_pf_iflib.c +++ b/sys/dev/ixl/ixl_pf_iflib.c @@ -201,8 +201,8 @@ ixl_msix_adminq(void *arg) /* Checks against the conditions above */ if (reg & IXL_ICR0_CRIT_ERR_MASK) { mask &= ~IXL_ICR0_CRIT_ERR_MASK; - ixl_set_state(&pf->state, - IXL_STATE_PF_RESET_REQ | IXL_STATE_PF_CRIT_ERR); + ixl_set_state(&pf->state, IXL_STATE_PF_RESET_REQ); + ixl_set_state(&pf->state, IXL_STATE_PF_CRIT_ERR); do_task = TRUE; }