From nobody Fri Sep 11 20:46:20 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hhRR04hVfz6rH6q for ; Fri, 11 Sep 2026 20:46:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hhRR03ByFz4N3H for ; Fri, 11 Sep 2026 20:46:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789159580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9RZxdkGRaSb4Yfe6kVig2kIZYiuirvsFUSjfvzzuJ0Q=; b=g8qCh6InXK+DNoWc2gdsCwSvL+RXE3NxQj+XCxIzy40ZqgeBykT9990exeiFIiD+WC1YgL fvnk2OWFKptc1S/dMEbnnC9CNOjb57DT1UqKbUlItEy6771sTY4Y2TR7paMKyWR/Ki+ndi EQdjvV5iBWZvkE4l7TQqzPvhuJ65NmNgQmTA2Glma0fdMj9GSw1EBz2JtaYD+rlnGPxiv1 yNM5l02JjcqciT1Iu+mNWq0YcKBNJTLptQ1RdKtIOr9GfPbEiB/Y3Aphx3P5Nlda19Uh4r G4sWefGZ0WQY9SYonY7zSrqCCiomrfMM6oO7Ua9RCCJ3fW/bRTj7jroC480Fug== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789159580; b=tkavVxpz2D1C0hoZRgW8gZ6HeSkSWfu53IGgDy9Ga5CXynJA/mZdPrVWhAPfm+xewopWGr ypcZXmP3pQuJrlR1z1S/VpI7Cu6gcGaFM8Kkd+cPzWBbLMZiz5Kk/h19xL0bG48tuo6OEM yna6l1IDb3eH8EIZg5vgvy99i8S66xKGIDh/1fU5NS6SQMlCrwHBX1oP5Qa41UU9SkrFfT gL375rlr22gSNTmHFNX6PJoP6ayoPlXUMHE6lvEoAPl4D1VI/hQw+hqptf8OPAUfl/YH9z Wlfa8XtbHnbFuLBKTeMgDB//6/bmkNhuUrjObC5Bp1D+7Z4Vb5nwquP57k6xRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789159580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9RZxdkGRaSb4Yfe6kVig2kIZYiuirvsFUSjfvzzuJ0Q=; b=c9bu+zTyqfVVPAP1Zmv/YHcG4zrR1w/pmr0SFiaHrgJaSUYl6NXXviS4CYb2v+6+Db5zVY MmbaghqgR2f+t/tWnjeiU+rD38ouy+BiDTYJ2f9r0KZ3Kc/fd0e8ruekFOH8s8jUYrXU8R BntApf9+uyR40037tz5S6eMy7jnlufg6iJUxt1rH2xlBq7icCxFCf/vWyBiC9W3Q8oP/+a BIE+eeln5A+MhC1H7AUPrWVQH0jK5MpTlFhRUCt5AKhLCuO8owd7CJ9ys0SjmI2g0DHiV7 lpDvWs8ZmJJ8q0wNewg58koW43wePjYU0YzFnwGGVwAaEMKubOOy25LixyojTw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hhRR020pFzSTc for ; Fri, 11 Sep 2026 20:46:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30b91 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 11 Sep 2026 20:46:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 99eaf07a3cef - main - vmxnet3: Propagate device-enable failure to iflib List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 99eaf07a3cef77e61423e9431c0a8c5fd4d4be58 Auto-Submitted: auto-generated Date: Fri, 11 Sep 2026 20:46:20 +0000 Message-Id: <6aa4689c.30b91.414a3f61@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=99eaf07a3cef77e61423e9431c0a8c5fd4d4be58 commit 99eaf07a3cef77e61423e9431c0a8c5fd4d4be58 Author: Kevin Bowling AuthorDate: 2026-09-07 11:55:12 +0000 Commit: Kevin Bowling CommitDate: 2026-09-11 20:44:07 +0000 vmxnet3: Propagate device-enable failure to iflib Do not let iflib publish a running interface when the virtual device rejected its enable command. Mark initialization failed and leave the interface stopped. MFC after: 2 weeks Sponsored by: BBOX.io --- sys/dev/vmware/vmxnet3/if_vmx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/dev/vmware/vmxnet3/if_vmx.c b/sys/dev/vmware/vmxnet3/if_vmx.c index 744205ef0e7d..3409f80a7919 100644 --- a/sys/dev/vmware/vmxnet3/if_vmx.c +++ b/sys/dev/vmware/vmxnet3/if_vmx.c @@ -1943,7 +1943,10 @@ vmxnet3_init(if_ctx_t ctx) vmxnet3_reinit_shared_data(sc); vmxnet3_reinit_queues(sc); - vmxnet3_enable_device(sc); + if (vmxnet3_enable_device(sc) != 0) { + iflib_init_failed(ctx); + return; + } vmxnet3_reinit_rxfilters(sc); vmxnet3_link_status(sc);