From nobody Thu Sep 10 20:58:22 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hgqlL347Qz6rLy6 for ; Thu, 10 Sep 2026 20:58:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hgqlL25vTz3MxF for ; Thu, 10 Sep 2026 20:58:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789073902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3+lQ3ip5TSMF87P571zH3gqabqv9ReIKkkBTGWDLFRs=; b=CvGEwOjmA64uKohDsn3v7AuHicDmH/m70pWXcyGtVXgbc557sNFAd+A7MqzQq13TPHuX+Y V1Ycwk2sU5hGCs/Rlgi5cR+153ursB88QX9a7miKPsafP8OYqW921J6d1wS01R+ersdSA4 stlrPES6Yg2KL/6nAupbAsS0J13P+6xQbLO8W8EyWGf6FwYe7vGLNcgkWd7GZvInKG4ayU Oma2Yi03zqsf6U8Vneu6/l6xK1siaw9l52Z4Ia2u4Wm5xsm+hgZUbmt4cmUI0ycPxt+IXd yuw5LYsWXP1uSHRQDawpKdW/GQSxT4DgRQWvhqP+AYF2Z1fQOtcIxIL0LhUPZw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789073902; b=IRzHBusDC8d0eK9XHQ7c/9BEuJYzQouvfLK8wAjCg/YK7g5YHEp1Xib2JO/taZIlcW7W1c fK0RDSN6YAaXlzI0xZUmTnAuJHrlt10Y9j1UmKasEg01XqwBKekmH79rNkRZHOMncMiB9Z 4wm4QDHZofaWyaG739PJ9Jnvn9xeasM2szy6u4gdCQlzp1ZDlCLaymyOvAG5InUKpMDl4X XfDDR96rR3Yb4TmU/CKpmHocJPlvVy8XFoHZ2BoXM7CNZO+ipEAKCNNILhgRxcrZmgHFrV CxbI84m3YwobG+G0NMY9ajYhbrLOPfnaA9dPNs8hpbpfyRbj8F5Wzzq4YM+F3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789073902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3+lQ3ip5TSMF87P571zH3gqabqv9ReIKkkBTGWDLFRs=; b=ZelCI9bFEPKMte4yj/TlSvnDcM6UjBbCIzaAZ9Mb/2ieVj8AazYNWcN5ep4f3dL1gS1HbT 1dE/YxFo8Ay7UamDvKsUcbm0UIg5X4X5m2sV/IwZNlb1m0pYw4GxwZ/cUbO4srflkGDCPv lGkxGhBpX2sFiVnNMoKGxUQBSMubLigeZXzLXyzTToFsjElJ6VLkwfxrcSOWN9FJRrsG1B sZpErvHs/BwFElkDCIWJ8iVbPjGSHcxwuMVkFb/TVgtWju6qH2aa5sStk5gI5grjgyijz6 /ySOsB+mcvNDu8aJaPmr/koyhigQbrJMnOK/UM+VNXshdGECkbLPvsjZtt9bSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hgqlL186wzlDG for ; Thu, 10 Sep 2026 20:58:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27a15 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 10 Sep 2026 20:58:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Aymeric Wibo Subject: git: 542df51903ae - main - acpi_spmc: Make sure constraints array doesn't end up sparse List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: obiwac X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 542df51903ae57c5a5f271949a45ebcb1362d9b1 Auto-Submitted: auto-generated Date: Thu, 10 Sep 2026 20:58:22 +0000 Message-Id: <6aa319ee.27a15.2e1f3dca@gitrepo.freebsd.org> The branch main has been updated by obiwac: URL: https://cgit.FreeBSD.org/src/commit/?id=542df51903ae57c5a5f271949a45ebcb1362d9b1 commit 542df51903ae57c5a5f271949a45ebcb1362d9b1 Author: Aymeric Wibo AuthorDate: 2026-09-10 09:34:31 +0000 Commit: Aymeric Wibo CommitDate: 2026-09-10 20:56:37 +0000 acpi_spmc: Make sure constraints array doesn't end up sparse If we skip one of the constraint package elements and decrement sc->constraint_count, sc->constraints would end up sparse and some of our constraints would be put after sc->constraint_count. Reviewed by: olce Sponsored by: The FreeBSD Foundation Event: EuroBSDCon Devsummit 2026 Differential Revision: https://reviews.freebsd.org/D59562 --- sys/dev/acpica/acpi_spmc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c index d4d13d57d36e..8691354ff4d9 100644 --- a/sys/dev/acpica/acpi_spmc.c +++ b/sys/dev/acpica/acpi_spmc.c @@ -632,9 +632,9 @@ acpi_spmc_parse_constraints_intel(struct acpi_spmc_softc *sc, ACPI_OBJECT *objec * iterate until object->Package.Count so we actually go over all * elements in the package. */ - for (size_t i = 0; i < object->Package.Count; i++) { + for (size_t i = 0, j = 0; i < object->Package.Count; i++) { constraint_obj = &object->Package.Elements[i]; - constraint = &sc->constraints[i]; + constraint = &sc->constraints[j]; constraint->enabled = constraint_obj->Package.Elements[1].Integer.Value; @@ -668,6 +668,8 @@ acpi_spmc_parse_constraints_intel(struct acpi_spmc_softc *sc, ACPI_OBJECT *objec constraint_package->Package.Elements[1].Integer.Value; constraint->min_dev_specific_state = constraint_package->Package.Elements[2].Integer.Value; + + j++; } return (0);