From nobody Sun Sep 06 16:57:28 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hdGbX38BFz6rNx1 for ; Sun, 06 Sep 2026 16:57:44 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hdGbX1Bjyz3DhZ for ; Sun, 06 Sep 2026 16:57:44 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-6b613d3e19dso2811128eaf.1 for ; Sun, 06 Sep 2026 09:57:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788713863; x=1789318663; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=8NlOb9teCcUoieWs8pgG0+ce+c/Lh12lXe8HCZLuTXg=; b=ajYTwHZ3NGiafuR+1tr33PME03UdCh9vfmfZ15wLMYDjt4LB9LueUwdQTwVDLig8M/ RU+vPe2QmZhAws0KX/kYrYlfay46Yg6GpjBfSgV1M9L3XibZIgSGHAV0FEvNDHEMxWIV lrU0vHQi6cK+qTJfmkpsc19S2/JrHee6CJIwXUDdKItBpNGFtbGQbY08z6sdmPd8A/IE xNtV30Ck224UaxyqXIkhEH3SNHeTDMm1L3+chCwUnPsP8hX8JkfheBipAEhf0RL6TeF0 LRihlYWi7L2agfJsrWbdBSELHoNhd0F4X3o1p9RBjUtLpZjDbKjx1VLUby+Eu6eZaVSu VzeA== X-Forwarded-Encrypted: i=1; AKwUvBwGkLetbWvs4EuMWSD0HdaYU+UlHWdQUGHFnNhrwcQc+vIJFYjahUVZctPdOHr5oktluegQ+xHa4qWXkeFy0eRQwl8W5A==@freebsd.org X-Gm-Message-State: AFuF++kZ4v0DtH2Pb9I78kr7KFQ+SugBeoREVVmh8uLf4xKg+A9KqG4l bWDBPQefjqbqMkTGzuhhUZxc2cGMykeslxj1jTqAQHCuog8qP0+nku772n8Q1kCV X-Gm-Gg: AYBFou29ZcGmUqxbOWZ2hs4lnTDd3pcFjMRvsd7NYwUYq0rIT7I7x4JPJeCEMnRTvse OXAm2xQBtQqijY2Qvi+EboPBRlWABapse32NpJ1d+4/MKpy2LT5B90kiF7pcspU/QwbsjQtvIPt QCQ0+sDyfN+DXODHmq1vF3/fxwmpZqexKqU8Eon82zNgZfLPZp3DF78x1Cspk3w5CJyQMbIRZ2r lSvBWCXiumMBgcKJrwpM6yaI6F7QSnOehUH32vsFJ9wLSsLnp9uKkZht9hBCPSmrLsjQtLMDcWh GKmI8zpKl7YljTvEzz2z5JJsf84s/p7FprIiV4GjJXc71qfD+NYR6bz6RaOCYAh3i97nVFSbxho JKUvAhzwxxh70TogWh6x5l+08+AHmH51idXuLLo5McSwFyevi42qvfkIoJYAjsOT+q3drnKptSc +gGBMaS4v4XlNDV5IQfsKKgdl8YmPbCbWte20I6RNyOP96uSo9yJI1KgiWmKOaCUW/KbRy5jFA3 2yrsG+a7SfFpyS6hS7cnENolkO+aq4mvltouCfWxE8yIyDIIlgSoMfi5dKN X-Received: by 2002:a05:6820:290d:b0:6b5:ec3f:4985 with SMTP id 006d021491bc7-6b72034e9e3mr6221802eaf.32.1788713863137; Sun, 06 Sep 2026 09:57:43 -0700 (PDT) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com. [209.85.167.182]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6b6dd57198esm10746505eaf.11.2026.09.06.09.57.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Sep 2026 09:57:42 -0700 (PDT) Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-4b1ba286f6bso2715975b6e.1 for ; Sun, 06 Sep 2026 09:57:42 -0700 (PDT) X-Forwarded-Encrypted: i=1; AKwUvByaNNYe0PRHVAPXA0bns3KSvcnkZ2Ft3b0SgZXPfn5aak6mKscl0894lphCFQctkpI6YiHyR989PNw6MkT8hS4HlZTPMA==@freebsd.org X-Received: by 2002:a4a:e914:0:b0:6b5:ec2f:3565 with SMTP id 006d021491bc7-6b5ec2f36bfmr9360099eaf.22.1788713862363; Sun, 06 Sep 2026 09:57:42 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a9d86a4.3ebe2.654627bc@gitrepo.freebsd.org> <1179D554-F68B-4F01-AB16-FC7D741996BF@gmail.com> In-Reply-To: <1179D554-F68B-4F01-AB16-FC7D741996BF@gmail.com> From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Sun, 6 Sep 2026 18:57:28 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AcwNN1XOD1aI6qkPQIEX_WFP-EvGpEacBDGy2x8gB24v_VVS3h-2eO2oPPlgHeA Message-ID: Subject: Re: git: fc002631af3e - main - whereis(1): Respect PORTSDIR variable To: "Enji Cooper (yaneurabeya)" Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="0000000000005f014c065ad3664b" X-Rspamd-Queue-Id: 4hdGbX1Bjyz3DhZ X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Spamd-Bar: ---- --0000000000005f014c065ad3664b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Sep 6, 2026 at 4:49=E2=80=AFPM Enji Cooper (yaneurabeya) < yaneurabeya@gmail.com> wrote: > Hi Fernando! > Apologies for not being more explicit when I provided a ship-it > earlier in the differential. There was a style(9) bug introduced with the > change that should have been fixed pre-commit. > I=E2=80=99ve highlighted the line below. > Thanks, > -Enji > > > On Sep 6, 2026, at 8:28=E2=80=AFAM, Fernando Apestegu=C3=ADa > wrote: > > > > The branch main has been updated by fernape: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Dfc002631af3e25c65d74ca6869c13b5= 9f1af8689 > > > > commit fc002631af3e25c65d74ca6869c13b59f1af8689 > > Author: Fernando Apestegu=C3=ADa > > AuthorDate: 2026-09-04 18:27:34 +0000 > > Commit: Fernando Apestegu=C3=ADa > > CommitDate: 2026-09-06 15:25:59 +0000 > > > > whereis(1): Respect PORTSDIR variable > > > > Respect PORTSDIR variable for those who have the ports collection in > a different > > place than /usr/ports. PORTSDIR is a very common variable used in th= e > ports > > framework and in /etc/make.conf among other places. > > > > While here, remove and old reference to CVS. > > > > Reviewed by: delphij@, ngie@ > > Approved by: ngie@ > > Differential Revision: https://reviews.freebsd.org/D42156 > > --- > > usr.bin/whereis/whereis.1 | 4 +++- > > usr.bin/whereis/whereis.c | 38 +++++++++++++++++++++----------------- > > 2 files changed, 24 insertions(+), 18 deletions(-) > > =E2=80=A6 > > > - if (stat(PATH_PORTS, &sb) =3D=3D -1) { > > + path_ports =3D getenv("PORTSDIR"); > > + if (!path_ports) > > style(9): C code should test for `=3D=3D NULL`, not boolean false. Should be fixed now. Thanks for the heads up! --0000000000005f014c065ad3664b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sun, Sep 6, = 2026 at 4:49=E2=80=AFPM Enji Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote:
Hi Fernando!
=C2=A0 =C2=A0 =C2=A0 =C2=A0 Apologies for not being more explicit when I pr= ovided a ship-it earlier in the differential. There was a style(9) bug intr= oduced with the change that should have been fixed pre-commit.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 I=E2=80=99ve highlighted the line below.
Thanks,
-Enji

> On Sep 6, 2026, at 8:28=E2=80=AFAM, Fernando Apestegu=C3=ADa <fernape@freebsd.org= > wrote:
>
> The branch main has been updated by fernape:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3Dfc002631af3e25c65d74ca6869c13b59f1af8689<= /a>
>
> commit fc002631af3e25c65d74ca6869c13b59f1af8689
> Author:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBS= D.org>
> AuthorDate: 2026-09-04 18:27:34 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBS= D.org>
> CommitDate: 2026-09-06 15:25:59 +0000
>
>=C2=A0 =C2=A0 whereis(1): Respect PORTSDIR variable
>
>=C2=A0 =C2=A0 Respect PORTSDIR variable for those who have the ports co= llection in a different
>=C2=A0 =C2=A0 place than /usr/ports. PORTSDIR is a very common variable= used in the ports
>=C2=A0 =C2=A0 framework and in /etc/make.conf among other places.
>
>=C2=A0 =C2=A0 While here, remove and old reference to CVS.
>
>=C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 delphij@, ngie@
>=C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 ngie@
>=C2=A0 =C2=A0 Differential Revision:=C2=A0 https://reviews.fre= ebsd.org/D42156
> ---
> usr.bin/whereis/whereis.1 |=C2=A0 4 +++-
> usr.bin/whereis/whereis.c | 38 +++++++++++++++++++++-----------------<= br> > 2 files changed, 24 insertions(+), 18 deletions(-)

=E2=80=A6

> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (stat(PATH_PORTS, = &sb) =3D=3D -1) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0path_ports =3D getenv= ("PORTSDIR");
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!path_ports)

style(9): C code should test for `=3D=3D NULL`, not boolean false.

Should be fixed now.

Thank= s for the heads up!=C2=A0
--0000000000005f014c065ad3664b--