From nobody Sun Sep 06 16:49:24 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hdGQL0K52z6rNZt for ; Sun, 06 Sep 2026 16:49:46 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hdGQK4NPnz3CSv for ; Sun, 06 Sep 2026 16:49:45 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-2d715f4a587so39464275ad.2 for ; Sun, 06 Sep 2026 09:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788713379; x=1789318179; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:from:to:cc:subject:date:message-id :reply-to:content-type; bh=mgEDdL9Loie0YcBKp+HhVegpZqjvPN/0+1ONtnSy37M=; b=rlI/IW2f/tkztsG1yse0JYdseBRcMmdq84pgQzWv+sqBcD5ea9H6kyuS/r6izOYJxe H2odZKYPpDpgvit0pK3WxA4pxX85qP2ujGJhcVHSHH1rHE5WGn3Nrn0o0qjhcwtnrlm/ grWam7D3X2/pjRc33/MjdlLgcz4AJsMfmKDvTrm1hOSi8HtjdczR/qMFfQFa1p0BdXej rRrstVhMhWJZdKyhxcNigTBseEt1qxd1IUkwG2TFrHup7D0H56wQQUkdgEwRx3Dq7YsE ESocMVI3frJjgAXjpwqSWfUcbhOsWMdflcdaM2BxkP+kX5iVZB1fSNU3B/zmxJzk7zY5 82zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788713379; x=1789318179; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=mgEDdL9Loie0YcBKp+HhVegpZqjvPN/0+1ONtnSy37M=; b=TlN4sxQy8+f0boh6enKBE0YQYV9S7uUXvdjJQZ4olSaLx5RMo43jOZ5XEJ9y3EwzfR duHFY/mrKhWvnoeULctDpNMnV3xz1xTHUfKG6rzxUs4ZU7Xq8SG9bEbBpnTG+BGWSVj3 HQXGrIp+2KoAFgEf31KiwWpklLhzC3Cfj83bAFL/TKzyGBUpuQf5XNdL16XIX+VJUk5z SwWtQ3du5P/v5Qab+rq1hHf8AD7gXMSqRKuxb03oea70FG9Irn3yo9oypPX/O3TiDcbC GI14za7jcbw+MyiYqPtMTHFp2Wte9O4gGIuPy7HFOhGuxrHzie97wucv6YnDD2c2DFtJ Vz8A== X-Forwarded-Encrypted: i=1; AKwUvBz0vGJtCxZxwvLyz/ZlgeC0ax8YbIImV832fZBYLJZ5GpAj+/x/AoiQObBwEowaAF2RPdMU6y/QDI4yGTwozeewTQVmwg==@freebsd.org X-Gm-Message-State: AFuF++nMnCfv/ZqxuUPcEa57HmTIiww7N5cIBxN2C7oskvT6qup2ZUIC A17TcpBQv/g0rnzIAbdaid2yOhZcVj2EB3Ay1IG2R2lEkWsV2EeWL/q7srvsSQ== X-Gm-Gg: AYBFou1h+J4vouNe/bg0UXrYVgqczqkMSFis01TOHV85GEaVcZG1n2rHt+CBYeOBv1R iUl7dmwIn6yjiIEUR3NeKTyQQ6j5TcZyMj54ePFGDaqRJTdZjf3hfxbGoAIgzqBhKhrTdDUw7Xi wtlWBW1RxlmGHlmP+vTHL6TPICPP3taBvw7bKmIK7LC+ZuqWYU1yPC4595bjaxYPLAZfmJbZfNr lNtBaYALqb/K92aVA0FP1kgiAvBKRzIBowe/ho2adC7mDpFu4VOkbvkjqPLBMJlGKvwFmzmFVBM D9lHm5qo4Nh4vHLjb7TdLt2ThxJNdSI/MbxueDbXsWqW6oqHIKs8kPiU4ifKUUGzFIQsnr9eiDY 2IN9hqK/qU2fKsAeklghuDY9MIGpj9IPIz3hgWcEihoKDKGBmh7dL6Viat5h7mT/EME6t/3ob8E /xfgbnWppNu1d66LpT86+aYyxH9DLx/QhPGku42KtJ9eOA1LSJKNFtMBQR+K0IdanLtQ4YeQ4tv unabg+39TU/G1q7qvCrdgM= X-Received: by 2002:a17:903:198e:b0:2d9:383a:30f1 with SMTP id d9443c01a7336-2db125ce07cmr308642265ad.4.1788713378967; Sun, 06 Sep 2026 09:49:38 -0700 (PDT) Received: from smtpclient.apple ([187.15.154.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2db146b9691sm34170815ad.0.2026.09.06.09.49.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Sep 2026 09:49:37 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_DF4906E5-C15D-4C54-9EC1-1E06D3CB5B8A"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.1\)) Subject: Re: git: fc002631af3e - main - whereis(1): Respect PORTSDIR variable From: "Enji Cooper (yaneurabeya)" In-Reply-To: <6a9d86a4.3ebe2.654627bc@gitrepo.freebsd.org> Date: Sun, 6 Sep 2026 09:49:24 -0700 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: <1179D554-F68B-4F01-AB16-FC7D741996BF@gmail.com> References: <6a9d86a4.3ebe2.654627bc@gitrepo.freebsd.org> To: =?utf-8?Q?Fernando_Apestegu=C3=ADa?= X-Mailer: Apple Mail (2.3864.700.51.1.1) X-Rspamd-Queue-Id: 4hdGQK4NPnz3CSv X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Spamd-Bar: ---- --Apple-Mail=_DF4906E5-C15D-4C54-9EC1-1E06D3CB5B8A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Fernando! Apologies for not being more explicit when I provided a ship-it = earlier in the differential. There was a style(9) bug introduced with = the change that should have been fixed pre-commit. I=E2=80=99ve highlighted the line below. Thanks, -Enji > On Sep 6, 2026, at 8:28=E2=80=AFAM, Fernando Apestegu=C3=ADa = wrote: >=20 > The branch main has been updated by fernape: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dfc002631af3e25c65d74ca6869c13b59= f1af8689 >=20 > commit fc002631af3e25c65d74ca6869c13b59f1af8689 > Author: Fernando Apestegu=C3=ADa > AuthorDate: 2026-09-04 18:27:34 +0000 > Commit: Fernando Apestegu=C3=ADa > CommitDate: 2026-09-06 15:25:59 +0000 >=20 > whereis(1): Respect PORTSDIR variable >=20 > Respect PORTSDIR variable for those who have the ports collection = in a different > place than /usr/ports. PORTSDIR is a very common variable used in = the ports > framework and in /etc/make.conf among other places. >=20 > While here, remove and old reference to CVS. >=20 > Reviewed by: delphij@, ngie@ > Approved by: ngie@ > Differential Revision: https://reviews.freebsd.org/D42156 > --- > usr.bin/whereis/whereis.1 | 4 +++- > usr.bin/whereis/whereis.c | 38 +++++++++++++++++++++----------------- > 2 files changed, 24 insertions(+), 18 deletions(-) =E2=80=A6 > - if (stat(PATH_PORTS, &sb) =3D=3D -1) { > + path_ports =3D getenv("PORTSDIR"); > + if (!path_ports) style(9): C code should test for `=3D=3D NULL`, not boolean false.= --Apple-Mail=_DF4906E5-C15D-4C54-9EC1-1E06D3CB5B8A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmqdmZQACgkQGpE5DjPs NJiqnw//R0KJKY0xeBh1ORyZy8zBJbwAv4mLvCZIMSA8opx3FbPSHsVRveyAxHOI jAt69vZALEVG3d+cjDPFWMKfl8UL6o55arjpIluktud0Ne98S3uko4c5pzeznDJW 8tsUBAVzxSSvtI2hUpogwt8CyAoY4uaObyBMKyRfQlFRNyKIpRhU9yq98O7fI7JB 5PlidQNETxNJO0ZFSsH3CXIUGuQV+lHXxcrGHnLL2uM1bCvsVyTDBCKrdIsSQYmm UrcKDA/yPovX8z8ddo5ZUZtX6qs6P7rB6OHdnR4ltgVeMaGmVcOIqVAnvbtvpN6h +PP9MXD0BA7sdoLDtQmT5qUPbwECpd2+BOW/rcPJWV2jQcc/LNiTKy2vfypgFHEI NtH54EwOlCAmkzsAYk5gYtFzGRk3HcK09M9xxh52W2yD5RZRFswe/MMDQtCskb/Y 4Fg6UEu2f/RuQnYfL2B+KvMGGSWV2JTsBQz0tV/kf5dJJtu0nL/n0gFOUGjnRmvK Q2PRa/xipaC/IZOwHd5W8VPfSRD2j+VmYVIQfooLxKIdiLbmLsNn1pkI5GgNEwX1 tkLckQqBcdXvgVusrw6RZ7DKUh+NE5mLFH8Y4XbiIiAntngdhEeevUqzQQX0/AHM AbBIwPNDaHbxpgpEWfqWA6srQFzoShdwUFs8o5A+mUAVAy7yDnw= =lmBo -----END PGP SIGNATURE----- --Apple-Mail=_DF4906E5-C15D-4C54-9EC1-1E06D3CB5B8A--