From nobody Sat Sep 05 18:06:07 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hch8w10Cbz6qvKD for ; Sat, 05 Sep 2026 18:06:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hch8w0WzTz3NZR for ; Sat, 05 Sep 2026 18:06:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788631568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L1dQtiZMc/HD9fvlU0KBs/udwgCJABzuEcxZ8TbEAq0=; b=j5Z7ifw6Exe2nepk0veasOQxRFk3+hDBcB6EhJsiCWBiXsQ9WUhNrH0WWYKxPJVmLQRaaF sm8s/hMvbZWpbhndaXVd2CXbKBMIeKbhG7RgxE87U2eTEuuuF/SiSGBaKI6TX2Tyme4mWR xJI9PAaf/1GUEdCeNmMuZ0upUvWlecIE035sNYmUzG5W3WDKaSR3kNTscxsecs6tPB2seg SSJQ/oKT7jLEFJkcUVokoa4K7dLrDmZpWG5stFOHHa0e2wZ+ksseXWqx1lGcyF+pbmZgJW 6qrIxV0exnGEFgVQ3bES6VbsOmaoSEE4TkYagVMvqxUOldWhPa6c5BdTQI50WQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788631568; a=rsa-sha256; cv=none; b=QBwIgKjBBLQB53LgBQdMH51XSGXDCHWSPpjsUE7P1yUB9h+LRzRFt4BgRrpQpMCmw+R2Fe 2FjvEE1AYrPz/HM07A6ROrmOcpkt2Nn4Rp6p7ekj/4uda+yaXlkgk3hsD/kClAdqmPrB8K MlGzFxaFZudU8yvUMAyLB5S3WmDcHMUJoAzYWxHumG7p3b6iY6f3P2gcMlpmy8TD2BWwvz K0IJEHHG1UrfyZSGW05CfpxYEMPJolbTnaa/UMNsp0hw/WirYU9LL955As1Qw19bytYnLq 06bYIhOHSev2iV2+Dx2Si9YtBIy2PVbG/YCGcY59QTW9QW0dzAFzrug//DLARw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788631568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L1dQtiZMc/HD9fvlU0KBs/udwgCJABzuEcxZ8TbEAq0=; b=URKvwTR/JKJU4QKMlOxrcq6gv9ZLu+ucoMh2zYePhgH2S1cnHjMqziVhgIGhYoIUOwBRe6 ZRy0cmAbLOCDBku1bU+hklqXQ4/eCzTKGzIj/zzfuQ0JP6l6U4MKpf03cLxk4OesJ6+DEv vZF+3xL7rywyAVuIPmBa2Fl00IL0XA6rSQJvp6izcgWnToTYdoIAgKYhZxiLp6SRo6+oV3 igO8k9Iqrpz9bd2vk9RVACMs6X6DO7fVhMb4UJuUFYeK2iI+6uXtY+J42jqHbVdPvZL+Z5 7zLk0lS95BzkB/24NTUKPCrtm4Jmy0FxIOK0z1A+Li0tbWkpUmEMi67UbSfsdQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hch8v66crzvts for ; Sat, 05 Sep 2026 18:06:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1fe15 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 05 Sep 2026 18:06:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: d13ee10b7714 - main - random: don't collect entropy when scheduling software interrupt handlers List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d13ee10b771493ba8fb6d12350240ba7deb26d8e Auto-Submitted: auto-generated Date: Sat, 05 Sep 2026 18:06:07 +0000 Message-Id: <6a9c5a0f.1fe15.8944214@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=d13ee10b771493ba8fb6d12350240ba7deb26d8e commit d13ee10b771493ba8fb6d12350240ba7deb26d8e Author: Gleb Smirnoff AuthorDate: 2026-09-05 18:03:40 +0000 Commit: Gleb Smirnoff CommitDate: 2026-09-05 18:03:40 +0000 random: don't collect entropy when scheduling software interrupt handlers The entropy will be collected in intr_event_schedule_thread() for event handlers that are marked as entropy sources. The quality of entropy provided by SWI wasn't great anyway. Reviewed by: cem, ngie Differential Revision: https://reviews.freebsd.org/D58829 --- sys/kern/kern_intr.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sys/kern/kern_intr.c b/sys/kern/kern_intr.c index 1280c2d85277..cbcee88a2926 100644 --- a/sys/kern/kern_intr.c +++ b/sys/kern/kern_intr.c @@ -1076,18 +1076,11 @@ swi_sched(void *cookie, int flags) { struct intr_handler *ih = (struct intr_handler *)cookie; struct intr_event *ie = ih->ih_event; - struct intr_entropy entropy; int error __unused; CTR3(KTR_INTR, "swi_sched: %s %s need=%d", ie->ie_name, ih->ih_name, ih->ih_need); - if ((flags & SWI_FROMNMI) == 0) { - entropy.event = (uintptr_t)ih; - entropy.td = curthread; - random_harvest_queue(&entropy, sizeof(entropy), RANDOM_SWI); - } - /* * Set ih_need for this handler so that if the ithread is already * running it will execute this handler on the next pass. Otherwise,