From nobody Fri Sep 04 07:29:14 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hbp4W1D5Qz6rD9q for ; Fri, 04 Sep 2026 07:29:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hbp4V6hlhz3kg0 for ; Fri, 04 Sep 2026 07:29:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788506955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pQD0h3cBssi8oYeZBuxDGDunJ4xxDgFWxGtHZ/HNKzw=; b=d6nxE2Od5oRRpayodt8Rv1S4vKKTwSTpfqbRuNaAh8iRYWG+p9r025D8iOjZrd1czxIzSl GfJyiM+idVjvGOuhmOFONjQ8h6h0H2bH9KalvNQ0FTxsFqIoIG5m7PRIaBypVHM2oXqLK9 vpmXzv+n1PQc0FIgv9wj8M2BEIaBILpzJOVRi513ki6EuJsow5R9LX6HXJgQAlr5SzjKnB xdSK7NaXlF6ADlNJxEixF3awBYHL2zSdI4bybMYKPzUbIqxG047xwsZNNAHKgYi6EWzKTH spwgPs1yp5FZl7UpsLlW3NMZEwMXkOP8kdeeZFkd8tDEPboumS1Yp1AOlY7oPw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788506955; a=rsa-sha256; cv=none; b=Kkg75s9tU1W2gCJ1utEFUovgXGTLVwl79bT9YFsBtjds4/BetxDFprAKKRpj1WtzOWCE/3 INy/zpnINmaKLDdwhvjsKduaKJTTDlF64iw0rnGy/ImhJm0SfyLchWVyKtFvmOMsbSXpqE bvA26nWtqUrRLJMYqeCvlL110O2uHpzzyGyQ83uPVNec/O0Qdcva/cgZDF1cMdW9BJ2Wm6 Riw3C8OJ64VI/sa87A540Glp/iF7dzjbObhHBYERAz5/1QoBJxpwNE+skpVBekRMp8/dhR 7FhCLfCSRz9QmNtWKmTwUiFchO+cNKaRqyfQGENz3f44uIfwELWnA+QhtmANlg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788506955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pQD0h3cBssi8oYeZBuxDGDunJ4xxDgFWxGtHZ/HNKzw=; b=iUMtYWa43eQM/8n80FIwN+YdqVwL+78CJKfqXBnd5QDpFKvMozSgu2MgVFQNnVPK4HitXC Gr3tTqth4k8G4JdeEHcewGANWVf2d+o6pJYlt06pdY1E1wKIgtDaHaju2rEvcyzGYk+nEo R2aIuWYZuFuGGzXaSUGIl9fdICE7LHjLVyrotgveTK3U7QMZZylGeIk+joO4dxLfiExlPH GeWcNUMw4/qDKGRjsrHcUruw3n33O0Drv/IsS24ZK+YFXAuvugkM/Rws8Zeucnjqkqfe9N YbW2AAf/prEc5oQkcDV+y49gIKInyE01e4gtJ1jZzJ8gTtyP2XMJv3HgQSUiWg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hbp4V5TRRzq7D for ; Fri, 04 Sep 2026 07:29:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30d49 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 04 Sep 2026 07:29:14 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 2fb53436cd05 - main - tcp md5: fix accounting of ACK with bad signatures List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2fb53436cd05f65164d166ef3ab33660fe451470 Auto-Submitted: auto-generated Date: Fri, 04 Sep 2026 07:29:14 +0000 Message-Id: <6a9a734a.30d49.7b8dbc32@gitrepo.freebsd.org> The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=2fb53436cd05f65164d166ef3ab33660fe451470 commit 2fb53436cd05f65164d166ef3ab33660fe451470 Author: Michael Tuexen AuthorDate: 2026-09-04 07:24:40 +0000 Commit: Michael Tuexen CommitDate: 2026-09-04 07:28:35 +0000 tcp md5: fix accounting of ACK with bad signatures When processing the ACK of the initial TCP handshake using the SYN cookie, don't increment the counter for unexpected signatures (tcps_sig_err_sigopt). The correct counter (tcps_sig_rcvbadsig) for bad signatures is already incremented in TCPMD5_INPUT(). Reported by: Hannes Elfert Reviewed by: rscheff MFC after: 1 week MFC to: stable/14 MFC to: stable/15 Differential Revision: https://reviews.freebsd.org/D59302 --- sys/netinet/tcp_syncache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/netinet/tcp_syncache.c b/sys/netinet/tcp_syncache.c index 1b7e03e4ff79..3a447703b628 100644 --- a/sys/netinet/tcp_syncache.c +++ b/sys/netinet/tcp_syncache.c @@ -1169,7 +1169,6 @@ syncache_expand(struct in_conninfo *inc, struct tcpopt *to, struct tcphdr *th, s, __func__); free(s, M_TCPLOG); } - TCPSTAT_INC(tcps_sig_err_sigopt); return (-1); /* Do not send RST */ } #endif /* TCP_SIGNATURE */