From nobody Wed Sep 02 13:32:30 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hZkDb2kV0z6q42t for ; Wed, 02 Sep 2026 13:32:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hZkDZ59ldz3Frs for ; Wed, 02 Sep 2026 13:32:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788355950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z0P/njSxBCmyTH1rVZVrz1RpRJOBhK6raiz7NELAgQM=; b=KqW2vsfgVECO4wzcqL8IwxZ8C7kPIg1j+lqElpzTESJsl47DtgM0ppD0SKH2bwMXGtddnT Rt4q7TD1SbBftqKA6UQp0dz7ssaOX+OKfWtPfUEGCRWf/MCqGBG2apVoBSlmfhZdV5mK93 N4+Jqkh5mybzH3YoYLJG0SIgVqIIXEKI6TO6eXBuThhxCdnOZL863j1Zuv3rGm6JR661Pr HHtVS8uaFaauGMrZqa5P4/PlS9S8hwnxkZIjwNHihi2Xg9c+CYZ+k4bdlapzLV4wmjuaJu w1Ov49U24Rq8cBCbmAggJxU4+HLIclTkA8bsYvNj/ZPTj4NV4lbzRBJmbr2b9A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788355950; a=rsa-sha256; cv=none; b=NsfBGPMcvRah6wxprqJE0hoxUhk79Htpt5qVMMaRlG4RQiGlZ/+M1zOqSVqTvXMeu1QhKy J7eLqE6OjAJucLWo3v7gPststlTqJzgduaxJMbnJ2f6wqa7j4cBhuWuzgRmtV5O/RrWUsm skPIsJ8NXoNJXQ7t3SEG9QoicSAT8C23MXQffq8mFgsgZgDWbm18zptx4zqrbC61PGYBn1 GG4bZ4bvy75i5zJjBWACQj8U7ATegbUL8NZepdhYBi1cWwigHKnFB8uyDmWn2rZj3ONNS/ OrT3JfEQTtQgKI24ZIFzcLDT3v1bPCgtU8PoupELYeg/csjcUurYQOhC621Duw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788355950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z0P/njSxBCmyTH1rVZVrz1RpRJOBhK6raiz7NELAgQM=; b=PyNZj4h1kOWZnEbcFrjr01U2f9IvdXqvjr77jST1DSa5k19HE/mYhv+CUpRPrzUMG7QMFA LGuN6IKp7owC+oUQ6xOOlDT/mHnIKKojAnpV4atNebO5eU19LOlnyN2qIw777Ltv7eaNXj uGmiEBDK1Ldq+TGdTX+manpD7g+6lIWd7YrWN6wNo1EmRpYRlz/Nd+4MLwjykLNov1+pZQ H39Txts6jx8GcvkZh6Wg/k77HQTR2fT3VRTP8KAg79jyR4revce4XYiHbXDDWKzx0StUCJ B6ASMoYRgbEvaY6GiEbK0NB2T2GqJR8PpNCPc25iO+RVO8YI2WWhB6uOgPbDig== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hZkDZ49snzmDZ for ; Wed, 02 Sep 2026 13:32:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1a3fa by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 02 Sep 2026 13:32:30 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 7cb1a76f8815 - main - devstat: Fix a kernel stack disclosure List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7cb1a76f88158fb690418336b736e66c238cd4f7 Auto-Submitted: auto-generated Date: Wed, 02 Sep 2026 13:32:30 +0000 Message-Id: <6a98256e.1a3fa.11eedcfa@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=7cb1a76f88158fb690418336b736e66c238cd4f7 commit 7cb1a76f88158fb690418336b736e66c238cd4f7 Author: Mark Johnston AuthorDate: 2026-09-01 16:07:09 +0000 Commit: Mark Johnston CommitDate: 2026-09-02 13:28:51 +0000 devstat: Fix a kernel stack disclosure The 16-byte "device_name" field was not zero-filled, so could contain uninitialized stack data. Zero the whole struct, as that's the prevailing pattern for this kind of conversion code, and it's more robust in the face of future revisions to struct devstat. Reviewed by: olce, kib Reported by: Reo Shiseki Fixes: a11d132f6c62 ("devstat: Provide 32-bit compatibility") MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D59309 --- sys/kern/subr_devstat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/kern/subr_devstat.c b/sys/kern/subr_devstat.c index c62df0e210e1..b0f2a5d8cbf1 100644 --- a/sys/kern/subr_devstat.c +++ b/sys/kern/subr_devstat.c @@ -430,6 +430,7 @@ sysctl_devstat(SYSCTL_HANDLER_ARGS) struct devstat32 ds32; unsigned int i; + memset(&ds32, 0, sizeof(ds32)); CP(*nds, ds32, sequence0); CP(*nds, ds32, allocated); CP(*nds, ds32, start_count);