From nobody Wed Sep 02 01:40:42 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hZQRH094Rz6qNVH for ; Wed, 02 Sep 2026 01:40:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hZQRG5pHqz3gnR for ; Wed, 02 Sep 2026 01:40:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788313242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CBMn6AAnuvRZAfWju2rCTJvqKVyvWCOeTrMdwvE0Rbc=; b=KZccDvVdUsp54NjNxNSuWJjiui6bfjuFl6COAFo7EnUZesdbiwOce715Cls7QZCZKpdQLp P2hyn07GwAa7U5ziCipFXgBjHNojsX9UWYRNGGp7bxQfX4ttvfaaN/4BtVaUke3ZCfRdH8 ke8GX+ptMTgu7sFuWBaSIePcFKyiiXx8lxG2dHuJzyAMTnJw8vWVzEl2CDMvHoCO2yHSNW QjRgad7Wy1U8J2q1UaoHnpiNHny2sKtIXWXnkRnWOX93mRxIUlR77eQF6m5R5fCDhH37GT o5cGXesheUn+UlSCSbZjbmBrEZty3mut2KkzygxPeqNFppy+ORfePCEtvaBjsw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788313242; a=rsa-sha256; cv=none; b=HKefeAGIvCzqsNI0AO2kwEy+peW7mFlE/At81o389AcV8uXSNs5uZdp07whLetm83ahth5 eW2T9PIqXRRo+OhvfxmplehvfIW3tw7Hi4KDzYKoUBFREnbyFvsvlDzoCWolq4hRDRazLU ONK7ag2gPldDs0YDLdE390hU8PyUfU/4Ng6SjVAeZ/23fctg2ZjNkraEQZFKc04ebCpouP iS1tXKIAIA5pUkPnslTkYkO5UOklYHrfdWaWsrxjo85jDK+2kPFYs2pIOuaxxeuWeDIbeX OTUF1yFSbhPLazGUkSidc1YQ53bBpT35daQRjdjuJ5iOc97xhaPLkHw8+qW4JQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788313242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CBMn6AAnuvRZAfWju2rCTJvqKVyvWCOeTrMdwvE0Rbc=; b=oNx6Yr8Q0mxkpyJZuhGl1BQCAqvKfV0yWep4EvzBfm8Kzmjbg0/F1uCQ5wEkpRVxhcOXBV 60fsT85GkNx0i5RFsKsi+lAUbA9V3io1REd5YiTAwFxkBdM5QxjUXAaR5RWAd0ew44RKak 999nowkLki/UhTPPb6u402ph5HisferX3k4lU+3JFElsKMVa8BaFddcOchR666ns4qLv+d 9JI1lvkgPoo9JT9eSO4z/JaXwC6OxbL7yJvTNH99CyUJP0TdXUCVjjGaGwN1ZsOznG2bkR 79GmDZnZqWFLsT49ZH03ZK6xaFEPcfKZJYvbu930Fzjz9jgKyPDkkDDe2kIlrA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hZQRG4mH3z7XN for ; Wed, 02 Sep 2026 01:40:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1f87d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 02 Sep 2026 01:40:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Devin Teske Subject: git: 4aeab132f6d8 - main - git-arc: SC2223 DoS-via-glob hardening List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dteske X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4aeab132f6d8f38f5434315db22dbeb3072e5d2c Auto-Submitted: auto-generated Date: Wed, 02 Sep 2026 01:40:42 +0000 Message-Id: <6a977e9a.1f87d.2a0b3f6@gitrepo.freebsd.org> The branch main has been updated by dteske: URL: https://cgit.FreeBSD.org/src/commit/?id=4aeab132f6d8f38f5434315db22dbeb3072e5d2c commit 4aeab132f6d8f38f5434315db22dbeb3072e5d2c Author: Devin Teske AuthorDate: 2026-09-02 01:38:44 +0000 Commit: Devin Teske CommitDate: 2026-09-02 01:38:44 +0000 git-arc: SC2223 DoS-via-glob hardening Quote LOCALBASE and ARC_CMD default assignments so a poisoned value cannot glob into :'s argv. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D59130 --- tools/tools/git/git-arc.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/tools/git/git-arc.sh b/tools/tools/git/git-arc.sh index e7ca3fabd63f..efc29b92865d 100755 --- a/tools/tools/git/git-arc.sh +++ b/tools/tools/git/git-arc.sh @@ -152,9 +152,9 @@ setup() # the devel/arcanist-port, which installs a symlink in ${LOCALBASE}/bin # but conflicts with the archivers/arc port. # -: ${LOCALBASE:=$(sysctl -n user.localbase)} -: ${LOCALBASE:=/usr/local} -: ${ARC_CMD:=${LOCALBASE}/lib/php/arcanist/bin/arc} +: "${LOCALBASE:=$(sysctl -n user.localbase)}" +: "${LOCALBASE:=/usr/local}" +: "${ARC_CMD:=${LOCALBASE}/lib/php/arcanist/bin/arc}" arc() { ${ARC_CMD} "$@"