From nobody Tue Sep 01 13:56:57 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hZ6qF5N7Zz6qvKw for ; Tue, 01 Sep 2026 13:56:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hZ6qF466Dz3rmr for ; Tue, 01 Sep 2026 13:56:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788271017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IjN5fhb5n590U2n1+wCNns0d3Px3rednbH1b/Yeeayw=; b=H1vu+NeHg3GLsDxGbujU6XRVtiNM9tg9fTd6MlnKBnyOZ9WCMqT/K/riG79HLLELkNKf4U zRZfNs0aQsIDO1KH30OqUNtReUOr2DxwqcGGGjFIF7c879wA+zq48TmtHJWXfxF1vEFXq1 D8Q/fLJBmQrx+FbjtU3Bi/NSo5SCw9Wn475Itgb2NudwUPzzuFpPmLwf8N0FrF0B/Z0/0U 9WmI3gaNui5hX0K95y49OEcR7Blfmhy1RwP/myTbalzqA7W1xOippcheIYCZkvcQ4GzjIq 42YqdIPMmz9NFTIIHfRH2iUrNChIiXsgN+rbH/BxTZGuslCHv4H8kB/zcwlHTg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1788271017; a=rsa-sha256; cv=none; b=XjDmgXeFSPTRbCSl1yTq+RCpvd1Iqek/ZPQvTwirlIUrx5vm+plORYwAL0zlSmOTSkG1c5 iVL7x5r4dbGqiiW3T06eNtZZx0jJSBrVqyMBaPprKOH2ZD+/GBPcFDMMeJftJsheYtK7vP pWcCn+d7Jiq9o7hAQCKORYO11F9J2wEuhFjoMGtbxE3c47LYPgKdyWWLFeG4PBsJsjVV+t cCrnnHe6btVzSwPqGkQMVgYPsg1Ihv72j6An5OEVa6LloWem2aKPklh/2ubY6GYPyMxD6b gLjTSA5pVfmhWwOX6VdjDSoqYz2l8etJFtQ97AkH7qIsGKM+z8ccbNMLkW7L8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1788271017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IjN5fhb5n590U2n1+wCNns0d3Px3rednbH1b/Yeeayw=; b=q9K0bKUEGHbLnsP2+GKM8z1BN2fCXVOlMwKaLc+g8LA+JK0mzwtrSQQgdtWhjEpkiH13Vy rXrNLOI+fT+7tv9QxQQqIBTD9k4+TLL3E3Ama2a5T48Su40lriWxFhXepx9JQHPZAAGHrJ Ed9I2nbBneLtHZ8jCXLF/GCw9GYW8reNkTguzfZWFC00WkuD+CY99dyEPOl7L9uLfIhgab k9g4FyGPFQk8BM5685afEciTI9IStC/HvSyr2yMX6NvafsToSrson6YafFtsePofSD157S zg8h1TrW1V0Hqygd2GKCBm5sro1LDC0NEolQ4it9n8C0Qbm80bHnyDgcO4/5Dg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hZ6qF2Q2cz11Fy for ; Tue, 01 Sep 2026 13:56:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1c719 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 01 Sep 2026 13:56:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 326ab530dcab - main - pdopenpid(2): in cap mode, translate all errors from pdopenpid1() to ECAPMODE List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 326ab530dcabe70ab48728cad0465f35b30dbf60 Auto-Submitted: auto-generated Date: Tue, 01 Sep 2026 13:56:57 +0000 Message-Id: <6a96d9a9.1c719.7e4b4345@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=326ab530dcabe70ab48728cad0465f35b30dbf60 commit 326ab530dcabe70ab48728cad0465f35b30dbf60 Author: Konstantin Belousov AuthorDate: 2026-08-28 17:54:02 +0000 Commit: Konstantin Belousov CommitDate: 2026-09-01 13:56:34 +0000 pdopenpid(2): in cap mode, translate all errors from pdopenpid1() to ECAPMODE to not leak information about unused pids or system processes' pids. Reviewed by: markj Fixes: 73c92a978cce ("pdopenpid(2): allow in capability mode with restrictions") Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D59252 --- sys/kern/sys_procdesc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/kern/sys_procdesc.c b/sys/kern/sys_procdesc.c index b9329cd38088..774774bdf4f0 100644 --- a/sys/kern/sys_procdesc.c +++ b/sys/kern/sys_procdesc.c @@ -728,7 +728,10 @@ kern_pdopenpid(struct thread *td, pid_t pid, int flags) fp->f_pdflags |= F_PD_NOKILL | F_PD_NOFINSTALL; filecaps_free(&fcaps); } + } else if (IN_CAPABILITY_MODE(td)) { + error = ECAPMODE; } + fdrop(fp, td); if (pdf != NULL) {