Re: git: e32b082ba28b - main - clk: rockchip: Add the MMC phase clock
Date: Sat, 31 Oct 2026 21:12:06 UTC
> On Oct 30, 2026, at 12:36 AM, Emmanuel Vadot <manu@FreeBSD.org> wrote: > > The branch main has been updated by manu: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e32b082ba28bd3d0e026782eeb93f124ced7508f > > commit e32b082ba28bd3d0e026782eeb93f124ced7508f > Author: Emmanuel Vadot <manu@FreeBSD.org> > AuthorDate: 2026-10-20 08:09:18 +0000 > Commit: Emmanuel Vadot <manu@FreeBSD.org> > CommitDate: 2026-10-30 07:36:46 +0000 > > clk: rockchip: Add the MMC phase clock > > Add a clock node type for the Rockchip MMC sample and drive clocks. These > clocks have a phase in degrees controlled by a delay line and a fine-grained > phase selector, and implement the new clknode phase methods. > > Reviewed by: mmel > Differential Revision: https://reviews.freebsd.org/D60886 Hi manu, This change broke armv7: https://ci.freebsd.org/job/FreeBSD-main-armv7-build/29954/ . I’m testing this fix: universe16a% git diff diff --git a/sys/arm/rockchip/files.rk32xx b/sys/arm/rockchip/files.rk32xx index 2faee11b0b6a..5595f37e9a5a 100644 --- a/sys/arm/rockchip/files.rk32xx +++ b/sys/arm/rockchip/files.rk32xx @@ -17,6 +17,7 @@ dev/clk/rockchip/rk_clk_armclk.c standard dev/clk//rockchip/rk_clk_composite.c standard dev/clk//rockchip/rk_clk_fract.c standard dev/clk//rockchip/rk_clk_gate.c standard +dev/clk//rockchip/rk_clk_mmc.c standard dev/clk//rockchip/rk_clk_mux.c standard dev/clk//rockchip/rk_clk_pll.c standard dev/clk//rockchip/rk_cru.c standard Thanks, -Enji