From nobody Fri Oct 23 21:59:27 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jBH3z1z60z6wWjG for ; Fri, 23 Oct 2026 21:59:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jBH3z1VKpz4vZ5 for ; Fri, 23 Oct 2026 21:59:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792792767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=acRvkq90fRqzl0Ge8KPbO/wyZl0zYwZuK0lxIadGwUs=; b=Kafa/Drr+w4LObb3CiCWhCwU63mB48g75vA4hMMaF4aNjxv/dGnQNXOGRu9+vXDHqhSZGE La24Uj6azqHyQ0B9xolZwLryk3w8CfSS15seSF/dugozex+HKpwhtU1zA8AiSgCJOz6VkM /O1Ya3GLOMM0WoCK0wSiOs+4S95G1lQEH38lD/K80saQb8Kd6bw92r+04XoQ5TfH8wspnR WA9pJwV7TMWCjFtjhYaLdO+n2P/pHFctSgZlzRhcGW7Wa5Hnsto7fXq9jl6hKKoMrqQp8c Kw6TqSteoVimddjNHcc2dnJBvj1uKt74rLbEBUoxcjq4fLYzDCb/ogzdzxgE3w== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792792767; b=VfMp+5SzqknTav3g6zdBT8IrCUkQks87WJGq+f2RZfS9ILUXYlcVdOEFhWVofc/O6YgCix v4YoMH7vnT5y/FoyVg5L7WWW5hdHQe9uBg2SuVfEqlJHhTxyapo9EUiDuT2nYCE70auCeF 83PWzqOzKIj7TUMjqtouOP4FMPaRNIhyvBPaI7Od5ULomgRsMi/XcUzRq5HY9nr+33QiMf IRMDYfuslMbIt636+Pzl73kOrxrn+Pdq0LYs2FoRg7if1Z+opsWyGpyoC93KtR3Rs2KUcz 4W/Mwl/zCkqqJe2XK555nWHgnBq8Ggq2pVGBUan3Ks7MFo7/AytnImfsjn8oVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792792767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=acRvkq90fRqzl0Ge8KPbO/wyZl0zYwZuK0lxIadGwUs=; b=O3fkSSglmYq63UE3qf+PYG2Gcu1lQKjDbfkopXgIxljyFJ495roETlcHVk/nZ0+ps1JQfr mdShtpr72t9HmcvcXdhATZAm5zaWRUZg2oYH0XeJqJbLo/P9BaXDMGL5vhJiEbtFFd1cje 8JrmCddbLQYrEckFFl2fEzUM7FQxAtXy7JLDP+A9zIl8Ce/PFgHJw3xLTL8nKSR+znz2uh 0AebC2bBm0rc2CVzdVgVTsI+GZ1F+5UGsOmylY/ttKVOIjiR3byCUe8WHbKYH22HbLrnzg 2aEFxw9c4GW7jxxkH5CLnDMwLznu0V799fv+Oa1jWHmbcyMA/FHTBsQqeLFiYw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jBH3z18J5zpgw for ; Fri, 23 Oct 2026 21:59:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3bfc4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 23 Oct 2026 21:59:27 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 13011cbf7d80 - main - smsc: Remove phy address check in smsc_miibus_writereg List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 13011cbf7d80cd1554d87296225ceccb3f7524b4 Auto-Submitted: auto-generated Date: Fri, 23 Oct 2026 21:59:27 +0000 Message-Id: <6adbd8bf.3bfc4.397fc400@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=13011cbf7d80cd1554d87296225ceccb3f7524b4 commit 13011cbf7d80cd1554d87296225ceccb3f7524b4 Author: Ed Maste AuthorDate: 2026-10-15 13:31:41 +0000 Commit: Ed Maste CommitDate: 2026-10-23 21:58:51 +0000 smsc: Remove phy address check in smsc_miibus_writereg The driver only allowed writes to the expected phy (i.e., sc->sc_phyno), and reads were never filtered. sc_phyno is already passed to mii_attach() as phyloc, so nothing tries to issue MDIO writes to other addresses and the check is not required. Remove the check in advance of supporting external PHYs at arbitrary addresses. Tested on Microchip's EVB-LAN9500A-LC LAN9500A evaluation board. Sponsored by: The FreeBSD Foundation Sponsored by: Microchip (Hardware) Differential Revision: https://reviews.freebsd.org/D60743 --- sys/dev/usb/net/if_smsc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/usb/net/if_smsc.c b/sys/dev/usb/net/if_smsc.c index c3c21fd22472..5803a5bd1bcf 100644 --- a/sys/dev/usb/net/if_smsc.c +++ b/sys/dev/usb/net/if_smsc.c @@ -494,9 +494,6 @@ smsc_miibus_writereg(device_t dev, int phy, int reg, int val) int locked; uint32_t addr; - if (sc->sc_phyno != phy) - return (0); - locked = mtx_owned(&sc->sc_mtx); if (!locked) SMSC_LOCK(sc);