From nobody Thu Oct 22 16:41:29 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j9X3g0KLqz6xJvY for ; Thu, 22 Oct 2026 16:41:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4j9X3f3JTjz4h8D for ; Thu, 22 Oct 2026 16:41:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792687294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZnrVNkTHNfrlrPt4cXl/ix8Ulh1wAwo1/P7763T/QMk=; b=yGj5KIHGOh2K2qlH/hDA2uQwe9kvbeu+IqAORhlRB7IwU7PIPwpW2z78Bc94Y0rxRD9h4O EC6lzCpjaEhEqZFF5OAKL3QwbHkaWfNT3zVIWz+GlwXW2MZqXBx2547k31q+BtS0Wp4Quk Id4SgX54Ns9eVbj2A8gCM4HHrOsBj68dYOvWMXfCGLyAVA+hUqrErl9Jfl7E+sxPtJ79hY i0EcjKcfy4Cppq4dMTzvgIZyXP+CnR8bsrNA/AWnoCUz/StQbQ4FsVX9xbAJ2wC0iLzrDx sRAYFtAZgGys1c4+2XVbkipIdSiCZuGK9e19DHHFSYoR0Y+MVxSnssOxKyaWSg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792687294; b=ODeY9qCSY1AwTpF0uLZylAqwOUL42W7Owrgxsw5BvOpiR0ndxSScuMZ+gLTSyi1xGXnBP5 qvXls0ww8a985QrJSLrxiW6wiY5Yjj1EEFDFYZvDzyNFKlXaFT67LQQinbT5NpUqsm+foF j1HXMH/RvIhLlbpLLzL9aFo0FAXK6++BmnCxRij5FFuzQpYBmxM5cAYwlk9kqCpOxsp/oD KgK/e0FmpkG5tfOhLYvaRpJIi+9Yo5ICmHlCCpO0cL7Jt9uSU5uFJMoGAt78gTgTz5BrGj TLZRrqYsQzsSWSH5vqqdxqdpdaWCDbjBlEI4JrysXGVtjbOSLErqTy1Oee8x9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792687294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZnrVNkTHNfrlrPt4cXl/ix8Ulh1wAwo1/P7763T/QMk=; b=C5ImdqtuPQ3Q+OvjvkxtVoqxwtIHtusowbr2VkRhTIH/PVHH2do/z4wewejhw0DP3TZEQ5 /BvJDf+tnFnij3CO1wx9K9dP+URkNZ65TPHTI8Phjyy9/9MlJpN+ILzS6qpYTZ3WHrX284 M6iMuAC99dw2V0Q+7tS4tdXj8SQVNUtkioq8iHUMMXgjVaw2gbOCq8+kSDOsza2gmSDQXv F0svVHC4+YBIoIGZU9+h0HPsPmi1h869kdE+f0ke4x2A0ba8HV3IiGvhPZhid3YXMliRBC pwtHNu4dCqM7xfGojZzaTJrZZ7Yd5GYFnAidwOo0v8hbdZvxl7JH/lcgyXuIIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j9X3f2zFszqwq for ; Thu, 22 Oct 2026 16:41:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39720 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 22 Oct 2026 16:41:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Ayrton Munoz From: Kyle Evans Subject: git: 775e421dc38f - main - nvme: Fix default is_storage_device kobj method List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 775e421dc38f18fa6b7fdc7b214a013cca44b58b Auto-Submitted: auto-generated Date: Thu, 22 Oct 2026 16:41:29 +0000 Message-Id: <6ada3cb9.39720.7a6c7574@gitrepo.freebsd.org> The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=775e421dc38f18fa6b7fdc7b214a013cca44b58b commit 775e421dc38f18fa6b7fdc7b214a013cca44b58b Author: Ayrton Munoz AuthorDate: 2026-10-22 16:40:50 +0000 Commit: Kyle Evans CommitDate: 2026-10-22 16:40:50 +0000 nvme: Fix default is_storage_device kobj method makeobjops.awk only accepts an uppercase DEFAULT before a default kobj method. This commit fixes a typo introduced in 949804c81909 so non-PCI drivers actually use nvme_is_storage_device_default instead of kobj_error_method. Note that even though kobj_error_method returns ENXIO (6), it does not get implicitly cast to a bool due to the function pointer casting in the nvme_if.h generated by makeobjops. Instead the codegen for the NVME_IS_STORAGE_DEVICE callsite shows that only the lowest bit is being checked as if it were always a bool. Without this any nvme driver that doesn't implement is_storage_device is not treated as a storage device. Reviewed by: imp, kevans Differential Revision: https://reviews.freebsd.org/D60112 --- sys/dev/nvme/nvme_if.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/nvme/nvme_if.m b/sys/dev/nvme/nvme_if.m index 4484c1da9dce..e0186914f3cc 100644 --- a/sys/dev/nvme/nvme_if.m +++ b/sys/dev/nvme/nvme_if.m @@ -59,4 +59,4 @@ METHOD int handle_aen { # METHOD bool is_storage_device { device_t dev; -} default nvme_is_storage_device_default; +} DEFAULT nvme_is_storage_device_default;