From nobody Thu Oct 22 13:10:32 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j9RNB508Zz6wy1v; Thu, 22 Oct 2026 13:10:34 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4j9RNB2svsz4m2g; Thu, 22 Oct 2026 13:10:34 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792674634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rXp7tzEphmW75mLaYyXZWgUC5PDNXJ+FNGmKBO/+4+c=; b=XoTMs4pMsHa+uuJlBCH3gRmPEV+tbAI3BIU21qqERPJswZ20oZG65EiyoBejaSI50sObJQ 7hf6z0hGAeuy3M6R6CTJ3xeSRELHVpPDvlzrKZ6jktOY28lKd7LWQuHrOhi7fhVEyfj9ZN kp7/3bmXldXq33+wDu/MZwa+X5bxNu4+MA7KZA9vTPyN6GxmJogUj9uKpgGSgJflXWhE6a /tG+NGGkYuMH7CGdpWMKXP6kxXYXH8O0dNd570dAJUlJo2/gjr3AxujjKfMyJUY46BypXV Vs815TQqGxnegacOQIq6ndwSK22oKDuO83hHG7OH183dyHEDtRRWHdEOOYi9jw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792674634; b=wAp77hs4qy9Y1EYZQ/gcJI3W4Fh83ZOLq3vKd5LAlJrXCDN7mmTTHlHmdHOV0xrKUFjHva wI8retaxbhRROu0L3rGfq/XYplMn5e+ncRFdExbJslJxbD80Qci9oE08Vg4EDZtJ/JADdh KKw9O1rh96tjzu6x9RBUKaoN7f3QQbsKyOSm1hMHCwRBis4Pl6nMTvvmwiOWQzh7y2UwAj 6/bGmtGNb621BUm9k2+rwr3UvFGzvZyU/+NUzIvu5kvQnm0ypfVKaYkRdDQ9ZXM/3EHm4b 8XY1kqAmk0IVyuek+kmy8nYlaGV1wg3bbH2WVW+VgJrn5orMbJRCVSWoBhaqWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792674634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rXp7tzEphmW75mLaYyXZWgUC5PDNXJ+FNGmKBO/+4+c=; b=E0xGdGitJ/uxYOhIhT3ikim8z8e3iolVqTbQoENHjSIuaIQ+ZoaS3NnwQ1bShQ8nu25rM1 CUutladeJzwqw1XgyZysPu+p37aaTOD8hzqylzbwo9hsIo8/+REsOw2lQf9pfeNZq+r0q/ mK9EHHCF+f47rjCtC2f/qKQVAjjSFWKaN6i/XSq4jU0sXZD6d4qY3gAH3j+BoY1XPCJt0M jMQNPJxSfV0EHBFM/Vcte/XZTGzzP9gEb8V/2A6pWc0JzqgC5QHuDrq4yCdykSM6b+Aav4 75Zi5z3msyJzJjcA4ga1WFEjHGj4gJCr0eJbkDwgMvbMZ8CNUe7GJFn7P9u7/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2a02:c6a0:3052:202:2df1:687c:7875:2ae2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4j9RN94lgmzWwH; Thu, 22 Oct 2026 13:10:33 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Content-Type: text/plain; charset=utf-8 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.100.1.1.12\)) Subject: Re: git: 7146ad04f18e - main - tcp: refactor tcp_autosndbuf() and associated sysctls From: Michael Tuexen In-Reply-To: Date: Thu, 22 Oct 2026 15:10:32 +0200 Cc: Gleb Smirnoff , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <00F0B635-5C83-409D-9081-B757A67441F1@FreeBSD.org> References: <6ad9838d.21448.54c59970@gitrepo.freebsd.org> <72D36446-63AD-4D3F-8B3E-54A12A788745@FreeBSD.org> To: Kristof Provost X-Mailer: Apple Mail (2.3901.100.1.1.12) > On 22. Oct 2026, at 12:51, Kristof Provost wrote: >=20 > On 22 Oct 2026, at 11:29, Kristof Provost wrote: > On 22 Oct 2026, at 5:31, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D7146ad04f18e7f0767a4d44cff43c1c6= 7ea98cec > commit 7146ad04f18e7f0767a4d44cff43c1c67ea98cec > Author: Gleb Smirnoff glebius@FreeBSD.org > AuthorDate: 2026-10-22 03:27:47 +0000 > Commit: Gleb Smirnoff glebius@FreeBSD.org > CommitDate: 2026-10-22 03:27:47 +0000 > tcp: refactor tcp_autosndbuf() and associated sysctls >=20 > Rename tcp_sndbuf_autoscale() to tcp_autosndbuf(). This matches > complementary tcp_autorcvbuf() that was factored out as a separate > function a few months before tcp_sndbuf_autoscale() was. Move the = large > comment to the header of the function. Use unsigned types for all = sizing > sysctls and variables and use bool for the switching sysctl. Add a > comment above net.inet.tcp.sendbuf_auto_lowat (default to off) = providing a > reference to its origins. Add DTrace probe tcp::send-autoresize, > complementary to the existing tcp::receive-autoresize. >=20 > Rack has its own function, just enable the DTrace probe there. >=20 > Reviewed by: tuexen > Differential Revision: https://reviews.freebsd.org/D60732 >=20 > sys/netinet/in_kdtrace.c | 4 ++ > sys/netinet/in_kdtrace.h | 1 + > sys/netinet/tcp_output.c | 142 = +++++++++++++++++++++--------------------- > sys/netinet/tcp_stacks/bbr.c | 2 +- > sys/netinet/tcp_stacks/rack.c | 5 +- > sys/netinet/tcp_var.h | 10 +-- > 6 files changed, 85 insertions(+), 79 deletions(-) > =E2=80=A6 > index 09295544855f..d11a2b745382 100644 > --- a/sys/netinet/tcp_output.c > +++ b/sys/netinet/tcp_output.c > =E2=80=A6 > void > -tcp_sndbuf_autoscale(struct tcpcb *tp, struct socket *so, uint32_t = sendwin) > +tcp_autosndbuf(struct tcpcb *tp, u_int sendwin) > { > =E2=80=A6 > =E2=80=A2 SOCK_RECVBUF_LOCK_ASSERT(so); > Is this assert right? I=E2=80=99d think autosndbuf is about the send = buffer, not the receive buffer. > With this patch the system does just work for me: > diff --git a/sys/netinet/tcp_output.c b/sys/netinet/tcp_output.c > index d11a2b745382..b5f36d83f5a2 100644 > --- a/sys/netinet/tcp_output.c > +++ b/sys/netinet/tcp_output.c > @@ -2154,7 +2154,7 @@ tcp_autosndbuf(struct tcpcb *tp, u_int sendwin) > struct socket *so =3D tptosocket(tp); > u_int lowat, newsize; >=20 > - SOCK_RECVBUF_LOCK_ASSERT(so); > + SOCK_SENDBUF_LOCK_ASSERT(so); >=20 > if (!V_tcp_do_autosndbuf || (so->so_snd.sb_flags & SB_AUTOSIZE) =3D=3D = 0) > return; The patch looks good to me. Sorry for no catching that when reviewing = the patch. Best regards Michael >=20 > =E2=80=94 > Kristof