From nobody Tue Oct 20 14:49:35 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j8FgW4JlSz6x5QX for ; Tue, 20 Oct 2026 14:49:43 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4j8FgV5YQVz4Cpx for ; Tue, 20 Oct 2026 14:49:42 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=pEkAdA+6; spf=pass (mx1.freebsd.org: domain of garga.bsd@gmail.com designates 2607:f8b0:4864:20::c32 as permitted sender) smtp.mailfrom=garga.bsd@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none) Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-6f74f6b46abso1684882eaf.0 for ; Tue, 20 Oct 2026 07:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792507781; x=1793112581; darn=freebsd.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=j9JuERVlfoVgYYzGogCIOZaUE2i3HGJ474XgaxqRaqM=; b=pEkAdA+6aIPO4XKjoJnmvph3Csdmz+I6ijjnPVoZSb1Fec/Bs2oCRS/U1GSPyfFa3/ AUziSk5Z2UN9/UgybJjhnGXkgZBX8NX0OlAE9Lys8wUZwHdFwNWmfnZMBu8zF1svZV7/ c8yZByExPPbVLqreBTkZo1sltMG/nMZLZMFRQYcJz+sxdJ/0nZiSbJ72sDov225vPdsG PN9iKZQbCK8T3BGgNNF6/d8hKs06z8Q5gK+IQEAYFIxY/lfZdXYxpYF/EO96cTe0PQ6b 3uaPfYiNvmFTBmK54nBbJrqvNOK3D6P7nYA1Kqh5WThGf/K9LAzewvMcN8hHbduIZerq x64A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792507781; x=1793112581; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=j9JuERVlfoVgYYzGogCIOZaUE2i3HGJ474XgaxqRaqM=; b=DieqRlyS9yLANLZwz8QjaZ5lNoBfrefh/7c/mDLoV7Kn2aTvkWoAPu/M+H7leHMysf 3NJlHwiPYzV10VxhfCzh3iDw+IDeadiQWzcAffRmA6QeJud9yj6m2aGzEJbXL/UIFjxy jkbwv9AUGQklhuj09XDRf03YcB0z+uHzAozBQ0S5Qehxa8tlR993tAgin6XDEOswcbbU 24Ec68gb8VBTBQ0F1+L1upyphevGUIG9N5S/R5r69imKcUPrR5DGlhrZbp9ZXzmlpG6M SzjI9cC7cDEN6pN7rIgGOjXDpgqIpHudPtvgnJenBBNQgy/ffUTc0a0h/IvBycg9+G+i y3Qg== X-Forwarded-Encrypted: i=1; AKwUvBxxA6XJl1icLfSI0Vm+QOZmHay70c1V2bYoL/6SgUTc8HwhhQbe0OrIimLkT4QUpcpHW2vdphIxVjHEKcdXpGEGakDJeA==@freebsd.org X-Gm-Message-State: AFq9FYIh69g637tstWFE9TnxCpDeRSqhb1WLSmyyJG8pMjrK46m+/x6u bN96ZIKOmgim3LZGdNE4NccszopRvnWD/X001vYJn/W2NbAjdfY8yT6F X-Gm-Gg: AYBFou3oHG3jBKDKaTLYSwnJjegiFICgyE1siNAg0TwYMQJCzI4dr1yaCshG+mfR1Pf rwRqGleV9CaeyfpsHV8go//vFtmOcuiLmAHEFoSurLNPmA94kb1QyiujmIT5FNexIa8+wDR8BDw VwVidlTdx3m2Sxm/hk5y2+Trc0RDdUXviwjakJf0jDtaWe8oUntVXDVS3oEwSYtg/Qu0Z8zX3nO 3xPm+HyvKx58i4GXpyiiPFfnet8+grEcTPbYHio0yYK8n+O6FsMx21e+ToRfSM4W8qFk0PjKQNJ ezoxT68SLMQwtqDgwa+2A/2s6gyNnY1t7HGSSKr0tgoPjqv7BUKlGg5glXJF0I6zIj5yh/aN9Yl uNw9XRCS/AutRY6Z7mP7BAO3thDb2KeQllHQzCDN61JlaO2lYCzG+g5yEvzyvc2x45CUg30pZuO /cUbYbNI/V00HaiFb0Y8FaowC9rmdupz9dE+4B+3cOjKZLgN+C9IXGkqJspJQJumB+T8C0ghD+d ubttR+86vpjHQ33+BjFdL4h3+pKt2Ta7jAbFrXrVx72w54R1UWjPX8a2xcm X-Received: by 2002:a05:6820:f004:b0:6d7:58ee:fd72 with SMTP id 006d021491bc7-70355a86a30mr7915048eaf.14.1792507780809; Tue, 20 Oct 2026 07:49:40 -0700 (PDT) Received: from [172.21.4.172] (dynamic-177-53-82-16.telecominternet.net.br. [177.53.82.16]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-845b9e280dbsm9348833a34.19.2026.10.20.07.49.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Oct 2026 07:49:39 -0700 (PDT) Message-ID: <1b86d6dc-0d3b-4f46-8cdf-80bce3d514e3@FreeBSD.org> Date: Tue, 20 Oct 2026 11:49:35 -0300 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: a5e6bee5a0bf - main - hastd: Use void pointers for opaque data To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rg_rav?= , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <6ad76c9e.3c2aa.428145e9__34743.37779205$1792502961$gmane$org@gitrepo.freebsd.org> Content-Language: en-US From: Renato Botelho In-Reply-To: <6ad76c9e.3c2aa.428145e9__34743.37779205$1792502961$gmane$org@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: / X-Spamd-Result: default: False [-0.10 / 15.00]; FORGED_SENDER(0.30)[garga@FreeBSD.org,gargabsd@gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20251104]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; ALIAS_RESOLVED(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::c32:from]; FROM_NEQ_ENVFROM(0.00)[garga@FreeBSD.org,gargabsd@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+] X-Rspamd-Queue-Id: 4j8FgV5YQVz4Cpx On 20/10/26 10:29, Dag-Erling Smørg rav wrote: > The branch main has been updated by des: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a5e6bee5a0bff9e9c12037e0b2c76c4f2ab5e046 > > commit a5e6bee5a0bff9e9c12037e0b2c76c4f2ab5e046 > Author: Dag-Erling Smørgrav > AuthorDate: 2026-10-20 13:28:42 +0000 > Commit: Dag-Erling Smørgrav > CommitDate: 2026-10-20 13:28:42 +0000 > > hastd: Use void pointers for opaque data > > Use void, not char, for pointers to opaque data in our send and receive > functions. > > Sponsored by: Klara, Inc. > Reviewed by: allanjude > Differential Revision: https://reviews.freebsd.org/D60729 > --- > sbin/hastd/proto_common.c | 4 ++-- > sbin/hastd/proto_impl.h | 8 ++++---- > sbin/hastd/proto_socketpair.c | 4 ++-- > sbin/hastd/proto_tcp.c | 4 ++-- > sbin/hastd/proto_uds.c | 4 ++-- > 5 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/sbin/hastd/proto_common.c b/sbin/hastd/proto_common.c > index 39ef696f5b69..c96b325a4130 100644 > --- a/sbin/hastd/proto_common.c > +++ b/sbin/hastd/proto_common.c > @@ -89,7 +89,7 @@ proto_descriptor_send(int sock, int fd) > } > > int > -proto_common_send(int sock, const unsigned char *data, size_t size, int fd) > +proto_common_send(int sock, const void *data, size_t size, int fd) > { > ssize_t done; > size_t sendsize; > @@ -190,7 +190,7 @@ proto_descriptor_recv(int sock, int *fdp) > } > > int > -proto_common_recv(int sock, unsigned char *data, size_t size, int *fdp) > +proto_common_recv(int sock, void *data, size_t size, int *fdp) > { > ssize_t done; > > diff --git a/sbin/hastd/proto_impl.h b/sbin/hastd/proto_impl.h > index 181a4cd4a17d..449ab4097397 100644 > --- a/sbin/hastd/proto_impl.h > +++ b/sbin/hastd/proto_impl.h > @@ -44,8 +44,8 @@ typedef int prt_connect_wait_t(void *, int); > typedef int prt_server_t(const char *, void **); > typedef int prt_accept_t(void *, void **); > typedef int prt_wrap_t(int, bool, void **); > -typedef int prt_send_t(void *, const unsigned char *, size_t, int); > -typedef int prt_recv_t(void *, unsigned char *, size_t, int *); > +typedef int prt_send_t(void *, const void *, size_t, int); > +typedef int prt_recv_t(void *, void *, size_t, int *); > typedef int prt_descriptor_t(const void *); > typedef bool prt_address_match_t(const void *, const char *); > typedef void prt_local_address_t(const void *, char *, size_t); > @@ -72,7 +72,7 @@ struct proto { > > void proto_register(struct proto *proto, bool isdefault); > > -int proto_common_send(int sock, const unsigned char *data, size_t size, int fd); > -int proto_common_recv(int sock, unsigned char *data, size_t size, int *fdp); > +int proto_common_send(int sock, const void *data, size_t size, int fd); > +int proto_common_recv(int sock, void *data, size_t size, int *fdp); > > #endif /* !_PROTO_IMPL_H_ */ > diff --git a/sbin/hastd/proto_socketpair.c b/sbin/hastd/proto_socketpair.c > index 31b657f17c32..a5f47acc7272 100644 > --- a/sbin/hastd/proto_socketpair.c > +++ b/sbin/hastd/proto_socketpair.c > @@ -82,7 +82,7 @@ sp_client(const char *srcaddr, const char *dstaddr, void **ctxp) > } > > static int > -sp_send(void *ctx, const unsigned char *data, size_t size, int fd) > +sp_send(void *ctx, const void *data, size_t size, int fd) > { > struct sp_ctx *spctx = ctx; > int sock; > @@ -121,7 +121,7 @@ sp_send(void *ctx, const unsigned char *data, size_t size, int fd) > } > > static int > -sp_recv(void *ctx, unsigned char *data, size_t size, int *fdp) > +sp_recv(void *ctx, void *data, size_t size, int *fdp) > { > struct sp_ctx *spctx = ctx; > int fd; > diff --git a/sbin/hastd/proto_tcp.c b/sbin/hastd/proto_tcp.c > index aeec887433f8..be1205ba3733 100644 > --- a/sbin/hastd/proto_tcp.c > +++ b/sbin/hastd/proto_tcp.c > @@ -479,7 +479,7 @@ tcp_wrap(int fd, bool client, void **ctxp) > } > > static int > -tcp_send(void *ctx, const unsigned char *data, size_t size, int fd) > +tcp_send(void *ctx, const void *data, size_t size, int fd) > { > struct tcp_ctx *tctx = ctx; > > @@ -492,7 +492,7 @@ tcp_send(void *ctx, const unsigned char *data, size_t size, int fd) > } > > static int > -tcp_recv(void *ctx, unsigned char *data, size_t size, int *fdp) > +tcp_recv(void *ctx, void *data, size_t size, int *fdp) > { > struct tcp_ctx *tctx = ctx; > > diff --git a/sbin/hastd/proto_uds.c b/sbin/hastd/proto_uds.c > index acb61a360180..5a14eb353c30 100644 > --- a/sbin/hastd/proto_uds.c > +++ b/sbin/hastd/proto_uds.c > @@ -227,7 +227,7 @@ uds_accept(void *ctx, void **newctxp) > } > > static int > -uds_send(void *ctx, const unsigned char *data, size_t size, int fd) > +uds_send(void *ctx, const void *data, size_t size, int fd) > { > struct uds_ctx *uctx = ctx; > > @@ -239,7 +239,7 @@ uds_send(void *ctx, const unsigned char *data, size_t size, int fd) > } > > static int > -uds_recv(void *ctx, unsigned char *data, size_t size, int *fdp) > +uds_recv(void *ctx, void *data, size_t size, int *fdp) > { > struct uds_ctx *uctx = ctx; > I've got a build error after that: /usr/src/sbin/hastd/proto_common.c:148:8: error: arithmetic on a pointer to void is a GNU extension [-Werror,-Wgnu-pointer-arith] 148 | data += done; | ~~~~ ^ -- Renato Botelho