From nobody Tue Oct 20 13:29:02 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j8CtR1j2Fz6x1PD for ; Tue, 20 Oct 2026 13:29:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4j8CtQ57njz3GTg for ; Tue, 20 Oct 2026 13:29:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792502942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yb3CyLvGAqjjn9bsvd4KXwIfbTemfQiAu6eftqTP6DA=; b=VGRpCeEv+5w59zArktB9C8AnBbQz3daNY7xbG610Sl7VdRYSrAOqJVOclrPBK13+0SRfN0 9oe8QTmRdxYO+O18xxpSKowGO13N5CJv2Rz/Jxsvi1MresoDs9bUe+a5yUHdGZaaUvaPIk jK6HL7xcIo3ksnjhc0zCuyCZWIQEL1HpJlmTIzG2ECInmB4LhS0s4HB1QZG7tzO93JqMca 2dgAfX6dv86rr4MFsuhsrL32e+6wlsbR7nxwC/2sPRZXtptoDDPkISPo9iJJoeGZQy4hwU 5T9OumoZwCZ4USbPkFX6mzJ4tvs+dxEPCwdGLvanYlKGw6JMuAoL0qlouVf2dQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792502942; b=JlDyQLdvWt0sWEUFDMVK1+v6tat8gDQzWwxk1xBsuVcz+zn9IjIXvzy+3AQG7jgpAc8UjD tYhPwyyqq1ZYFSWFe6GPxG5661YfjJxzPgiedBEpCmVSIVJ3FXN0cQq3DURw2VJ0QMV1MZ anlA5J/Ha9ggtDZC8g+WFDWm23b7fglMpDq+yGJkwFwN50y0GcCDREb54t4FqD5aGftNLY +ubxDHY9GMRZJe9ff1reea0nQdf6nIk420dn2/VI2TSsioE0MocbiLadHo4knGLhSddwwq z2NzsEYaJLTvmvRXGZMjlGs8MadL0fKe/5DsYgAJPo3y6TaFODccIXlltBqZWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792502942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yb3CyLvGAqjjn9bsvd4KXwIfbTemfQiAu6eftqTP6DA=; b=tZBul3KSw1Uhx91SuqGTAmGzBxN7aT6lAfzcoP5jX7PMZP2f9JQlm1tYZKdMw2HXYP4y70 DLG75NXDIeKOXGx9w6vzAamKiHv1cQkcNbB9bryDaTo5eSYLCqTqO2B7Jk2LosPv7Zy1mm DzcfUv8/5V9c17IZLgpF0Ps3vZE/OQllQpnFHaSHKTf1EcYYTjuFH73u9FmbMSj2StWUL5 M6pDTCsIcFYPvsA0BF2C14nmi7P18zM+ayveIsvFgVkRfQD8GZLfL5a0P/DbYIiDgARtYO FeEfaX/rK8XysJbeZ0CxPZwZuAibEOqYDbHP3qt8uEWztIYteA7gIKRrJ1JKSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j8CtQ4Vt7z18Lb for ; Tue, 20 Oct 2026 13:29:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c2aa by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 20 Oct 2026 13:29:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: a5e6bee5a0bf - main - hastd: Use void pointers for opaque data List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a5e6bee5a0bff9e9c12037e0b2c76c4f2ab5e046 Auto-Submitted: auto-generated Date: Tue, 20 Oct 2026 13:29:02 +0000 Message-Id: <6ad76c9e.3c2aa.428145e9@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=a5e6bee5a0bff9e9c12037e0b2c76c4f2ab5e046 commit a5e6bee5a0bff9e9c12037e0b2c76c4f2ab5e046 Author: Dag-Erling Smørgrav AuthorDate: 2026-10-20 13:28:42 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-10-20 13:28:42 +0000 hastd: Use void pointers for opaque data Use void, not char, for pointers to opaque data in our send and receive functions. Sponsored by: Klara, Inc. Reviewed by: allanjude Differential Revision: https://reviews.freebsd.org/D60729 --- sbin/hastd/proto_common.c | 4 ++-- sbin/hastd/proto_impl.h | 8 ++++---- sbin/hastd/proto_socketpair.c | 4 ++-- sbin/hastd/proto_tcp.c | 4 ++-- sbin/hastd/proto_uds.c | 4 ++-- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/sbin/hastd/proto_common.c b/sbin/hastd/proto_common.c index 39ef696f5b69..c96b325a4130 100644 --- a/sbin/hastd/proto_common.c +++ b/sbin/hastd/proto_common.c @@ -89,7 +89,7 @@ proto_descriptor_send(int sock, int fd) } int -proto_common_send(int sock, const unsigned char *data, size_t size, int fd) +proto_common_send(int sock, const void *data, size_t size, int fd) { ssize_t done; size_t sendsize; @@ -190,7 +190,7 @@ proto_descriptor_recv(int sock, int *fdp) } int -proto_common_recv(int sock, unsigned char *data, size_t size, int *fdp) +proto_common_recv(int sock, void *data, size_t size, int *fdp) { ssize_t done; diff --git a/sbin/hastd/proto_impl.h b/sbin/hastd/proto_impl.h index 181a4cd4a17d..449ab4097397 100644 --- a/sbin/hastd/proto_impl.h +++ b/sbin/hastd/proto_impl.h @@ -44,8 +44,8 @@ typedef int prt_connect_wait_t(void *, int); typedef int prt_server_t(const char *, void **); typedef int prt_accept_t(void *, void **); typedef int prt_wrap_t(int, bool, void **); -typedef int prt_send_t(void *, const unsigned char *, size_t, int); -typedef int prt_recv_t(void *, unsigned char *, size_t, int *); +typedef int prt_send_t(void *, const void *, size_t, int); +typedef int prt_recv_t(void *, void *, size_t, int *); typedef int prt_descriptor_t(const void *); typedef bool prt_address_match_t(const void *, const char *); typedef void prt_local_address_t(const void *, char *, size_t); @@ -72,7 +72,7 @@ struct proto { void proto_register(struct proto *proto, bool isdefault); -int proto_common_send(int sock, const unsigned char *data, size_t size, int fd); -int proto_common_recv(int sock, unsigned char *data, size_t size, int *fdp); +int proto_common_send(int sock, const void *data, size_t size, int fd); +int proto_common_recv(int sock, void *data, size_t size, int *fdp); #endif /* !_PROTO_IMPL_H_ */ diff --git a/sbin/hastd/proto_socketpair.c b/sbin/hastd/proto_socketpair.c index 31b657f17c32..a5f47acc7272 100644 --- a/sbin/hastd/proto_socketpair.c +++ b/sbin/hastd/proto_socketpair.c @@ -82,7 +82,7 @@ sp_client(const char *srcaddr, const char *dstaddr, void **ctxp) } static int -sp_send(void *ctx, const unsigned char *data, size_t size, int fd) +sp_send(void *ctx, const void *data, size_t size, int fd) { struct sp_ctx *spctx = ctx; int sock; @@ -121,7 +121,7 @@ sp_send(void *ctx, const unsigned char *data, size_t size, int fd) } static int -sp_recv(void *ctx, unsigned char *data, size_t size, int *fdp) +sp_recv(void *ctx, void *data, size_t size, int *fdp) { struct sp_ctx *spctx = ctx; int fd; diff --git a/sbin/hastd/proto_tcp.c b/sbin/hastd/proto_tcp.c index aeec887433f8..be1205ba3733 100644 --- a/sbin/hastd/proto_tcp.c +++ b/sbin/hastd/proto_tcp.c @@ -479,7 +479,7 @@ tcp_wrap(int fd, bool client, void **ctxp) } static int -tcp_send(void *ctx, const unsigned char *data, size_t size, int fd) +tcp_send(void *ctx, const void *data, size_t size, int fd) { struct tcp_ctx *tctx = ctx; @@ -492,7 +492,7 @@ tcp_send(void *ctx, const unsigned char *data, size_t size, int fd) } static int -tcp_recv(void *ctx, unsigned char *data, size_t size, int *fdp) +tcp_recv(void *ctx, void *data, size_t size, int *fdp) { struct tcp_ctx *tctx = ctx; diff --git a/sbin/hastd/proto_uds.c b/sbin/hastd/proto_uds.c index acb61a360180..5a14eb353c30 100644 --- a/sbin/hastd/proto_uds.c +++ b/sbin/hastd/proto_uds.c @@ -227,7 +227,7 @@ uds_accept(void *ctx, void **newctxp) } static int -uds_send(void *ctx, const unsigned char *data, size_t size, int fd) +uds_send(void *ctx, const void *data, size_t size, int fd) { struct uds_ctx *uctx = ctx; @@ -239,7 +239,7 @@ uds_send(void *ctx, const unsigned char *data, size_t size, int fd) } static int -uds_recv(void *ctx, unsigned char *data, size_t size, int *fdp) +uds_recv(void *ctx, void *data, size_t size, int *fdp) { struct uds_ctx *uctx = ctx;