From nobody Tue Oct 20 05:36:08 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j81Nm5btwz6wPbY for ; Tue, 20 Oct 2026 05:36:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4j81Nm4m1nz59Ky for ; Tue, 20 Oct 2026 05:36:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792474568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+0YAC5PfSD6vLh1ymhLhTw/IsppLX9EobUgM7g0+rrM=; b=UEWGvVpBU6EHQJHU9lGgc2fUIH+LIkhqaYaSrpkwyRi0gWYvkipVfwM1hSLr/hdUnElHiJ JgefIGvDq2nFBNbtBPPT5ejrvxVf+VhWwgd9RDo+gvVnWv6k7kvZWof7yR0gAqaSVvR5Sn rs58ybUUAlxN8RaCKUZAT0yXpvD8YLth0AvxF9aqacKI9puITE9TQ8oDPe7sZERZsQ6qYV nG5I/Xi2dOiy3Zw9bkbGcCHLsrvcxrrYW9yQ+UNLcyoVRX7n2+tlzOLXGX8hO1YuhDehLz CcP08OnmlTzrNhOWXJwobXxSi3gi3Sm4sbwhtDQyVoU469pNTVxnJ9E5aLCF9g== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792474568; b=yb2z2dSEDjLGz/+d5OtYIna66l6g+BNgF8IjCB5Br5SARDUUs9uMo7kYaKlVNnqIVr2DTr ttgv3Y3o8D0nJm+ITfttVoo0Y63TfniFwCW8nSLscdMrbV4sKvQ+PlzXvdDpD6XvFZN1tK 9pWpWWbyjWsWeDZP72JfpKF3ry4zQq8KU2ktFcOFcmKwyLBxHbwYLxPWGSjtyHlHnwAp3I Y1eFFH54KuJPMqEaoQSVbZ9jBYu8USsRJo6yGR6qLKhXb77oovvG1xv+/aCWg6ydRhu2G5 OByXGqs3W/WJoUkl7HTbZ9Lado/yceM//+elqjobzyZtgHEAPyXa3ZZYYacBBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792474568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+0YAC5PfSD6vLh1ymhLhTw/IsppLX9EobUgM7g0+rrM=; b=LSL0uIdM2ly1ysdYCtx8FM1evtk9EV5bbVP715up+FucRPi5C9ArmthkJ5s/WHHJUyk60X D70xxgpZ5RCD9KLaUwLoju5ZZ1fNaW66v3zT14CtrhsZs1UmRS3WWyaRUX97yVNMBtqXSg OlM8sqrBbTScmK2RLfIgSVBpu2zeM1Y94UEIEIt495RDIjhN+b+fvc6NKZDqnqdxIzbJRO pcWTf1Pqf6XFIpW0KjDz7WjCenABYTp1Dky/lVga6a54Owr10bbaHdmJBopdHM5Zq+FIjR Dm9Db0dOdJ6O2+1bhaC0awmeqKlSQh9WZawg5BJ83GDI9TlmEbHTuMQLH+0W4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j81Nm4QQszvKQ for ; Tue, 20 Oct 2026 05:36:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31317 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 20 Oct 2026 05:36:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: dbbff47e274c - main - Retire bogus predicts on case statements. List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dbbff47e274c16d56c6adf42fecbb33157718287 Auto-Submitted: auto-generated Date: Tue, 20 Oct 2026 05:36:08 +0000 Message-Id: <6ad6fdc8.31317.745b9cfb@gitrepo.freebsd.org> The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=dbbff47e274c16d56c6adf42fecbb33157718287 commit dbbff47e274c16d56c6adf42fecbb33157718287 Author: Mateusz Guzik AuthorDate: 2026-10-20 05:24:13 +0000 Commit: Mateusz Guzik CommitDate: 2026-10-20 05:24:13 +0000 Retire bogus predicts on case statements. They are ignored by clang. No functional changes (nor .o changes). Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/dev/gve/gve_tx_dqo.c | 2 +- sys/dev/random/random_harvestq.c | 2 +- sys/kern/kern_malloc.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/dev/gve/gve_tx_dqo.c b/sys/dev/gve/gve_tx_dqo.c index 551a7e308d19..0561092105fa 100644 --- a/sys/dev/gve/gve_tx_dqo.c +++ b/sys/dev/gve/gve_tx_dqo.c @@ -437,7 +437,7 @@ gve_map_mbuf_dqo(struct gve_tx_ring *tx, *mbuf, segs, nsegs, BUS_DMA_NOWAIT); switch (err) { - case __predict_true(0): + case 0: break; case EFBIG: if (__predict_false(attempt > 0)) diff --git a/sys/dev/random/random_harvestq.c b/sys/dev/random/random_harvestq.c index 296721d2c4e9..3d3588937cf3 100644 --- a/sys/dev/random/random_harvestq.c +++ b/sys/dev/random/random_harvestq.c @@ -443,7 +443,7 @@ random_harvest_healthtest(const struct harvest_event *event) } switch (ht->ht_state) { - case __predict_false(INIT): + case INIT: /* Store the first sample and initialize test state. */ random_healthtest_rct_init(ht, event); random_healthtest_apt_init(ht, event); diff --git a/sys/kern/kern_malloc.c b/sys/kern/kern_malloc.c index ffc260781d60..d2dd7ec5acee 100644 --- a/sys/kern/kern_malloc.c +++ b/sys/kern/kern_malloc.c @@ -916,7 +916,7 @@ _free(void *addr, struct malloc_type *mtp, bool dozero) dozero, addr, (void *)((uintptr_t)addr & (~UMA_SLAB_MASK))); switch (GET_SLAB_COOKIE(slab)) { - case __predict_true(SLAB_COOKIE_SLAB_PTR): + case SLAB_COOKIE_SLAB_PTR: size = zone->uz_size; #if defined(INVARIANTS) && !defined(KASAN) free_save_type(addr, mtp, size); @@ -1014,7 +1014,7 @@ realloc(void *addr, size_t size, struct malloc_type *mtp, int flags) /* Get the size of the original block */ switch (GET_SLAB_COOKIE(slab)) { - case __predict_true(SLAB_COOKIE_SLAB_PTR): + case SLAB_COOKIE_SLAB_PTR: alloc = zone->uz_size; break; case SLAB_COOKIE_MALLOC_LARGE: @@ -1109,7 +1109,7 @@ malloc_usable_size(const void *addr) addr, (void *)((u_long)addr & (~UMA_SLAB_MASK))); switch (GET_SLAB_COOKIE(slab)) { - case __predict_true(SLAB_COOKIE_SLAB_PTR): + case SLAB_COOKIE_SLAB_PTR: size = zone->uz_size; break; case SLAB_COOKIE_MALLOC_LARGE: