From nobody Mon Oct 19 19:15:33 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j7lck1J7Vz6vslx for ; Mon, 19 Oct 2026 19:15:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4j7lcj6SR7z4vpn for ; Mon, 19 Oct 2026 19:15:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792437333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tlS7x95npPDlHwRilPhG6tp/7fNKzXwjCFTpO2jpOyA=; b=RvGGbeZAjkmrYrcAdjGftik4S0/q+Hd2XNowwKXqIW4dawFQzpwnIH44iurvj6vJI2N9Kt D9AJt8Lnt/gBPx0qPZI81G5o3760SMlTyvL8n34lzcXx1STj7OIviovILh2TpF4EGygjLs DkF8JLziz5wgS85ElgxDh9Qi1LTCj4KB2E88lrBGa355gT6qA2J4yyH3ngpZiMkHk2deu2 xsc8kEMgSQN6a7yTsneDq+lbzuiJGJ9LSvEWE68cFQftfe1i9jHeNAHwQEfgEL4mLvmH7i +7r+dd4BnnOOiIJod96O7vT4kagaphHqlSsm+DgIK6rhp9k5bVah5ooYFGngkw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792437333; b=OTMjzD2s7vF7dBY16FY/gKiHfEVN7ZeStlR2PH4i5P1cfNrKJjeVYnvVlS2QqRyV+lIGkU guXbp7XxShRet1/0/ZrznJusZGOnJqU3b8zipVFyxz7x1GIEAOFnSpDgcKjNdnQQQ9NmJI eFhaYhP10O6BZ3xYmSL08L9MszFkFr5fNOa3S44NgzNDmfWBZf50uny4BX/VZanytNd7lS 2ZtJzlwtL3LRsKKY05J0TkTrCDwcKQzyyfbzhEPHLHSt3HmePnVoKh0KFQEgLWpsb9asJI 1PkuVJWyHUi1fXTJjf+vcxSKwNjIXkADAimuMF5dF+RPQf2sJUpVRhh+tJ52XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792437333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tlS7x95npPDlHwRilPhG6tp/7fNKzXwjCFTpO2jpOyA=; b=bXRahDPhiDrCkNLipxQg8WzJmaoPBBpii0CqoJkEdjnSn4VI99KMnGnvCWIKrPxP551pY1 bGH0VBUeZRgTH1eyXRWH6SKFYIG6IV3vOKAjDXkzNLkwyfTu6fe5ty8cpKCaNgXXYR4/7u KK8vPNP1KPMmfBA8MAtUutlKtYEBE95XFNGpxK/dcXkZtTMcEnVcaFYm+zybly6fSRGzzs m8PjHAyGmOEKvuvmTvHgRwGfvBAW+IJUmyF2y09npprGJaTA7fP7dDFVyn6ODHEU1VYmdF OZM6iC8mBBPGLlyS6idol9/SaOrtiFV6PRpRuISDG7m5Aqy9iIzexLMAjQmJbw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j7lcj5YQQzYxD for ; Mon, 19 Oct 2026 19:15:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32c7b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 19 Oct 2026 19:15:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: R. Christian McDonald Subject: git: 1594fbd7f2f4 - main - pfctl: Report the error of a failed fingerprint flush List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rcm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1594fbd7f2f4c1af3262d1abd8cb100be2fed414 Auto-Submitted: auto-generated Date: Mon, 19 Oct 2026 19:15:33 +0000 Message-Id: <6ad66c55.32c7b.40d48e1c@gitrepo.freebsd.org> The branch main has been updated by rcm: URL: https://cgit.FreeBSD.org/src/commit/?id=1594fbd7f2f4c1af3262d1abd8cb100be2fed414 commit 1594fbd7f2f4c1af3262d1abd8cb100be2fed414 Author: R. Christian McDonald AuthorDate: 2026-10-19 18:44:09 +0000 Commit: R. Christian McDonald CommitDate: 2026-10-19 19:14:04 +0000 pfctl: Report the error of a failed fingerprint flush pfctl_flush_fingerprints() returns an error number instead of setting errno, so a failed flush was reported with whatever errno held: "No error: 0" on a kernel with ALTQ, ENODEV from the ALTQ probe on one without. Every "pfctl -f" flushes the fingerprints first, so on a kernel that predates PFNL_CMD_OSFP_FLUSH every ruleset load fails this way without saying why. Reviewed by: kp Fixes: 75c0a8376204 ("pf: convert DIOCOSFPFLUSH DIOCOSFPGET DIOCOSFPADD to netlink") Sponsored by: Rubicon Communications, LLC ("Netgate") --- sbin/pfctl/pfctl_osfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/pfctl/pfctl_osfp.c b/sbin/pfctl/pfctl_osfp.c index b1c1908cb3fc..943b86752e72 100644 --- a/sbin/pfctl/pfctl_osfp.c +++ b/sbin/pfctl/pfctl_osfp.c @@ -263,7 +263,7 @@ pfctl_file_fingerprints(int dev, int opts, const char *fp_filename) void pfctl_clear_fingerprints(int dev, int opts) { - if (pfctl_flush_fingerprints(pfh) != 0) + if ((errno = pfctl_flush_fingerprints(pfh)) != 0) pfctl_err(opts, 1, "DIOCOSFPFLUSH"); }