From nobody Mon Oct 19 06:24:38 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j7QWC0mVRz6vsSN for ; Mon, 19 Oct 2026 06:24:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4j7QWB4mDMz3Pyx for ; Mon, 19 Oct 2026 06:24:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792391078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Iz009aU7wnjI3uRF9nawcogG8d2GznbY0jPKcBvEyiw=; b=ySxsXSAJ/kXIx2K6ry2xIQwebD4vyXrx9rEkpxJuAfZgMSKlw5VdASHacBf4e+VEm3w6c2 oNyaFZTHBbwzzoxmjfhWIeXpMcEi8VDXVpKpZVkJV1DLoLQGl2ERnfTzJGFfCwVRgXmzje rWRv1eLDQVPXneiHqHtf7pKkZRbbY30DVTkcYtd2fBteNaezUHwSNYbmGFyvs6S/FRht7s CDnNeureAY9cua6DQHWbzc/Qpqm1RB+LzUZtuxEkaV69RuVSVRs6Km9mWlfUYae5lkShC0 70ZnlDZtg9JSPt8XtpP142wDz3uGpkqcqG6js27Q6KJErRombXb9nsPWZivZUg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1792391078; b=CErHfhYx99v+FNpG82zgs7fTDtu9UXZYtm1gRTzVUU8dkAJtrtMioHAuIp1iXjiNcfLVXg Nq8/QrsPppNZsMziQzCcQPZXuCRhhYw+WUYgYr4cm8x4CuHVM78oZZbpFgJm9ND2udnwjS H/ucWHirDSj2VkK7SWWzGsj19/O6+SpKAXGMZ0TjnWjSqhMwgAA+XuULGX2yA+0l88lQ6q SepDapkzYNxrwbwewU45RqEnuO/MDetpmTn4xNNuomS4FJIzUSbWgPjCwNP00GfNIa7KbF eaMuIbcQJh5o023cqFn/vfHljbKokP7CAQLMPx84Zxe6K8VMCQ2AgpcYkJtZ+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1792391078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Iz009aU7wnjI3uRF9nawcogG8d2GznbY0jPKcBvEyiw=; b=xhLBlfOPJW+CfT9qT8VTngL3ob9jLWN57ZN/X4+X96oNMLloVUVQX4cjpV8lkOAOql0+/b QWhJOZGtJtIFJBE4PBIragVLuYlC65VC+xeFA7DBbncFAayUr7VR10K3uZaE+pTv4q/2HP QzzvnhNhbN3PrNN+Z2BB4ssk4DqPnVoohbpq5THSQ4eFmoB5QBNA8ebOX64at8rC+VzGbd NkiXRhLmVw8EjmxzqD2bh51kzbBHYUt0w6HFk+5oGqKkBLTmJevF2suVAHC3zDzdhGkHK/ XqX+1zB2JbXFUezCWZPRDCegWidE/aY4OZtNcTqchP4ulAW/rMcTmsiuyOwbPA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j7QWB4L8Bz1NqK for ; Mon, 19 Oct 2026 06:24:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33392 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 19 Oct 2026 06:24:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 66c24c94323a - main - nvme: Refactor namespace notifications for additions List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 66c24c94323ae36f2132c60bc2788ab70b60f224 Auto-Submitted: auto-generated Date: Mon, 19 Oct 2026 06:24:38 +0000 Message-Id: <6ad5b7a6.33392.16f321eb@gitrepo.freebsd.org> The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=66c24c94323ae36f2132c60bc2788ab70b60f224 commit 66c24c94323ae36f2132c60bc2788ab70b60f224 Author: Warner Losh AuthorDate: 2026-10-19 04:40:45 +0000 Commit: Warner Losh CommitDate: 2026-10-19 06:22:50 +0000 nvme: Refactor namespace notifications for additions When we add a namespace, we have the code inline to do the notifications. Refactor ahead or reuse. Reviewed by: seuros Differential Revision: https://reviews.freebsd.org/D59831 --- sys/dev/nvme/nvme_ctrlr.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index 7b2c73c5863b..f27653536c66 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -657,6 +657,22 @@ nvme_ctrlr_construct_namespaces(struct nvme_controller *ctrlr) return (0); } +static void +nvme_ctrlr_notify_ns_added(struct nvme_controller *ctrlr, device_t child) +{ + struct nvme_namespace *ns; + + /* + * Notify the consumer of all currently active namespaces. + */ + for (int i = 0; i < nvme_ctrlr_num_namespaces(ctrlr); i++) { + ns = &ctrlr->ns[i]; + if (ns->data.nsze == 0) + continue; + NVME_NS_ADDED(child, ns); + } +} + static bool is_log_page_id_valid(uint8_t page_id) { @@ -1253,17 +1269,7 @@ nvme_ctrlr_start_config_hook(void *arg) child = device_add_child(ctrlr->dev, NULL, DEVICE_UNIT_ANY); device_set_ivars(child, ctrlr); bus_attach_children(ctrlr->dev); - - /* - * Now notify the child of all the known namepsaces - */ - for (int i = 0; i < nvme_ctrlr_num_namespaces(ctrlr); i++) { - struct nvme_namespace *ns = &ctrlr->ns[i]; - - if (ns->data.nsze == 0) - continue; - NVME_NS_ADDED(child, ns); - } + nvme_ctrlr_notify_ns_added(ctrlr, child); } TSEXIT(); }